How to Close Connections made In Servlet

[Steve Dyke]

I make a request to servlet which contains code to get a connection to a remote database, assign resultset data to an array, close connection, then display that array in a form. What happens if the user makes the request then closes the browser before the data is received and the close connection is never called. How can I make sure the close connection is aways ran if a connection is made?

[Paul Sturrock]

Always close connections in a finally block.

[Steve Dyke]

Paul Sturrock wrote:Always close connections in a finally block.

How would this be fired if page is closed abnormally?

[Steve Dyke]

Paul Sturrock wrote:Always close connections in a finally block.

here is an example of my servlet code

protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
				
		response.setHeader( "Pragma", "no-cache" );
		response.setHeader( "Cache-Control", "no-cache" );
		response.setDateHeader( "Expires", 0 );
		
		int dispositionIndex = Integer.parseInt(request.getParameter("p1")); //Disposition Index
								
		String jReturnString = "";
				
		GetAs400Connection  gConn = new GetAs400Connection();
		gConn.setAs400Conn();
				
		DispositionConnection dConn = new DispositionConnection();
		dConn.setOpenDispositionDataByDispositionIndex(gConn.getAs400Conn(), dispositionIndex);
						
		jReturnString = "{\"errorString\": \"" + dConn.getErrorstring() + "\", \"dispIndex\": \"" + dConn.getDispositionIndex() + "\", \"dispType\": \"" + dConn.getDispositionType() + "\", \"finalFormIndex\": \"" + dConn.getFinalFormIndex() + "\"}";
			
		//System.out.println(jReturnString);
		gConn.setAs400Close(gConn.getAs400Conn());
		
		response.getWriter().write(jReturnString);
	} 

[Paul Sturrock]

Finally blocks are always called. That is why you use them.

[Farakh khan]

hi, Paul is correct

Connection 	cnn=null;
ResultSet 	 	rs=null;	


try{//changes-1			
	
		//Your code.....
		
}catch(Exception e){
	e.printStack();
	}

finally  {      
	try {        
		if ( rs  != null ) 	 rs.close();    
		if ( cnn != null )  	cnn.close();      
	} catch(SQLException ex) {          
	ex.printStack();
	}
}
response.getWriter().write(jReturnString);
} 
}

[Steve Dyke]

Farakh khan wrote:hi, Paul is correct

Connection 	cnn=null;
ResultSet 	 	rs=null;	


try{//changes-1			
	
		//Your code.....
		
}catch(Exception e){
	e.printStack();
	}

finally  {      
	try {        
		if ( rs  != null ) 	 rs.close();    
		if ( cnn != null )  	cnn.close();      
	} catch(SQLException ex) {          
	ex.printStack();
	}
}
response.getWriter().write(jReturnString);
} 
}

Thanks,

I am going back and adding the finally method to my connection instances(all 591 of them).