random.nextInt + If statements

[john price]

I am creating a password generator/fake password hacker. Is there a better way to do this?

Random random = new Random();
int jackme = random.nextInt(36) + 1;
char a = 'a';
if (jackme == 1) {a = '1';}
else if (jackme == 2) {a = '2';}
else if (jackme == 3) {a = '3';}
else if (jackme == 4) {a = '4';}
else if (jackme == 5) {a = '5';}
else if (jackme == 6) {a = '6';}
else if (jackme == 7) {a = '7';}
else if (jackme == 8) {a = '8';}
else if (jackme == 9) {a = '9';}
else if (jackme == 10) {a = '0';}
else if (jackme == 11) {a = 'a';}
else if (jackme == 12) {a = 'b';}
else if (jackme == 13) {a = 'c';}
else if (jackme == 14) {a = 'd';}
else if (jackme == 15) {a = 'e';}
else if (jackme == 16) {a = 'f';}
else if (jackme == 17) {a = 'g';}
else if (jackme == 18) {a = 'h';}
else if (jackme == 19) {a = 'i';}
else if (jackme == 20) {a = 'j';}
else if (jackme == 21) {a = 'k';}
else if (jackme == 22) {a = 'l';}
else if (jackme == 22) {a = 'm';}
else if (jackme == 23) {a = 'n';}
else if (jackme == 24) {a = 'o';}
else if (jackme == 25) {a = 'p';}
else if (jackme == 26) {a = 'q';}
else if (jackme == 27) {a = 'r';}
else if (jackme == 28) {a = 's';}
else if (jackme == 29) {a = 't';}
else if (jackme == 30) {a = 'u';}
else if (jackme == 31) {a = 'v';}
else if (jackme == 32) {a = 'w';}
else if (jackme == 33) {a = 'x';}
else if (jackme == 34) {a = 'y';}
else if (jackme == 35) {a = 'z';}

Thanks,
John Price aka cc11rocks

[Henry Wong]

john price wrote:I am creating a password generator/fake password hacker. Is there a better way to do this?

Random random = new Random();
int jackme = random.nextInt(36) + 1;
char a = 'a';
if (jackme == 1) {a = '1';}
else if (jackme == 2) {a = '2';}
else if (jackme == 3) {a = '3';}
else if (jackme == 4) {a = '4';}
else if (jackme == 5) {a = '5';}
else if (jackme == 6) {a = '6';}
else if (jackme == 7) {a = '7';}
else if (jackme == 8) {a = '8';}
else if (jackme == 9) {a = '9';}
else if (jackme == 10) {a = '0';}
else if (jackme == 11) {a = 'a';}
else if (jackme == 12) {a = 'b';}
else if (jackme == 13) {a = 'c';}
else if (jackme == 14) {a = 'd';}
else if (jackme == 15) {a = 'e';}
else if (jackme == 16) {a = 'f';}
else if (jackme == 17) {a = 'g';}
else if (jackme == 18) {a = 'h';}
else if (jackme == 19) {a = 'i';}
else if (jackme == 20) {a = 'j';}
else if (jackme == 21) {a = 'k';}
else if (jackme == 22) {a = 'l';}
else if (jackme == 22) {a = 'm';}
else if (jackme == 23) {a = 'n';}
else if (jackme == 24) {a = 'o';}
else if (jackme == 25) {a = 'p';}
else if (jackme == 26) {a = 'q';}
else if (jackme == 27) {a = 'r';}
else if (jackme == 28) {a = 's';}
else if (jackme == 29) {a = 't';}
else if (jackme == 30) {a = 'u';}
else if (jackme == 31) {a = 'v';}
else if (jackme == 32) {a = 'w';}
else if (jackme == 33) {a = 'x';}
else if (jackme == 34) {a = 'y';}
else if (jackme == 35) {a = 'z';}

Thanks,
John Price aka cc11rocks

You seem to have a couple of bugs -- such as 22 is assigned to two letters, but I get the gist of what you are trying to do....

Try....

Random random = new Random();
int jackme = random.nextInt(36);
char a = (char)((jackme < 10) ? (jackme + '0') : (jackme + 'a' - 10));  

Henry

[john price]

It works perfect thanks! Could you please explain this:

jackme + 'a' - 10

Like I understand it but why is this possible? I see
"char = char1 + char2 - int"
Thanks,
cc11rocks aka John Price

[Henry Wong]

john price wrote:
Like I understand it but why is this possible? I see
"char = char1 + char2 - int"

Please take another look again. You'll see that it is something else, and it is valid.

Henry

[john price]

Thanks for your help. Here is the program I came up with:

import javax.swing.*;
import java.awt.*;
import java.util.*;
import java.awt.event.*;
import java.text.*;
import java.io.*;
public class Hacker {

JFrame window = new JFrame("Password Maker");
boolean over;
int x;
long combinations;
double counter;
char a = 'a';
String hacked = "";
JButton save = new JButton("Save Password");
StringBuffer str = new StringBuffer("");
JTextArea finished = new JTextArea();
JButton start = new JButton("Start");
JRadioButton four = new JRadioButton("Four");
JRadioButton eight = new JRadioButton("Eight");
JRadioButton ten = new JRadioButton("Ten");
JRadioButton twelve = new JRadioButton("Twelve");
JRadioButton fourteen = new JRadioButton("Fourteen");
JRadioButton sixteen = new JRadioButton("Sixteen");
JRadioButton eighteen = new JRadioButton("Eighteen");
JRadioButton twenty = new JRadioButton("Twenty");

public Hacker() {
fourteen.setSelected(true);
ButtonGroup group = new ButtonGroup();
group.add(four);
group.add(eight);
group.add(ten);
group.add(twelve);
group.add(fourteen);
group.add(sixteen);
group.add(eighteen);
group.add(twenty);
JLabel nwer = new JLabel("Characters in Password:");
nwer.setBounds(0, 0, 300, 20);
save.setBounds(200, 150, 130, 20);
window.add(save);
save.setEnabled(false);
save.addActionListener(new ActionListener() {
public void actionPerformed (ActionEvent e) {
JFileChooser fc = new JFileChooser();
int returnVal = fc.showSaveDialog(window);
File file = fc.getSelectedFile();
if (returnVal == JFileChooser.APPROVE_OPTION) {
boolean error = false;
try {
FileWriter f0 = new FileWriter(file);
f0.write(str.toString());
f0.close();
}
catch (Exception exe) {
exe.printStackTrace();
error = true;
}
if (error) {
JOptionPane.showMessageDialog(null, "There was an error in saving your password. Please try again...", "Save Failed", JOptionPane.ERROR_MESSAGE);
}
else {
JOptionPane.showMessageDialog(null, "Your password has been saved successfully!", "Successful Save!", JOptionPane.INFORMATION_MESSAGE);
}
}
}
});
window.add(nwer);
four.setBounds(0, 20, 75, 20);
eight.setBounds(75, 20, 75, 20);
ten.setBounds(150, 20, 75, 20);
twelve.setBounds(225, 20, 75, 20);
fourteen.setBounds(0, 40, 75, 20);
sixteen.setBounds(75, 40, 75, 20);
eighteen.setBounds(150, 40, 75, 20);
twenty.setBounds(225, 40, 75, 20);
window.add(four);
window.add(eight);
window.add(ten);
window.add(twelve);
window.add(fourteen);
window.add(sixteen);
window.add(eighteen);
window.add(twenty);
window.setLayout(null);
start.setBounds(0, 150, 85, 20);
window.add(start);
finished.setEditable(false);
finished.setBackground(window.getBackground());
finished.setBorder(null);
window.add(finished);
window.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
window.setSize(350, 210);
Toolkit tk = Toolkit.getDefaultToolkit();
Dimension d = tk.getScreenSize();
window.setLocation(d.width/2 - 205, d.height/2 - 105);
window.setResizable(false);
window.setVisible(true);
start.addActionListener(new ActionListener() {
public void actionPerformed (ActionEvent e) {
save.setEnabled(true);
if (four.isSelected()) {counter = 4.00; over = false;}
else if (eight.isSelected()) {counter = 8.00; over = false;}
else if (ten.isSelected()) {counter = 10.00; over = false;}
else if (twelve.isSelected()) {counter = 12.00; over = true;}
else if (fourteen.isSelected()) {counter = 14.00; over = true;}
else if (sixteen.isSelected()) {counter = 16.00; over = true;}
else if (eighteen.isSelected()) {counter = 18.00; over = true;}
else {counter = 20.00; over = true;}
combinations = (long) Math.pow(62.00, counter);
start.setText("New Key");
x = 0;
a = 'a';
hacked = "";
str = new StringBuffer("");
finished.setText("");
for (int y = 0; y < counter; y++) {
x ++;
hack(y);
x = 0;
}
String javact = NumberFormat.getInstance().format(combinations);
if (!over) {
finished.setText("Key Found (" + javact + " combinations possible) :\n" + str);
}
else {
int newKey = (int) counter;
finished.setText("Key Found (62 " + " ^ " + newKey + " combinations are possible) :\n" + str);
}
finished.setBounds(0, 100, 410, 40);
}
});
}
public static void main(String args[]) {
Hacker hacker = new Hacker();
}
private void hack (int q) {
Random random = new Random();
int jackme = random.nextInt(36);
char a = (char)((jackme < 10) ? (jackme + '0') : (jackme + 'a' - 10));  
if (Character.isLetter(a)) {
if (random.nextBoolean()) {
a = Character.toUpperCase(a);
}
}
if (hacked.length() <= q) {
str.append(a);
}
else {
int L = hacked.length() - 1;
str.setCharAt(L, a);
}
hacked = str.toString();
}
}

I'm going to add more JRadioButtons (more password length options), but here it is. It is fully runnable. Thank you very much!
cc11rocks aka John Price