Struts File Upload Problem - File is written but empty

[Timothy Sam]

Hi guys, I'm trying to upload images through my action class. I'm quite sure the image is cached in the server memory but when I output to a file, the file is created but empty... Here is my servlet code...

package actions;
 

import java.sql.*;
 
import java.util.ArrayList;
 
import java.io.ByteArrayOutputStream;
import java.io.InputStream;
import java.io.OutputStream;
import java.io.FileOutputStream;
 
import dao.DBHelper;
 
import beans.ApplicantFormBean;
//import beans.NameFormBean;
//import beans.PersonalInfoFormBean;
//import beans.EmploymentFormBean;
import beans.PictureFormBean;
import beans.BenificiaryFormBean;
 

import validator.Validator;
import validator.NameValidator;
import validator.PictureValidator;
import validator.PersonalInfoValidator;
import validator.ParentValidator;
import validator.EducationValidator;
import validator.SkillsValidator;
import validator.PassportValidator;
 
//import beans.CitizenshipFormBean;
 
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
 
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
 
import org.apache.struts.action.ActionMessages;
import org.apache.struts.action.ActionMessage;
 
import org.apache.struts.upload.FormFile;
 
public class SubmitApplicationAction extends org.apache.struts.action.Action 
{
    public static final String FORWARD_success = "success"; 
    public static final String FORWARD_failed = "failed";
    
    public SubmitApplicationAction() 
    {
    }
    
    public ActionForward execute(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) throws Exception 
    {
    ActionMessages errors = new ActionMessages();
    
    ApplicantFormBean applicant = (ApplicantFormBean)form;
    
    
    for (int i = 0; i < applicant.getBenificiaries().size(); i++)
    {
    if ( applicant.getBenificiaries().get(i).getBenificiaryName().equals("") || applicant.getBenificiaries().get(i).getBenificiaryDateOfBirth().equals("") || applicant.getBenificiaries().get(i).getBenificiaryAddress().equals("") || applicant.getBenificiaries().get(i).getRelation().equals("")  )
    {
    applicant.getBenificiaries().remove(i);
    i = i - 1;
    //tmpBenificiaryList.add(benificiary);
    }
    }
 
    
    for (int i = 0; i < applicant.getEmploymentHistory().size(); i++)
    {
    if ( applicant.getEmploymentHistory().get(i).getFrom().equals("") || applicant.getEmploymentHistory().get(i).getTo().equals("") || applicant.getEmploymentHistory().get(i).getPosition().equals("") || applicant.getEmploymentHistory().get(i).getCompany().equals("")  )
    {
    applicant.getEmploymentHistory().remove(i);
    i = i - 1;
    //tmpBenificiaryList.add(benificiary);
    }
    }    
           
    
    ArrayList<Validator> requiredFieldList = new ArrayList<Validator>();
    
    
    //File upload(picture)
    PictureFormBean picture = applicant.getPicture();
    FormFile file = picture.getPicture();
    
    try
    {   
    ByteArrayOutputStream baos = new ByteArrayOutputStream();
    InputStream istream = file.getInputStream();
    
    byte[] buffer = new byte[8192];
    int bytesRead = 0;
    
    while ( (bytesRead = istream.read(buffer, 0, 8192)) != -1)
    {
    baos.write(buffer, 0, bytesRead);
    }
    
            //picture.setPictureId();
    picture.setPictureData( new String( baos.toByteArray() ) );
picture.setPictureSize( new Double(file.getFileSize() / 1024.00f).toString() ); 
picture.setPictureType( file.getContentType() );
    picture.setPictureName( file.getFileName() );
    
    //picture.getPicture().destroy(); //no need for this thing now
    
    applicant.setPicture(picture);
 
    requiredFieldList.add( new NameValidator( applicant.getName() ) );
    requiredFieldList.add( new PictureValidator(picture) );
    requiredFieldList.add( new PersonalInfoValidator( applicant.getPersonalInfo() ) );
    requiredFieldList.add( new ParentValidator( applicant.getParent() ) );
    requiredFieldList.add( new EducationValidator( applicant.getEducation() ) );
    requiredFieldList.add( new SkillsValidator( applicant.getSkills() ) );
    requiredFieldList.add( new PassportValidator( applicant.getPassport() ) );
    
    //picture.setPictureSize("0.00");
//picture.setPictureType("N/A");
    
            for (int i = 0; i < requiredFieldList.size(); i++)
            {
            errors.add( requiredFieldList.get(i).getError() );
            }
 
            
    if ( errors.isEmpty() )
    {
    try
    {
                    //DBHelper dao = new DBHelper();
                    //dao.insertPicture( applicant.getPicture(), istream);
        OutputStream ostream = new FileOutputStream("C:/GMUploads/" + applicant.getPicture().getPictureName() );
        int bytesRead2 = 0;
        byte[] buffer2 = new byte[8192];
        
        while ( ( bytesRead2 = istream.read(buffer2, 0 , 8192) ) != -1 )
        {
        ostream.write( buffer2, 0, bytesRead2);
        }
        
        ostream.close();
    }
    catch (Exception ex)
    {
    ex.printStackTrace();
    }
        
    }
    else
    {
            super.saveErrors(request, errors);
            
            return mapping.findForward(FORWARD_failed);
    }
    
    baos.close();
    istream.close();
    file.destroy();
    }
    catch(Exception ex)
    {
    ex.printStackTrace();
    
    //save IP address of user
    
    errors.add(ActionMessages.GLOBAL_MESSAGE, new ActionMessage("picture.critical") );
 
    super.saveErrors(request, errors);
        
        return mapping.findForward(FORWARD_failed);    
    }
 
    
    request.setAttribute("applicant", applicant);
    //request.setAttribute("benificiaryList", benificiaryList);
    //request.setAttribute("employmentList", employmentList);
    
    return mapping.findForward(FORWARD_success);
    }
    
}

I hope you could help me guys... Kinda feeling tired now... Thanks!