Struts 2 validation not working

[mike stewart]

I have searched everywhere on google and in these forums and can't figure out why this is not working. Here are my relavant files. I have left some things out but I don't believe I left out anything important. Any help would be greatly appreciated. Thank you in advance and sorry for the long post.



Struts.xml

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE struts PUBLIC "-//Apache Software Foundation//DTD Struts Configuration 2.0//EN" "http://struts.apache.org/dtds/struts-2.0.dtd">
<struts>
	<constant value="false" name="struts.enable.DynamicMethodInvocation" />
	<constant value="false" name="struts.devMode" />
	<package extends="struts-default" name="default">
		<interceptors>
		
			<interceptor name="validation" 
			class="org.apache.struts2.interceptor.validation.AnnotationValidationInterceptor"/>
			
			<interceptor name="login"
				class="com.hp.cte.login.action.SessionInterceptor" />
			<interceptor name="logging"
				class="com.hp.cte.common.logging.domain.LoggingInterceptor" />

			<interceptor name="model-driven"
				class="com.opensymphony.xwork2.interceptor.ModelDrivenInterceptor" />

			<interceptor name="auditAttributesInterceptor"
				class="com.hp.cte.interceptors.SetAuditAttributesInterceptor" />
				
			<interceptor name="activateBeanInterceptor"
				class="com.hp.cte.interceptors.ActivateBeanInterceptor"/>
				
			<interceptor name="logoutInterceptor" class="com.hp.cte.interceptors.LogoutInterceptor"/>
			
			<interceptor-stack name="loggingStack">
				<interceptor-ref name="workflow" />
				<interceptor-ref name="servletConfig" />
				<interceptor-ref name="params" />
				<interceptor-ref name="login" />
				<interceptor-ref name="model-driven" />
				<interceptor-ref name="basicStack" />
				<interceptor-ref name="logging" />
				<interceptor-ref name="validation" />
			</interceptor-stack>
		</interceptors>



		<default-interceptor-ref name="loggingStack" />

		<default-action-ref name="loginVerify" />

		<global-results>
			<result name="login">/WEB-INF/jsp/login.jsp</result>
			<result name="logout">/WEB-INF/jsp/login.jsp</result>
			<result name="login-success">/WEB-INF/jsp/sampleNavigation.jsp</result>
			<result name="Exception">/WEB-INF/jsp/utils/exception.jsp</result>
		</global-results>

 		<global-exception-mappings>
			<exception-mapping exception="com.hp.fait.exception.ConfigurationException"
				result="Exception" />
			<exception-mapping exception="java.lang.Exception"
				result="Exception" />
			<exception-mapping exception="java.lang.RuntimeException"
				result="Exception" />
			<exception-mapping exception="java.lang.NullPointerException"
				result="Exception" />
		</global-exception-mappings>

		<action name="loginVerify" method="loginVerify"
			class="com.hp.cte.login.action.LoginAction">
			<result name="input">WEB-INF/jsp/login.jsp</result>
			<result name="login">WEB-INF/jsp/login.jsp</result>
			<result name="success">WEB-INF/jsp/sampleNavigation.jsp</result>
		</action>
		
		<action name="logout" class="com.hp.cte.logout.action.LogoutAction">
            <interceptor-ref name="modelDrivenStack"/>
            <interceptor-ref name="logoutInterceptor"/>
			<result name="success">WEB-INF/jsp/login.jsp</result>		
		</action>
	</package>
	<include file="strutsAppProperties.xml" />
	<include file="strutsBusinessRules.xml" />
	<include file="strutsRules.xml" />
	<include file="strutsRuleSet.xml" />
	<include file="strutsRule.xml" />
	<include file="strutsSF04Incentives.xml" />
	<include file="strutsCFOPMessages.xml" />
	<include file="strutsSabrixLocationSets.xml" />
	<include file="strutsRuleValue.xml" />
	<include file="strutsUniversalTaxCodes.xml" />
	<include file="strutsSabrixTaxCodes.xml" />
	<include file="strutsSpecialTaxRules.xml" />
	<include file="strutsAppErrorCodes.xml" />
	<include file="strutsSabrixTaxLevels.xml" />
	<include file="strutsSabrixNetpConfig.xml" />
	<include file="strutsSabrixReverseCharge.xml" />
	<include file="strutsPayloadDumpRule.xml" />
	<include file="strutsUser.xml" />
	<include file="strutsBusinessGroup.xml" />
	<include file="strutsRole.xml" />
	<include file="strutsPayLoadRequest.xml" />
	<include file="strutsPerformance.xml" />
	<include file="strutsUniversalTaxCodes.xml" />
	<include file="strutsUnspscToPtcc.xml" />
	<include file="strutsTestGroup.xml"/> 
    <include file="strutsTestHeader.xml"/> 
    <include file="strutsDocLine.xml"/>
    <include file="strutsTestRequest.xml"/>
    <include file="strutsCtePerfServer.xml"/>
    <include file="strutsApplicationName.xml"/>
    <include file="strutsLocalCurrency.xml"/>
    <include file="strutsServer.xml"/>

</struts>

listTestGroup.jsp

<%@ page language="java" contentType="text/html; charset=ISO-8859-1" pageEncoding="ISO-8859-1"%>
<%@ taglib prefix="s" uri="/struts-tags" %>
<%@ taglib prefix="display" uri="http://displaytag.sf.net" %>
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<META http-equiv="Content-Type" content="text/html; charset=UTF-8">
<base href="http://<%=request.getServerName()%>:<%=request.getServerPort()%>/<%=request.getContextPath()%>/" />
<title>TestGroup Manager</title>
<link type="text/css" rel="stylesheet" href="Style/crud.css">
<link href="Style/cteStyles.css" rel="stylesheet" type="text/css" />
<script src="Script/crud.js" type="text/javascript"></script>
<script language="JavaScript" type="text/JavaScript"
	src="Script/cteNav.js"></script>
</head>
<body>
<%@ include file="navigationBar.jsp"%>
<s:form theme="simple" method="post">
	<div class="pageContainer">
	

	<!-- BEGIN SEARCH -->
  		<div class="contentTitle">Filter: </div>
  	
  		<div class="contentData">
  			<table class="searchTable">
		  				<tr>
		  					<td width="25%">Attribute: </td>
		  					<td width="25%">Operator: </td>
							<td width="25%">Criteria:</td>
							<td width="25%"></td>												
		  				</tr>
		  				<tr>
		  					<td>
			  					
	  		  						<s:select 
										headerKey="" 
										headerValue=""
										list="persistentBeanAttributes" 
										name="attribute"
										/>
								              				
		  					</td>
							<td>
										<s:select 
										headerKey="" 
										headerValue=""
										list="searchCriteriaOperators" 
										name="comparitor"
										/>
							</td>
							<s:fielderror/>
							<td><s:textfield label="criteria" name="criteria" /></td>
							<td>
								<s:submit type="image" src="Images/action_add.gif" action="addSearchTestGroup" title="Add Search Criteria" /> 
								<s:if test="queryCriteria.size > 0">
									<s:submit type="image" src="Images/action_delete.gif" action="resetSearchTestGroup" title="Delete All Search Criteria"/>  	
									<!--<s:submit type="image" src="Images/search.gif" action="listTestGroup" title="Search" />-->
								</s:if> 
							</td>
		  				</tr>		  				
		  			</table>
	<br>	  	
			<s:if test="queryCriteria.size > 0">
				<display:table 
					id="queryCriteria"
					name="queryCriteria"
					export="false"
					requestURI="listTestGroup"
					defaultsort="1"
					pagesize="5"
					class="its"
					defaultorder="ascending">
					<display:setProperty name="paging.banner.onepage" value="" />			
					<display:column property="attributeMnemonic" title="Attribute" sortable="false" headerClass="sortable" />	
					<display:column property="comparator.description" title="Operator" sortable="false" headerClass="sortable" />
					<display:column property="criteria" title="Criteria" sortable="false" headerClass="sortable" />
				</display:table>
			</s:if>					
  	</div>
  	<!-- END SEARCH -->
	<br>
		
		<div class="contentTitleWithExport" style="width: 100%">
   			<table class="exportTable">
  				<tr>
  					<td align="left">Test Groups</td>
  					<td align="right">
						<s:if test="%{displayGridList}">	
							<s:include value="/WEB-INF/jsp/utils/ExportLinks.jsp" />
						</s:if>
  					</td>
  				</tr>
  			</table>
  		</div> 
		<div class="contentData">		  	 
			<s:if test="%{displayGridList}">
				<div style="width: 100%; overflow-x: auto; height: 300px; overflow-y: auto;">	
					<display:table 
						id="beanList"
						name="beanList"
						export="false"
						requestURI="/testGroup/listTestGroup.action"
						defaultsort="0"
						pagesize="75"
						class="its"
						defaultorder="ascending"
						excludedParams="__checkbox_persistentBeanKey">
						<display:setProperty name="paging.banner.onepage" value="" />
						<display:column title="" style="width:16px" >
							<s:checkbox name="persistentBeanKey" fieldValue="%{#attr.beanList.keyString}" id="persistentBeanKey" onClick="disableList(this.form, this);" />
						</display:column>

	<display:column property="testgroupName" title="Test Group Name" sortable="true" headerClass="sortable"
		href="testHeader/listTestHeader.action" paramId="testgroupId" paramProperty="testgroupId"/>
	<display:column property="activeFlag" title="Is Active" sortable="true" headerClass="sortable" />
	<display:column property="testcaseCount" title="Test Case Count" sortable="true" headerClass="sortable" />
			<display:column property="createdDate" title="Creation Date"
				sortable="true" headerClass="sortable"
				format="{0,date,dd-MMM-yyyy HH:mm}" />
			<display:column property="createdBy" title="Created By"
				sortable="true" headerClass="sortable" />
			<display:column property="updatedDate"
				title="Last Modified Date" sortable="true" headerClass="sortable"
				format="{0,date,dd-MMM-yyyy HH:mm}" />
			<display:column property="updatedBy" title="Last Modified By"
				sortable="true" headerClass="sortable" />
					</display:table>
					</div>
				
					<div class="actions">
						<br />
							 <s:submit type="image" src="Images/action_add.gif" action="createTestGroup" title="Add" />
							 <s:submit type="image" src="Images/edit.gif" action="editTestGroup" onClick="return validateEdit(this.form);" title="Edit" />
							 <s:submit type="image" src="Images/onoff.png" action="activateTestGroup" onClick="return validateEdit(this.form);" title="Activate or deactivate" />					
					</div>	

		</s:if>		
		<s:elseif test="%{!displayGridList}">
				Enter search criteria and click the search icon to retrieve results or <a href="<s:url action="createTestGroup.action"/>"> Create New</a>.
				<br/>
				
		</s:elseif>
		
				
		</div>		
	</div>
	<s:property value="status"/>
</s:form>
</body>
</html>

TestGroupAction.java //there are getters and setters for all varilables even though they are not visable.

package com.hp.cte.testcases.action;

import java.math.BigDecimal;
import java.text.ParseException;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
import java.util.Map;

import org.apache.struts2.interceptor.SessionAware;
import org.apache.struts2.interceptor.validation.SkipValidation;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import com.hp.fait.exception.ConfigurationException;
import com.hp.fait.exception.PersistenceException;
import com.hp.fait.persistent.action.AbstractCrudSearchAction;
import com.hp.fait.persistent.domain.PersistentBean;
import com.hp.fait.persistent.factory.SearchCriteria;
import com.hp.cte.admin.domain.UserModel;
import com.hp.cte.common.LastActivityDate;
import com.hp.cte.common.action.AuditableBeanAction;
import com.hp.cte.common.action.ActivatableBeanAction;
import com.hp.cte.common.action.StatusAction;
import com.hp.cte.common.factory.CTESearchCriteria;
import com.hp.cte.login.action.SessionInterceptor;
import com.hp.cte.testcases.client.TestGroupClient;
import com.hp.cte.testcases.domain.TestGroup;
import com.hp.cte.util.CTEUtil;
import com.opensymphony.xwork2.ModelDriven;

public class TestGroupAction extends AbstractCrudSearchAction 
	implements ModelDriven<PersistentBean>, AuditableBeanAction, ActivatableBeanAction, LastActivityDate, SessionAware, StatusAction
{
	private static final long	serialVersionUID	= 6914596592041248301L;
	
	private static final Logger           LOGGER = LoggerFactory.getLogger(TestGroupAction.class);
	private static final SimpleDateFormat DATE_FORMAT = new SimpleDateFormat("dd-MMM-yyyy HH:mm");

	private String lastActivityDate;
	
	private List<TestGroup>	    dispList = new ArrayList<TestGroup>();
	private List<String>		testGroupName;
	private Map<String, Object> session;
	private BigDecimal          seqHeaderId = null;
	
	@Override
    public void activateBean(PersistentBean bean)
    {
		TestGroup testGroup = (TestGroup) bean;
		testGroup.setActiveFlag("Y");
    }

	@Override
    public void deactivateBean(PersistentBean bean)
    {
		TestGroup testGroup = (TestGroup) bean;
		testGroup.setActiveFlag("N");
    }

	@Override
    public boolean isActive(PersistentBean bean)
    {
	    return ((TestGroup) bean).getActiveFlag().equals("Y");
    }

	@Override
    public String addSearchCriteria() throws ConfigurationException
    {
		CTESearchCriteria criterion = new CTESearchCriteria(this.getAttribute(), 
				getCastedClient().getEntityAttributeName(this.getAttribute()), 
				this.getComparitor(), this.getCriteria());
		Collection<SearchCriteria> searchCriteria = getClient().getQueryCriteria();
		if (! searchCriteria.contains(criterion))
		{
			getClient().addQueryCriteria(new CTESearchCriteria(this.getAttribute(), 
				getCastedClient().getEntityAttributeName(this.getAttribute()), 
				this.getComparitor(), this.getCriteria()));
			displaySearchObjects();
		}
	    return list();
    }

	@Override
    public String deleteAllSearchCriteria() throws ConfigurationException
    {
	    getClient().deleteAllQueryCriteria();
	    return list();
    }

	@Override
    public String create() throws ConfigurationException
    {
		setStatus("");
		return super.create();
    }

	@Override
    public String edit() throws ConfigurationException
    {
		setStatus("");
	    return super.edit();
    }

	@Override
    public String list() throws ConfigurationException
    {
		getCastedClient().setUserModel((UserModel) getSession().get(SessionInterceptor.USER_MODEL));
	    return super.list();
    }

	@Override
    public String getLastActivityDate()
    {
	    return lastActivityDate;
    }

	@Override
    public void setLastActivityDate(String lastActivityDate)
    {
		this.lastActivityDate = lastActivityDate;
    }

	@Override
    public PersistentBean getPersistentBean()
    {
	    // TODO Auto-generated method stub
	    return super.getPersistentBean();
    }

	@Override
    public List<PersistentBean> getUpdatedBeans()
    {
		List<PersistentBean> updatedBeanList = new ArrayList<PersistentBean>();
		updatedBeanList.add(getPersistentBean());
		System.out.println("getUpdatedBeans() returns " + updatedBeanList);
	    return updatedBeanList;
    }

	@Override
    public String save() throws ConfigurationException
    {
		TestGroup testGroup = (TestGroup) getPersistentBean();
		String result;
		try
		{
			testGroup.verifyUpdate();
			result = super.save();
			setStatus("Test group " + testGroup.getTestgroupName() + " saved.");
		}
		catch (ConfigurationException e)
		{
			setStatus("Error saving test group " + testGroup.getTestgroupName() + ": " + e.getMessage());
			LOGGER.error("Error saving test group " + testGroup.getTestgroupName() + ": " + e.getMessage());
			result = INPUT;
		}
		catch (PersistenceException e)
		{
			setStatus("Error saving test group " + testGroup.getTestgroupName() + ": " + e.getMessage());
			LOGGER.error("Error saving test group " + testGroup.getTestgroupName() + ": " + e.getMessage());
			result = INPUT;
		}
	    return result;
    }

	public String toggleActivation()
	{
		// All processing is done in ActivateBeanInterceptor.
	    return SUCCESS;
	}

	private TestGroupClient getCastedClient() throws ConfigurationException
	{
		return (TestGroupClient) getClient();
	}
	
	/*
	 * Populates the list of beans to display in the list grid.
	 * To implement, provide a method that returns a collection of persistent
	 * beans.
	 */
	@Override
	protected Collection<PersistentBean> getBeanListImpl() throws ConfigurationException
	{
		return ((TestGroupClient) this.getClient()).getTestGroup();
	}

	/*
	 * Required by Struts2 Model Driven interface.
	 * Define the model for the persistent Bean (form object) if using the
	 * Struts2 model driven interface.
	 */

	@Override
	protected Class<?> getClientClass()
	{
		return TestGroupClient.class;
	}

	public TestGroup getModel()
	{
		return (TestGroup) this.getPersistentBean();
	}
	
	public String getStatus()
	{
		String status = null;
		try
        {
	        status = getCastedClient().getStatus();
        }
        catch (ConfigurationException e)
        {
        	LOGGER.error("Cannot get status from client.", e);
        }
        return status;
	}
	
	public void setStatus(String status)
	{
		try
        {
	        getCastedClient().setStatus(status);
        }
        catch (ConfigurationException e)
        {
        	LOGGER.error("Cannot set status.", e);
        }
	}
	
	public String getFormattedCreationDate()
	{
		TestGroup testGroup = (TestGroup) getPersistentBean();
		return DATE_FORMAT.format(testGroup.getCreatedDate());
	}
	
	public String getFormattedLastModifiedDate()
	{
		TestGroup testGroup = (TestGroup) getPersistentBean();
		return DATE_FORMAT.format(testGroup.getUpdatedDate());
	}
	
	public void setFormattedCreationDate(String dateString)
	{
		TestGroup testGroup = (TestGroup) getPersistentBean();
		try
        {
			if (CTEUtil.isNotNullNotEmpty(dateString))
			{
				testGroup.setCreatedDate(DATE_FORMAT.parse(dateString));
			}
        }
		catch (ParseException e)
        {
	        LOGGER.error("Error parsing date string \"" + dateString + "\".", e);
        }
	}
	
	public void setFormattedLastModifiedDate(String dateString)
	{
		TestGroup testGroup = (TestGroup) getPersistentBean();
		try
        {
			if (CTEUtil.isNotNullNotEmpty(dateString))
			{
				testGroup.setUpdatedDate(DATE_FORMAT.parse(dateString));
			}
        }
		catch (ParseException e)
        {
	        LOGGER.error("Error parsing date string \"" + dateString + "\".", e);
        }
	}

	/*
	 * Required by Struts2 Model Driven interface if you need to populate
	 * custom dropdowns or any data population in the jsp
	 */
	@Override
	public void prepareFormObjects() throws ConfigurationException
	{
	}	
	
	
	public String search() throws ConfigurationException
	{	
		return super.search();	
	}
	
	
	

	/*
	 * Defines the <ClientManager> sub class the action class
	 * needs for interaction with the client.
	 */

	public List<TestGroup> getDispList()
	{
		return dispList;
	}

	public void setDispList(Collection<TestGroup> dispList)
	{
		this.dispList = (List<TestGroup>) dispList;
	}
	
	public BigDecimal getSeqHeaderId()
    {
    	return seqHeaderId;
    }

	public List<String> getTestGroupName()
    {
    	return testGroupName;
    }

	public void setTestGroupName(Collection<String> collection)
    {
    	this.testGroupName = (List<String>) collection;
    }
	
//	@Override
//	public void validate()
//	{
//	}

	public Map<String, Object> getSession()
    {
    	return session;
    }

	public void setSession(Map<String, Object> session)
    {
    	this.session = session;
    }

}

TestGroupAction-validation.xml

<?xml version="1.0" encoding="UTF-8"?>
    <!DOCTYPE validators PUBLIC "-//OpenSymphony Group//XWork Validator 1.0.2//EN" 
    "http://www.opensymphony.com/xwork/xwork-validator-1.0.2.dtd">

<validators>
    <field name="attribute">
        <field-validator type="requiredstring">
            <message>You must enter a value for Attribute</message>
        </field-validator>
    </field>
        <field name="comparitor">
        <field-validator type="requiredstring">
            <message>You must enter a value for Comparitor</message>
        </field-validator>
    </field>
        <field name="criteria">
        <field-validator type="requiredstring">
            <message>You must enter a value for Criteria</message>
        </field-validator>
    </field>
    
</validators>

[Jesus Mireles]

I've never really needed to use my own validator.xml ... but your not using anything that couldnt be used with an annotation tag on the setters:

@RequiredStringValidator(type = ValidatorType.FIELD, message = "You must enter a value for Criteria")