Not able to convert large sized byte array to String

[Kinnaree Patel]

Hi all,

I have written a code to upload file to server. When the files are small (around 3MB), it works great. But when i try to upload files of greater size, around 5MB, I start getting OutOfMemory errors (on local machine) and the file does not get upload when I upload EAR to UAT environment. On UAT environment, I do not get any significant errors in log and a open dialog pop up appears while file is being uploaded, ultimately doing nothing. Below is my code that seems to create problems:

       DataInputStream in = new DataInputStream(request.getInputStream());
			int formDataLength = request.getContentLength();
			dataBytes = new byte[formDataLength];
			int byteRead = 0;
			int totalBytesRead = 0;
			System.out.println("request.getContentLength : "
					+ request.getContentLength());

			System.out.println("formDataLength : " + formDataLength);
			System.out.println("First databytes length : " + dataBytes.length);
			while (totalBytesRead < formDataLength) {
				byteRead = in.read(dataBytes, totalBytesRead, formDataLength);
				// byteRead = in.read(dataBytes);
				totalBytesRead += byteRead;
			}

			System.out.println("totalBytesRead : " + totalBytesRead);

			file = new String(dataBytes);

			saveFile = file.substring(file.indexOf("filename=\"") + 10);
			 System.out.println("saveFile : " + saveFile);

On local, when I debug to line System.out.println("saveFile : " + saveFile); it gives me out of memory error. The problem is that dataBytes is not getting converted to file at file = new String(dataBytes);

Any suggestions would be a great help at this stage. I am working on tight deadline and unfortunately none of the solutions found through googling worked!

Thanks,
Kinnaree

[Swastik Dey]

Does this help?

StringBuilder sb=new StringBuilder();
 System.out.println("formDataLength : " + formDataLength);  
             System.out.println("First databytes length : " + dataBytes.length);  
             while (totalBytesRead < formDataLength) {  
                 byteRead = in.read(dataBytes, totalBytesRead, formDataLength);  
                 // byteRead = in.read(dataBytes);  
                 //totalBytesRead += byteRead;  
                 sb.append((char)byteRead);
             }  
             
              file = new String(dataBytes);

[Kinnaree Patel]

Hi Swastik,

Not really. We are still using jdk1.4

[Swastik Dey]

May be you can switch to StringBuffer instead of StringBuilder and see if it helps.