Reiterating tags

[Bob Dunn]

I'm trying to create a new tag class to display an array list. There is an error on line lineItems = product.getProduct(); Any help would be great..

ProductsTags.java

package tags;

import javax.servlet.jsp.*;
import javax.servlet.jsp.tagext.*;
import java.util.*;
import java.io.IOException;

import business.*;

public class ProductsTags extends BodyTagSupport
{
    private ArrayList<LineItem> lineItems;
    private Iterator iterator;
    private LineItem item;
    
    public int doStartTag()
    {
        Product product = (Product) pageContext.findAttribute("product");
        lineItems = product.getProduct();
        if (lineItems.size() <= 0)
        {
            return SKIP_BODY;
        }
        else
        {
            return EVAL_BODY_BUFFERED;
        }
    }

    public void doInitBody() throws JspException
    {
        iterator = lineItems.iterator();
        if (iterator.hasNext())
        {
            item = (LineItem) iterator.next();
            this.setItemAttributes(item);
        }
    }

    private void setItemAttributes(LineItem item)
    {
        Product p = item.getProduct();
        pageContext.setAttribute(
                "productCode", p.getCode());
        pageContext.setAttribute(
                "productDescription", p.getDescription());
        pageContext.setAttribute(
                "productPrice", p.getPriceCurrencyFormat());
        pageContext.setAttribute(
                "quantity", new Integer(item.getQuantity()));
        pageContext.setAttribute(
                "total", item.getTotalCurrencyFormat());
    }

    public int doAfterBody() throws JspException
    {
        try
        {
            if (iterator.hasNext())
            {
                item = (LineItem) iterator.next();
                this.setItemAttributes(item);
                return EVAL_BODY_AGAIN;
            }
            else
            {
                JspWriter out = bodyContent.getEnclosingWriter();
                bodyContent.writeOut(out);
                return SKIP_BODY;
            }
        }
        catch(IOException ioe)
        {
            System.err.println("error in doAfterBody " + ioe.getMessage());
            return SKIP_BODY;
        }
    }

}

ProductsServlet

package cart;

import java.io.*;
import javax.servlet.*;
import javax.servlet.http.*;

import java.util.ArrayList;

import data.ProductIO;
import business.Product;

public class ProductsServlet extends HttpServlet
{
    
    protected void processRequest(HttpServletRequest request, HttpServletResponse response)
            throws ServletException, IOException
    {
        HttpSession session = request.getSession();

        ArrayList<Product> products = 
                ProductIO.getProducts(
                session.getServletContext().getRealPath("WEB-INF/products.txt")); 
        session.setAttribute("products", products);
        
        String url = "/index.jsp";
        RequestDispatcher dispatcher =
                getServletContext().getRequestDispatcher(url);
        dispatcher.forward(request, response);        
    }
    
    // <editor-fold defaultstate="collapsed" desc="HttpServlet methods. Click on the + sign on the left to edit the code.">
    /**
     * Handles the HTTP <code>GET</code> method.
     * @param request servlet request
     * @param response servlet response
     */
    protected void doGet(HttpServletRequest request, HttpServletResponse response)
            throws ServletException, IOException
    {
        processRequest(request, response);
    }
    
    /**
     * Handles the HTTP <code>POST</code> method.
     * @param request servlet request
     * @param response servlet response
     */
    protected void doPost(HttpServletRequest request, HttpServletResponse response)
            throws ServletException, IOException
    {
        processRequest(request, response);
    }
    
    /**
     * Returns a short description of the servlet.
     */
    public String getServletInfo()
    {
        return "Short description";
    }
    // </editor-fold>
}

products.java

package business;

import java.io.Serializable;
import java.text.NumberFormat;

public class Product implements Serializable
{
    private String code;
    private String description;
    private double price;
    
    public Product()
    {
        code = "";
        description = "";
        price = 0;
    }
    
    public void setCode(String code)
    {
        this.code = code;
    }
    
    public String getCode()
    { 
        return code; 
    }
    
    public void setDescription(String description)
    {
        this.description = description;
    }

    public String getDescription()
    { 
        return description; 
    }
    
    public void setPrice(double price)
    {
        this.price = price;
    }
    
    public double getPrice()
    { 
        return price; 
    }
    
    public String getPriceCurrencyFormat()
    {
        NumberFormat currency = NumberFormat.getCurrencyInstance();
        return currency.format(price);
    }    
}

[fred rosenberger]

I'm guessing here, since you didn't tell us what the error was (that would have been a big help, since the error message tells you exactly what is wrong).

Where is the getProduct() method defined?

[Bob Dunn]

I think that's the problem. The getProduct isn't defined. I'm not sure what this should be but it should be referencing the arraylist in the ProductsServlet.

[fred rosenberger]

you're not sure what WHAT should be?

getProduct() is a method. since you are assigning what it returns to a LineItem, the method has to return one of those.

[Bob Dunn]

In the products servlet, it loads an array list of products objects. In the tag, i want to read this array list. the getProduct method isn't defined anywhere so it's not correct. I had it as getProducts but it didn't work either. I thought it would correspond to the ArrayList line in the products servlet which has getProducts. i have a disconnect somewhere. Thanks in advance for any help.

[fred rosenberger]

You can't call a method that doesn't exist.

You have created a class called "Products" - therefore, you control what methods exist and what don't for the Products class.

So, I see two options:

1) don't call the getProducts() method, since it doesn't exist.
2) Write a method in your Products class call "getProducts" (or getProduct, if that's what you need) and make it do what you want.

I am not a servlet guy, so I can't address that part.

What exactly do you expect the method getProducts to do? What should it return?

[Bob Dunn]

It should return the objects in the arraylist that is stored as an attribute of the session object in the ProductsServlet class.

[fred rosenberger]

Bob Dunn wrote:It should return the objects in the arraylist that is stored as an attribute of the session object in the ProductsServlet class.

so, write it and make it do that.

[Bob Dunn]

Well... if i knew how to do that I wouldn't be asking and obviously you don't know how to either or else your answer would have been more appropriate. Thanks for wasting my time and providing no assistance.