Quit audio before application exits.

[Braden Steffaniak]

In my application, I have audio running thrughout the whole time the application is open.

However, whenever I exit the application, my computer makes a noise that makes me think that something went wrong. I dont really know how to explain it other than it is just one tone and it does not sound like the audio that I had playing.

Is there a way to make this sound not occur? Should I stop the audio from playing before the application exits?

[Rob Spoor]

How are you playing the audio?

[Braden Steffaniak]

package com.eightbitadventure.entities;

import com.eightbitadventure.main.Main;
import java.io.File;
import java.io.IOException;
import javax.sound.sampled.AudioFormat;
import javax.sound.sampled.AudioInputStream;
import javax.sound.sampled.AudioSystem;
import javax.sound.sampled.DataLine;
import javax.sound.sampled.LineUnavailableException;
import javax.sound.sampled.SourceDataLine;
import javax.sound.sampled.UnsupportedAudioFileException;

/*********************************************************************
 * This Class is used for locating and playing sounds.
 * @author BradenSteffaniak
 *********************************************************************/
public class Sound
{
	String soundFilePath;
	Thread thread;
	SourceDataLine line;
	File soundFile;
	AudioInputStream audioInputStream = null;
	public boolean playing;
	
	private static final int	EXTERNAL_BUFFER_SIZE = 128000;
	
	public Sound(String soundFilePath)
	{
		this.soundFilePath = soundFilePath;
		
		soundFile = new File(soundFilePath);
		
		setUpAudio();
	}
	
	public void play(final int playTimes)
	{
		playing = true;
		
		thread = new Thread()
				{
					public void run()
					{
						for (int i = 0; i < playTimes; i ++)
						{
							byte tempBuffer[] = new byte[10000];

							int cnt = 0;

							try
							{
								line.start();

								while((cnt = audioInputStream.read(tempBuffer,0,tempBuffer.length)) != -1 && playing)
								{
										if(cnt > 0)
										{
											line.write(tempBuffer, 0, cnt);
										}
								}

								line.drain();
								line.flush();
								line.close();
								setUpAudio();
							}
							catch (IOException ex)
							{
								Main.stateError(14, this.getClass().getName(), ex, "Could not locate the sound file '" + soundFilePath + "'.");
							}
						}
					}
				};
		
		thread.start();
	}
	
	public void play(boolean loop)
	{
		if (loop)
		{
			playing = true;

			thread = new Thread()
					{
						public void run()
						{
							while (playing)
							{
								byte tempBuffer[] = new byte[10000];

								int cnt = 0;
								
								try
								{
									line.start();
									
									while((cnt = audioInputStream.read(tempBuffer,0,tempBuffer.length)) != -1 && playing)
									{
											if(cnt > 0)
											{
												line.write(tempBuffer, 0, cnt);
											}
									}
									
									line.drain();
									line.flush();
									line.close();
									setUpAudio();
								}
								catch (IOException ex)
								{
									Main.stateError(14, this.getClass().getName(), ex, "Could not locate the sound file '" + soundFilePath + "'.");
								}
							}
						}
					};

			thread.start();
		}
	}
	
	public void play()
	{
		playing = true;
		
		thread = new Thread()
				{
					public void run()
					{
						byte tempBuffer[] = new byte[10000];

						int cnt = 0;

						try
						{
							line.start();

							while((cnt = audioInputStream.read(tempBuffer,0,tempBuffer.length)) != -1 && playing)
							{
									if(cnt > 0)
									{
										line.write(tempBuffer, 0, cnt);
									}
							}

							line.drain();
							line.flush();
							line.close();
							setUpAudio();
						}
						catch (IOException ex)
						{
							Main.stateError(14, this.getClass().getName(), ex, "Could not locate the sound file '" + soundFilePath + "'.");
						}
					}
				};
		
		thread.start();
	}
	
	public void stop()
	{
		
	}
	
	private void setUpAudio()
	{
		try
		{
			audioInputStream = AudioSystem.getAudioInputStream(soundFile);
			AudioFormat	audioFormat = audioInputStream.getFormat();
			line = null;
			DataLine.Info	info = new DataLine.Info(SourceDataLine.class,
													 audioFormat);
			try
			{
				line = (SourceDataLine) AudioSystem.getLine(info);

				/*
				  The line is there, but it is not yet ready to
				  receive audio data. We have to open the line.
				*/
				line.open(audioFormat);
			}
			catch (LineUnavailableException e)
			{
				e.printStackTrace();
				System.exit(1);
			}
			catch (Exception e)
			{
				e.printStackTrace();
				System.exit(1);
			}
		}
		catch (IOException ex)
		{
			Main.stateError(14, this.getClass().getName(), ex, "Could not locate the sound file '" + soundFilePath + "'.");
		}
		catch (UnsupportedAudioFileException ex)
		{
			Main.stateError(15, this.getClass().getName(), ex, "The sound file '" + soundFilePath + "' is not supported.");
		}
	}
}

[Rob Spoor]

I don't know how your application is exited, but unless you call System.exit, the sound playing threads will continue until they end. I'd definitely stop them. Also, you should make the playing variable volatile, as it's clearly meant to be shared among multiple threads.

I don't see any GUI related code here, so I'll move this thread to Java in General.

[Braden Steffaniak]

I use system.exit(0) to exit the program when the x button is pressed. (and I changed playing to volatile) But it still makes the sound.

[Braden Steffaniak]

I have now added this line to my code, and it runs right before the program exits.

However, it makes a very... very loud annoying sound that scares the crap out of me. And even after the program has exited, it will repeat the sound a few times after when you try to play any audio.

Heres the code:

public void stop()
	{
		playing = false;
		thread = null;
		line.drain();
		line.flush();
		line.close();
//		line = null;
//		soundFilePath = null;
//		soundFile = null;
//		audioInputStream = null;
	}

It is in the Sound.class as seen in the code in my second post.

[Braden Steffaniak]

Now I have edited that code to this:

public void stop()
	{
		playing = false;
		thread = null;
		try
		{
			line.close();
			audioInputStream.close();
		}
		catch (IOException ex)
		{

		}
	}

It does not have a sharp sound anymore, but it still makes the noise that I started out with. Just for a shorter time period.

How could I stop the noise from occurring completely?

[Carey Brown]

How about:

                        for (int i = 0; i < playTimes && playing ; i ++)

[Braden Steffaniak]

That loop just controls whether to loop or not. The nested loops are the ones that play the audio.

[Carey Brown]

Yes, but each time through the loop you call line.start() and line.close().