Spring Aop

[pankaj semwal]

Hi,
I want when a accesUser method call the afterLogged method should be called.

For this i did like this.

application.xml

<bean id="secureAction"  class="com.Security.SecureAction"  />
     <bean id="secureAdvice"  class="com.Security.secureAdvice"/>
    <aop:config>
    <aop:pointcut   id="securePoint"  expression="execution(* com.Security.Secure.authencate(..))"  />
    <aop:pointcut   id="secureAccess"  expression="execution(* com.Security.Secure.accesUser(..))"  />
             <aop:aspect id="mainConcern" ref="secureAdvice">
              <aop:before method="beforeLogin"  pointcut-ref="securePoint"/>
              <aop:after    method="afterLogged"   pointcut-ref="secureAccess"/>
        </aop:aspect>
    </aop:config>

And calling like this

ApplicationContext appContext = new ClassPathXmlApplicationContext(
			new String[] { "applicationContext.xml" });
	
	System.out.println("*********************************");

	Secure sbean = (Secure)appContext.getBean("secureAction");  
    sbean.authencate();
    sbean.accesUser("pankaj", "semwal");
	
	}

And Action class is

public class SecureAction implements Secure {

	public void authencate() {

		System.out.println("Login Sucessfully");
		 

	}

	public boolean accesUser(String uId, String pId) {
		String auth = null;
		Map map = new HashMap();
		List lst = null;
		boolean flag = false;
		map.put("pankaj", "semwal");
		map.put("shyam", "sundar");
		map.put("himanshu", "hira");
		map.put("pramod", "mehta");

		if (uId != null && pId != null) {
			auth = (String) map.get(uId);
			if (auth == null) {
				flag = false;
			} else {
				flag = true;
			}
		}
		System.out.println(flag);
		return flag;
		

	}

}

Where secure method is a interface and have two method authencate and accesUser.And secureAdvice is a advice.

The above scenerio works fine but when i call accessUser in side authencate its not works.
Afte that i called like this

ApplicationContext appContext = new ClassPathXmlApplicationContext(
			new String[] { "applicationContext.xml" });
	
	System.out.println("*********************************");

	Secure sbean = (Secure)appContext.getBean("secureAction");  
    sbean.authencate();

Please tell me how to solve this.

Thank & Regards

[Rishi Shehrawat]

This is a known limitation of Spring AOP while using proxies. If you are calling method in same class it will not be intercepted. i:e you have class Foo with public methods a() & b(). If these methods are called from another class, the call will be intercepted, however if you call method b() from a(), Spring AOP will not intercept it.
A possible workaround is that you can try using CGLIB for weaving.

[Mark Spritzler]

For me, this type of scenario shows me a "Code smell". It says to me to look at my design and refactor it.

While you can add the CGLIB jar file to get proxies created by subclassing your class, it is a "workaround" for a bad design in your apis.

If you truly have one public method of a class/interface calling another public method of the same class/interface then you are making your class a client of itself. a client means a class outside of that class calling it.

So if I have this scenario, my refactor is either to move one of the methods into another class/interface, or make one of the two methods private. If the two methods hae to be public because they both are called outside of the class by other classes, then my first refactor is what should be done.

Mark