what is the problem with my java code

[naved momin]

error is

C:\Users\Admin\Documents\java source code\Niit\testdrive\enumurated class>javac Playing.java
Playing.java:11: incompatible types
found   : java.lang.String
required: Playing.Name
                this.name = name;
                            ^
Playing.java:39: cannot find symbol
symbol  : constructor Playing(Playing.Name)
location: class Playing
                Playing p = new Playing(Name.yoga);
                            ^
2 errors

C:\Users\Admin\Documents\java source code\Niit\testdrive\enumurated class>

public class Playing
{
	
	public enum Name
	{
		romance , thriller , comedy  , yoga ;
	}
	public Name name;
	public Playing(String name)
	{
		this.name = name;
	}
	
	
	public String setName()
	{
		String names = "";
		switch(name)
		{
			case romance :
			names = " romance";
			break;
			case thriller :
			names = " thriller";
			break;
		
			case comedy :
			names = " comedy";
			break;
			case yoga :
			names = " yoga";
			break;
			default:
		}
		return names;
	}
	public static void main(String[] args)
	{
		Playing p = new Playing(Name.yoga);
		System.out.print(" we have " +p.setName()+ " available in stock ");
	}	
}

[Alexander Kober]

As you can see in line 10, the constructor of class 'Playing' takes a String argument. The field Playing#name is of type Playing.Name, an enum you defined. Java will not automatically convert a String to the corresponding enum value. In line 40, you actually do pass an enum to the constructor, so i guess all you'll want to do is replace line 10 with

public Playing(Name name)

[Rob Spoor]

Also, the setNames method seems wrong. First of all, it doesn't set anything, so it should be called getName instead. Second, it can be implemented so much easier:

public String getName()
{
    return (name == null ? "" : name.name());
}

And should you ever need to convert a String into one of your enum constants, you can use Name.valueOf("thriller").

[naved momin]

Alexander Kober wrote:As you can see in line 10, the constructor of class 'Playing' takes a String argument. The field Playing#name is of type Playing.Name, an enum you defined. Java will not automatically convert a String to the corresponding enum value. In line 40, you actually do pass an enum to the constructor, so i guess all you'll want to do is replace line 10 with

public Playing(Name name)

thanks for guiding me . my doubt is clear now but i want to ask 1 question which is
when i change to this

public class Playing
{
	
	public enum Name
	{
		romance , thriller , comedy  , yoga ;
	}
	public static String name;
	public Playing(String name)
	{
		this.name = name;
	}
	 String getName()
	{
		return " name :" + name;
	}
	
	
	public String setName()
	{
		String names = "";
		switch(name)
		{
			case 1 :
			names = " romance";
			break;
			case 2 :
			names = " thriller";
			break;
		
			case 3 :
			names = " comedy";
			break;
			case 4 :
			names = " yoga";
			break;
			default:
		}
		return names;
	}
	public static void main(String[] args)
	{
		Playing p = new Playing("yoga");
		System.out.print(" we have " +p.setName()+ " 

book available in stock ");
		System.out.print(p.getName()); 
	}	
}

so after changing this i thought it should not produce an error but it did , i m passing an String value which is accepted by constructor Playing(String name) then it should set the name to the value of constructor then i m calling the

method setName()

which should set the appropriate name according to the value of name variable into names variable
the error is

C:\Users\Admin\Documents\java source code\Niit\testdrive\enumurated class>javac Playing.java
Playing.java:22: incompatible types
found   : java.lang.String
required: int
                switch(name)
                       ^
1 error

C:\Users\Admin\Documents\java source code\Niit\testdrive\enumurated class>

[Rob Spoor]

Well, you can't use Strings inside switch statements. (Well, since Java 7 you can, but you'd need to compare them to String values.)

[naved momin]

Rob Spoor wrote:Well, you can't use Strings inside switch statements. (Well, since Java 7 you can, but you'd need to compare them to String values.)

thanks

[Rob Spoor]

You're welcome.