Simple Chat Problem

[Moe Kennedy]

Hello
I'm trying to make a small chat programm. It should not be perfect. ;-)

Here is the code I have already, unfortunately it is not working.
This is the Server:

package server;

import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.io.PrintWriter;
import java.net.ServerSocket;
import java.net.Socket;
import java.util.ArrayList;
import java.util.Iterator;

public class SimpleChatServer {

	ArrayList clientOutStream;
	
	public class ClientHandler implements Runnable{
		BufferedReader reader;
		Socket sock;
		
		public ClientHandler(Socket clientSocket){
			try {
				sock = clientSocket;
				InputStreamReader isReader = new InputStreamReader(sock.getInputStream());
				reader = new BufferedReader(isReader);
				
			}catch (Exception e) {e.printStackTrace();}
		}// close Constructor
		
		public void run() {
			String nachricht;
			try {
				while ((nachricht = reader.readLine()) != null){
					System.out.println("gelesen; " + nachricht);
					broadcast(nachricht);
				}
			} catch (Exception e) {
				e.printStackTrace();
			}
		}

		public static void main(String[] args) {
			new SimpleChatServer().los();
		}
		
		private void broadcast(String nachricht) {
			
			Iterator it = clientOutStream.iterator();
			while (it.hasNext()) {
				try {
					PrintWriter writer = (PrintWriter) it.next();
					writer.println(nachricht);
					
				} catch (Exception e) {
					e.printStackTrace();
				}
			}
		}
	}

	public void los() {
		clientOutStream = new ArrayList();
		
		try {
			ServerSocket serverSock = new ServerSocket(54666);
			
			while (true){
				Socket clientSocket = serverSock.accept();
				PrintWriter writer = new PrintWriter(clientSocket.getOutputStream());
				clientOutStream.add(writer);
				Thread t = new Thread(new ClientHandler(clientSocket));
				t.start();
				System.out.println("Neue Verbindung steht!");
			}
		} catch (Exception e) {
			e.printStackTrace();
		}
	}
}

This is the client:

package client;

import java.awt.BorderLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.io.PrintWriter;
import java.net.Socket;

import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.JScrollPane;
import javax.swing.JTextArea;
import javax.swing.JTextField;
import javax.swing.ScrollPaneConstants;

public class SimpleChatClient {

	JTextArea eingehend;
	JTextField ausgehend;
	BufferedReader reader;
	PrintWriter writer;
	Socket sock;
	
	public static void main(String[] args) {
		SimpleChatClient client = new SimpleChatClient();
		client.los();
	}
	
	public void los() {
		
		JFrame frame = new JFrame("Simple Chat Client");
		JPanel hauptPanel = new JPanel();
		eingehend = new JTextArea(15, 20);
		eingehend.setLineWrap(true);
		eingehend.setEditable(false);
		JScrollPane fScroller = new JScrollPane(eingehend);
		fScroller.setVerticalScrollBarPolicy(ScrollPaneConstants.VERTICAL_SCROLLBAR_ALWAYS);
		fScroller.setHorizontalScrollBarPolicy(ScrollPaneConstants.HORIZONTAL_SCROLLBAR_NEVER);
		ausgehend = new JTextField(20);
		JButton senden = new JButton("Senden");
		senden.addActionListener(new SendenButtonListener());
		hauptPanel.add(fScroller);
		hauptPanel.add(ausgehend);
		hauptPanel.add(senden);
		netzwerkEinrichten();
		
		Thread readerThread = new Thread(new EingehendReader());
		readerThread.start();
		
		frame.getContentPane().add(BorderLayout.CENTER, hauptPanel);
		frame.setSize(400, 500);
		frame.setVisible(true);
	}
	
	private void netzwerkEinrichten() {
		try {
			sock = new Socket("127.0.0.1", 54666);
			InputStreamReader streamReader = new InputStreamReader(sock.getInputStream());
			reader = new BufferedReader(streamReader);
			writer = new PrintWriter(sock.getOutputStream());
			System.out.println("Netzwerk wurde eingerichtet!");
		} catch (Exception e) {
			e.printStackTrace();
		}
	}
	
	
	public class SendenButtonListener implements ActionListener{
		@Override
		public void actionPerformed(ActionEvent e) {
			try {
				writer.println(ausgehend.getText());
				writer.flush();
				
			} catch (Exception e2) {
				e2.printStackTrace();
			}		
			ausgehend.setText("");
			ausgehend.requestFocus();
		}
	}
	
	public class EingehendReader implements Runnable{

		@Override
		public void run() {
			String nachricht;
			try{
				while ((nachricht = reader.readLine()) != null) {
					System.out.println("gelesen: " + nachricht);
					eingehend.append(nachricht + "\n");
				}
			}catch (Exception e) {
				e.printStackTrace();
			}
		}
		
	}
}

Would be nice if someone coud help me.

[Paul Clapham]

Let's start at the beginning: how can you tell it isn't working?

[Moe Kennedy]

Hi

Paul Clapham wrote:Let's start at the beginning: how can you tell it isn't working?

When I try to run one of these files, an error appears:

Exception in thread "main" java.lang.Error: Unresolved compilation problem:
The method main cannot be declared static; static methods can only be declared in a static or top level type

at server.SimpleChatServer$ClientHandler.main(SimpleChatServer.java:40)

[fred rosenberger]

You wrote 200ish lines of code before you tried compiling?

that's your problem right there. Never write more than 2-3 lines before you compile. If you do, you are dooming yourself to failure.

[Paul Clapham]

That message says that your "public static void main" method shouldn't be inside that nested class. Move it out of there so that it's a method of SimpleChatServer.

[Moe Kennedy]

Paul Clapham wrote:That message says that your "public static void main" method shouldn't be inside that nested class. Move it out of there so that it's a method of SimpleChatServer.

Thank you :thumbup: