Forum:

Servlets

invalid servlet downloads

asit dhal

Greenhorn

Posts: 13

I like...

posted 12 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

I have an HTML page , register.html. It calls a servelet 'Register.java'

The problem is that, the servlet displays a form window for user input. When user inputs data and submits, then a new window appears which asks us to download Register.class file.

Please suggest me how to fix this ??

Here is the code..

/*
 * To change this template, choose Tools | Templates
 * and open the template in the editor.
 */
package defaultpack;

import javax.servlet.*;
import java.io.*;
import java.sql.*;

public class RegistrationServlet extends GenericServlet {
    
    private Connection con;
    private PreparedStatement ps = null;
    
    public void init() throws ServletException {
        System.out.println("In init");
        
        try {
            ServletContext ctxt = getServletContext();
            String driverClassName = ctxt.getInitParameter("driverClassName");
            Class.forName(driverClassName);
            String url = ctxt.getInitParameter("url");
            System.out.println(url);
            String dbuser = getInitParameter("dbuser");
            System.out.println(dbuser);
            String dbpass = getInitParameter("dbpass");
            System.out.println(dbpass);
            String sqlstmt = getInitParameter("sqlstmt");
            System.out.println(sqlstmt);
            con = DriverManager.getConnection(url,dbuser,dbpass);
            ps = con.prepareStatement(sqlstmt);
        }
        catch(Exception e) {
            e.printStackTrace();
            throw new ServletException("Initialization Failed, Unable to get DB Connection");
        }
    }
    
    
    public void service(ServletRequest req, ServletResponse res) 
            throws ServletException, IOException {
        
        System.out.println("In Service");
        res.setContentType("test/html");
        PrintWriter out = res.getWriter();
        
        out.println("<html><head>");
        out.println("<title>Tata Consultancy Services</title>");
        out.println("</head><body><h1>Tata Consultancy Services</h1>");
        
        out.println("<div>");
        out.println("<table border='1' width='100%' height='100%'>");
        out.println("<tr>");
        out.println("<td width='15%' valign='top' align='center'>");
        out.println("<br/><a href='login.html'>Login</a><br/>");
        out.println("<br/><a href='register.html'>Register</a><br/>");
        out.println("</td>");
        out.println("<td valign='top' align='center'><br/>");
            
        
        try {
            String uname = req.getParameter("uname");
            String pass = req.getParameter("pass");
            String repass = req.getParameter("repass");
            
            if(uname==null || uname.equals("")||
                    pass==null || pass.equals("")||
                    !repass.equals(uname)) {
                out.println("<li><l>Given details are no valid. Please reenter</l></li>");
            }
        }
        catch(Exception e) {
            
        }
        
        out.println("</td>");
        out.println("</tr>");
        out.println("</table>");
        out.println("</div>");
        out.println("</body></html>");
        
    }
    
    public void destroy() {
        System.out.println("In destroy");
        try {
            con.close();
        }
        catch(Exception e) {
            e.printStackTrace();
        }
    }

}

http://kodeyard.blogspot.com/

William Brogden

Author and all-around good cowpoke

Posts: 13078

posted 12 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Two questions:
1. Under what environment are you executing this servlet?
2. Why are you extending GenericServlet, given that you appear to be writing a HTTP application?
You should be extending HttpServlet so you can use doGet, doPost, etc instead of service.

Bill

asit dhal

Greenhorn

Posts: 13

I like...

posted 12 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Its Glass Fish Opensource server(embedded in Net Beans 7).

Actually I am using this for the first time. So, whatever in the book, I am just following.

Can you suggest me what is the reason of that download comes ??

http://kodeyard.blogspot.com/

asit dhal

Greenhorn

Posts: 13

I like...

posted 12 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

finally a day long R & D in google and so many hit and trial found the actual error...a silly spelling mistake....

should be

http://kodeyard.blogspot.com/

William Brogden

Author and all-around good cowpoke

Posts: 13078

posted 12 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

asit dhal wrote:Its Glass Fish Opensource server(embedded in Net Beans 7).

Actually I am using this for the first time. So, whatever in the book, I am just following.

If the book is advising you to extend GenericServlet and override service method you have gotten a bad book.

Bill

Daniel Doboseru

Ranch Hand

Posts: 57

posted 12 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

To better understand what Bill told you, you should know that the service method which you overriden, is used to handle the requests done to the Servlets. For a Generic Servlet, is ok to override it, but better than that, you should use an HttpServlet, and instead of overriding the service method, you just simply need to override the doGet()/doPost() methods. Besides that, there are many advantages when using a HttpServlet instead of a GenericServlet in a web-environment, so you might re-analyze your problem. Good day!