Double xml read

[Matthew Tilic]

Hey,

I have an xml string and am doing a system out to see the results. The only issue use I keep getting duplicate results! why is this

public void myProcess() {
        while (node != null) {
            visit(node, 0);
            node = node.getNextSibling();
        }
    }


 private void visit(Node node, int level) {

        NodeList list = node.getChildNodes();
        for (int i = 0; i < list.getLength(); i++) {
            Element elm = (Element) node;
            System.out.println("Element tagname : " + elm.getTagName());
            System.out.println("getcharactervalue: " + getCharacterDataFromElement(elm));
            String tag = elm.getTagName();
            //Get next child node
            Node childNode = list.item(i);
            // Visit child node
            visit(childNode, level + 1);
        }
    }

Here is an example of my output:


Element tagname : client
getcharactervalue: website
..................................
Element tagname : client
getcharactervalue: website
..................................
Element tagname : request
getcharactervalue: insert
..................................
Element tagname : request
getcharactervalue: insert
..................................
Element tagname : databaseschema
getcharactervalue: barapplication
..................................
Element tagname : request
getcharactervalue: insert
..................................
Element tagname : table
getcharactervalue: ownerAddress

[Rob Spoor]

Move lines 13-15 to before the loop; they are called for the node itself, not the child nodes.
Be warned though that the cast to Element may fail; whitespace like line breaks are often seen as Text nodes, and will show up in the child node list.