How should I split up this big method? Still need help please!

[Ashley Kin]

Hi, I'm writing a code to decide which of two applicants is the better pick based on their test scores, SAT or ACT.
I have this one huge method that has the user input which test they took, their scores, and calculates a "score" base on this information.
I pasted the method below, and I'd really appreciate any help about how to split it up into maybe SAT and ACT methods? Thanks!

public static double testScore(Scanner console) 
	{
		System.out.print("do you have 1) SAT scores or 2) ACT scores?");
		int test = console.nextInt();
		if (test==1)
		{
			System.out.print("SAT math?");
			double math = console.nextDouble();
			
			System.out.print("SAT verbal?");
			double verbal = console.nextDouble();
			
			double satScore = (2 * math + verbal)/24;
			
			return (double) satScore;
		} else 
		{
			System.out.print("ACT English?");
			double English = console.nextDouble();
			
			System.out.print("ACT math?");
			double math = console.nextDouble();
			
			System.out.print("ACT reading?");
			double reading = console.nextDouble();
			
			System.out.print("ACT science?");
			double science = console.nextDouble();
			
			double actScore = (2 * reading + English + math + science)/1.8;
			
			return (double) actScore;
		}
	}

[Rajkamal Pillai]

Hello,

I would split the code into:

testScore()
inputSATScore()
inputACTScore()
calculateScore()

And call the appropriate methods from testScore() method.

Cheers,
Raj.

[Ashley Kin]

Okay so I rewrote my code like this, but I'm having trouble returning one final score back to the main method. Thanks for any help!

public static double testScore(Scanner console) 
	{
		System.out.print("do you have 1) SAT scores or 2) ACT scores?");
		int test = console.nextInt();
		double score = 0
		if (test==1)
		{
			inputSATScore(console);
		}
		else{
			inputACTScore(console);
		}
		return score; 
	}
	
	public static double inputSATScore(Scanner console)
	{
		System.out.print("SAT math?");
		double math = console.nextDouble();
		
		System.out.print("SAT verbal?");
		double verbal = console.nextDouble();
			
		double score = (2 * verbal + math)/24;
			
		return (double) score;
	}
	
	public static double inputACTScore(Scanner console)
	{
		System.out.print("ACT English?");
		double English = console.nextDouble();
			
		System.out.print("ACT math?");
		double math = console.nextDouble();
			
		System.out.print("ACT reading?");
		double reading = console.nextDouble();
			
		System.out.print("ACT science?");
		double science = console.nextDouble();
		
		double score = (2 * reading + English + math + science)/1.8;
		
		return (double) score;
	}

[Maneesh Godbole]

In future, while posting code, please UseCodeTags. I have added them for you this time. As you can see, it makes the code much more easier to read and understand.

Your methods return the value, but you don't catch it. Change to

score=inputSATScore(console);  

When this call returns, the value returned by inputSATScore(console) will be assigned to the score variable.

[Campbell Ritchie]

And why have you got all your methods static?

[Harsha Smith]

I don't see exceptions being handled.

[Campbell Ritchie]

What Exceptions? If you use a Scanner, why bother with Exception handling?

[Harsha Smith]

System.out.print("do you have 1) SAT scores or 2) ACT scores?");  
        int test = console.nextInt();  

at the prompt, if the user innocently enters a string or something that's not int. The program will throw InputMismatchException

[Ove Lindström]

Harsha Smith wrote:

System.out.print("do you have 1) SAT scores or 2) ACT scores?");  
        int test = console.nextInt();  

at the prompt, if the user innocently enters a string or something that's not int. The program will throw InputMismatchException

Premature optimization it the root to all evil.

Start with assuming that the user is a friendly one and does what is supposed... First we take Manhattan, then we take Exception.

[Ashley Kin]

Your methods return the value, but you don't catch it. Change to

score=inputSATScore(console);  

When this call returns, the value returned by inputSATScore(console) will be assigned to the score variable.

How would I set the value score = inputACTScore then? And thanks for the help!

[Joanne Neal]

Ashley Kin wrote:Your methods return the value, but you don't catch it. Change to

score=inputSATScore(console);  

When this call returns, the value returned by inputSATScore(console) will be assigned to the score variable.

How would I set the value score = inputACTScore then? And thanks for the help!
Answered here