Getting rid of redundancy?

[Ashley Kin]

I'm trying to get rid of redundancy in my program, I know I can take out the System.out.println("What is the y coordinate?) but not sure what else to combine.
Any help is appreciated, thanks!
I posted this in the Beginners forum, but no one was answering, so I thought I'd try it out here!

import java.util.*;
public class Coordinates {
    public static void main(String[] args) {
        Scanner console = new Scanner(System.in);
        double result = getCoordinates(console);
        System.out.println(result);
    }
    
    public static double getCoordinates(Scanner console) {
        System.out.print("What is the x coordinate? ");
        double x = console.nextDouble();
        int negatives;
        if (x < 0.0) {
            System.out.print("What is the y coordinate? ");
            double y = console.nextDouble();
            if (y < 0.0) {
                negatives = 2;
                System.out.println("negatives = " + negatives);
                return x + y + negatives;
            }  else {
                negatives = 1;
                System.out.println("negatives = " + negatives);
                return x + y + negatives;
            }
        } else {
            System.out.print("What is the y coordinate? ");
            double y = console.nextDouble();
            if (y < 0.0) {
                negatives = 1;
                System.out.println("negatives = " + negatives);
                return x + y + negatives;
            }  else {
                negatives = 0;
                System.out.println("negatives = " + negatives);
                return x + y + negatives;
            }
        }
    }
}

[Ralph Cook]

To get rid of redundancy, look for the things that are redundant and fold them into single structures.

Your code repeats several things: for instance, you prompt for a coordinate, then get a coordinate from the console in three places. You can have a method that takes a parameter so that it can name the coordinate (x or y) that is to be gotten, prompts for it, gets the input, and returns the input value.

One of your repeats -- getting y from the console in one place if x is negative and another if it is not -- is entirely there because you prompt for the input separately based on the value of x. But you don't need to do that; you are going to prompt for y regardless of x's value, so you can prompt for and get x, prompt for and get y (in one place), and then print out and return the appropriate values after you have gotten the input.

You always return "x + y + negatives" -- so your testing code can test x and y to figure out what the value of "negatives" is to be, and then just have the return and the calculation done once.

import java.util.*;
public class Coordinates {
    public static void main(String[] args) {
        Scanner console = new Scanner(System.in);
        double result = getCoordinates(console);
        System.out.println(result);
    }
    
    public static double getOneCoordinate(Scanner console, String name)
    { System.out.print("What is the " + name + " coordinate? ");
       double result = console.nextDouble();
       return result;
    }

    public static double getCoordinates(Scanner console) {
        double x = getOneCoordinate(console, "x");
        double y = getOneCoordinate(console, "y");
        int negatives;
        if (x < 0.0) {
            if (y < 0.0) {
                negatives = 2;
            }  else {
                negatives = 1;
            }
        } else {
            if (y < 0.0) {
                negatives = 1;
            }  else {
                negatives = 0;
            }
        }
        System.out.println("negatives = " + negatives);
        return x + y + negatives;
    }
}

There are one or two other things you can do to the code, but this removes redundancies.

rc

[Bear Bibeault]

Please do not post the same question more than once.