java.lang.StringIndexOutOfBoundsException: String index out of range: -2

[Farakh khan]

Hello,

else if(option==4){
				isCat=true;
				subCat+= catd.ViewSpecificCategory(column);				
			}

                  if(isCat==true){			
			displaySubCategories = cvm.displaySubCategories(subCat,label);
			}			
			else{
			displaySubCategories = cvm.displaySubCategories(cvm.removeLastComma(subCat),label);
			}

This is my remove comma method

       public String removeLastComma(String str){		
		String result=str.substring(0, str.length() - 2);//there is white space after (,)
	return result;	
	}

Line 6 of the code is throwing this error

Thanks & best regards

[Sankar Mitra]

It is possible only when the String str does not contain any character.Since it is empty its length is 0 and you are trying to go to its -2 position which is out of bounds.

[Farakh khan]

Thanks for your reply.

How can I fix it?

[Claudiu Chelemen]

Try checking the string's length before calling substring.
If it is long enough, call the substring, otherwise leave it as it is.

Claudiu

[Farakh khan]

Thanks from the bottom of my heart. Now its working fine

Best regards

[Harsha Smith]

 public static String removeLastComma(String str){         
	        str = str.trim();
	        if(str.endsWith(",")){
	        	str = str.substring(0,str.length()-1);
	        }
	    return str;    
	    } 

[Campbell Ritchie]

Never use ==true or ==false. It should be

... if (isCat) ...

[Farakh khan]

thanks for the tip