Can a method that has a parameter call another method that has a paramter?

[Ashley Kin]

I'm trying to do this, but I keep getting errors such as "illegal start of expression" or ") expected"
This code is supposed to run through a game the number of times that a user inputs.
I have a method for what a user enters as their "weapon" (i.e rock, paper, scissors) and returns the string weapon and another method for what the computer randomly chooses, which returns cWeapon.
Then I have another method to print who won based on these two weapons.
Should I be approaching this a different way other than methods with parameters?

	public static int howManyGames(Scanner console)
	{
		System.out.print("Best out of how many games (must be odd)? ");
		int numberOfGames = console.nextInt();
		return numberOfGames;
	}
	
	public static void games(int numberOfGames)
	{
		for (int i = 1; i <= numberOfGames; i++)
		{
			System.out.println("Game " + i + ":");
			Scanner console = new Scanner(System.in);
			userWeapon(console);
			singleMatch(console);
			whoWon(String weapon, String cWeapon);
		}
	}	
	
	public static String userWeapon(Scanner console)
	{
		System.out.print("Choose your weapon? ");
		String weapon = console.next();
		return weapon;
	}
	
	public static String singleMatch(Scanner console)
	{
		//System.out.print("Choose your weapon? ");
		//String weapon = console.next();
		int computer = (int)((Math.random()*2)+1);
		String cWeapon;
		if (computer == 1)
		{
			cWeapon = "r";
		} if (computer == 2)
		{
			cWeapon = "p";
		} else
		{
			cWeapon = "s";
		}
		System.out.println("I chose the weapon: " + cWeapon);
		return cWeapon;
	}

[Harsha Smith]

would you mind pasting the whole code?

[John Jai]

Yes a method that has a parameter can call another method that has a parameter. It's not dependent on that.

Best example I can think of is the main method that has a (String[] args) parameter. And you use that to call other methods (how did you call your games(int) method?)

[John Jai]

String weapon = userWeapon(console);  
String cWeapon = singleMatch(console);  
whoWon(String weapon, String cWeapon);  

You have to store the weapons returned by the userWeapon() and singleMatch() methods to send it as input to the whoWon() method. Your code misses that part... or at least the code you pasted

[Jesper de Jong]

John Jai wrote:

String weapon = userWeapon(console);  
String cWeapon = singleMatch(console);  
whoWon(weapon, cWeapon);  

You don't have to specify the type when you call the method; leave of the "String".

[Greg Brannon]

The compiler is confused whether line 9 is a method call or a method signature. If it is a method call, then omit the parameter types.

[John Jai]

Jesper de Jong wrote:

John Jai wrote:

String weapon = userWeapon(console);  
String cWeapon = singleMatch(console);  
whoWon(weapon, cWeapon);  

You don't have to specify the type when you call the method; leave of the "String".

I thought he didn't have the variables weapon and cWeapon declared previously

[Harsha Smith]

You are creating too many scanner objects by using for loop unnecesarily . all you have to do is declare a field like this

private final static Scanner  console = new Scanner(System.in)

which can be used by all the methods in the class.

Assuming that your class has a "static" whoWon(String userWeapon, String singleMatchWeapon) method, as told by others, you have call this method just like you called userWeapon and singleMatch methods in the loops

[Campbell Ritchie]

Why have you got all those members static? It is a good idea to have the Scanner object static, But having a static games() method looks suspicious to me. Also you would do better to get the details from the Scanner, store them as some sort of variable, and pass that variable to the method. Rather than

                userWeapon(console);

try

// You can run these three lines together as one statement, but that would be difficult to read.
        String weaponName = console.next();
        int weaponPower = console.nextInt();
        userWeapon(weaponName, weaponPower);

... or something similar.

An alternative approach: Set up a utility class, like this, with a static Scanner field, like what Harsha Smith showed earlier. Rather than the multiplying method I showed, create methods like public static int nextIntFromKeyboard(...); you can see what such a method contains here. Remember that is not a complete method. If you ever use System.in or similar as a parameter to a Scanner or similar, don’t simply close the Scanner. Otherwise you close System.in and can’t reopen it