Having trouble with switch, case,break,

[Angela Li]

I'm suppose to write a class that asks for an int between one and five inclusive, then check if the int is really in the range, then use-- switch, case, break--to generate an appropriate message that corresponds with the number entered. And last return to the ask for int step.
This is what I have did so far but I am having trouble when I input an int inside the accepted range, it gives me the default.

import java.util.Scanner;
public class OnetoFive{
	
	public static void main(String[] args) {
		
		int i;
		boolean endNow = false;
		
		while(!endNow){
			i=getChoice();
			switch(i) {
			case 1:
				System.out.println("One is the loneliest number");
				endNow=true;
				break;
			case 2:
				System.out.println("Two can be as bad as one");
				endNow=true;
				break;
			case 3:
				System.out.println("Three Dog Night performed \"one\"");
				endNow=true;
				break;
			case 4:
				System.out.println("Four wasn't in the song :(");
				endNow=true;
				break;
			case 5:
				System.out.println("What did the five fingers say to...!");
				endNow=true;
				break;
			default:
				System.out.println("Invalid number please enter a number within the range of 1-5 inclusive");
				endNow=true;
				break;
			}
		}
	}
	public static char getChoice() {
		String prompt = "Type a number from one to five inclusive and press [ENTER]: ";
		System.out.print(prompt);
		Scanner keybd = new Scanner(System.in);
		return keybd.next().toCharArray()[0] ; //I know it has to do with this line but I'm not sure how to change from Char to Int
	}

}

[Timothy Oldbean]

Hi Angela I'm new here too so I'm not a lot of help yet. You can make the code a lot more readable by using the "Code" button.

I'm pretty sure someone will come along with an answer to your question soon :-)

import java.util.Scanner;
public class OnetoFive{

public static void main(String[] args) {

int i;
boolean endNow = false;

while(!endNow){
i=getChoice();
switch(i) {
case 1:
System.out.println("One is the loneliest number");
endNow=true;
break;
case 2:
System.out.println("Two can be as bad as one");
endNow=true;
break;
case 3:
System.out.println("Three Dog Night performed \"one\"");
endNow=true;
break;
case 4:
System.out.println("Four wasn't in the song :(");
endNow=true;
break;
case 5:
System.out.println("What did the five fingers say to...!");
endNow=true;
break;
default:
System.out.println("Invalid number please enter a number within the range of 1-5 inclusive");
endNow=true;
break;
}
}
}
public static char getChoice() {
String prompt = "Type a number from one to five inclusive and press [ENTER]: ";
System.out.print(prompt);
Scanner keybd = new Scanner(System.in);
return keybd.next().toCharArray()[0] ; //I know it has to do with this line but I'm not sure how to change from Char to Int
}

} 

[Angela Li]

Thanks for the code suggestion, I appreciate it.

[Aniket S. Kulkarni]

@Angela Li: Why are you complicating the code?
The code is fine but...
Just change the return type of getChoice() method to int and replace the line no. 43 with
return keybd.nextInt() ;

[Angela Li]

Thanks Aniket, that was a stupid of me.

[Aniket S. Kulkarni]

My pleasure!!!

[Campbell Ritchie]

Why have you got the same line endNow = true; in six different places? That means your loop is invalid; you can only iterate it once.

[D. Ogranos]

You can also check for char constants in the switch statement. Your getChoice() method returns a char, so simply check for that:

  char choice = getChoice();
  switch (choice) {
    case '1':
      System.out.println("One");
      break;
    case '2':
      System.out.println("Two");
      break;
    default:
      break;
  }

Note the single quotes around the numbers.