String Validation Issues

[Mark Captain]

Hello, in my program I am trying to validate if a password is correct. However I am coming up with the problem of the code saying the password is incorrect even when it is correct. it looks as it is not comparing the newly inputted password but it is using the one declared in the driver. Any ideas?

The two strings i am trying to compare are the users input password, and the saved password. The are declared in the main driver like so

String password = null;
String PASSWORD = "177";

The method is called in the driver

	in.readPassword(password);
	valid.validatePassword(password, PASSWORD, transactions, oneStampCount, tenStampCount, twentyStampCount, amountSold);

The readPassword method

public String readPassword(String password)
	{
	
		String out = "Please enter admin password:";
		          
				
		String stringChoice = JOptionPane.showInputDialog(out); 
		password = stringChoice;
		return password;
	}

and the validation method

public void validatePassword(String PASSWORD, String password, 
			int transactions, int oneStampCount, int tenStampCount, int twentyStampCount, double amountSold)
	{
		boolean valid = false;
		if (password.equals(PASSWORD))
		{
			valid = true;
		}
		
		Output out = new Output();
		if (valid)
		{
			out.printSummary(transactions, oneStampCount, tenStampCount, twentyStampCount, amountSold);
		}
		else
		{
			out.printInvalidPassword();
		}
	}

[John Jai]

Please print the two passwords you compare in the validatePassword() method before the line #5.

[Claudiu Chelemen]

Hi Mark,

First off, I see that even if your readPassword method is returning the typed password, you are not using it in the driver, here:

in.readPassword(password); 

I guess it would be better if you had:

password = in.readPassword();

Secondly, when calling the validatePassword method, you may have accidentally sent the first two parameters, password and PASSWORD in the incorrect order.

Cheers,
Claudiu

[Claudiu Chelemen]

John Jai wrote:Please print the two passwords you compare in the readPassword() method before the line #5.

I think you meant the validatePassword() method, right ?

Claudiu

[John Jai]

Yes... thanks for correcting it..

[Mark Captain]

Claudiu Chelemen wrote:Hi Mark,

First off, I see that even if your readPassword method is returning the typed password, you are not using it in the driver, here:

in.readPassword(password); 

I guess it would be better if you had:

password = in.readPassword();

Secondly, when calling the validatePassword method, you may have accidentally sent the first two parameters, password and PASSWORD in the incorrect order.

Cheers,
Claudiu

Thank you, this solved my problem!