Calculating Change

[Mark Captain]

Hi, im trying to calculate the amount of each coin given in change and to have the least amount of coins returned. I have a formula going, however, it is only calculating the amount of each coin seperatly. Say there was 9.50 in change, it is returning me change = 9 dollars, 38 quarters, 95 dimes, 190 nickels, 950 pennies. While the answer i was looking for would be 9 dollars, 2 quarters, 0 dimes, 0 nickels, 0 pennies.

It looks as if every time a method runs, the change does not transfer over. Im stuck on how to fix this

The code i have in the main driver is

change = machine.getChange(payment, amountOwed, change);
					dollars = machine.calculateDollars(dollars, change);
					quarters = machine.calculateQuarters(quarters, change);
					dimes = machine.calculateDimes(dimes, change);
					nickels = machine.calculateNickels(nickels, change);
					pennies = machine.calculatePennies(pennies, change);
					out.printChange(dollars, quarters, dimes, nickels, pennies);

and the methods from the Machine class

public double getChange(int payment, double amountOwed, double change)
	{
		change = payment - amountOwed;
		change = change * 100;
		return change;
	}
	
	public int calculateDollars(int dollars, double change)
	{
		double remainder;
		if (change >= 100)
		{
			dollars = (int) (change / 100);
			remainder = dollars * 100;
			change = change - remainder;
			
		}
		return dollars;
	}
	
	public int calculateQuarters(int quarters, double change)
	{
		double remainder;
		if (change >= 25)
		{
			quarters = (int) (change / 25);
			remainder = quarters * 25;
			change = change - remainder;
			
		}
		return quarters;
	}
	
	public int calculateDimes(int dimes, double change)
	{
		double remainder;
		if (change >= 10)
		{
			dimes = (int) (change / 10);
			remainder = dimes * 10;
			change = change - remainder;
			
		}
		return dimes;
	}
	
	public int calculateNickels(int nickels, double change)
	{
		double remainder;
		if (change >= 5)
		{
			nickels = (int) (change / 5);
			remainder = nickels * 5;
			change = change - remainder;
			
		}
		return nickels;
	}
	
	public int calculatePennies(int pennies, double change)
	{
		double remainder;
		if (change >= 1)
		{
			pennies = (int) (change / 1);
			remainder = pennies * 1;
			change = change - remainder;
			
		}
		return pennies;
	}

[Pat Farrell]

What have you done so far to isolate the problem? Have you stepped through the code with the IDE's debugger? or if you don't have a good IDE, have you put in System.out.println() statements
in the code? Have you debugged one case yet?

A critical aside, not directly related to your problem, but I have to mention it: never use float or double for money. Ever. Use the integer number of pennies. Floating point numbers don't add up the way pennies do. The problems will be subtle and hard to find, but some accountant will find it and jump all over your, er, back.

[Winston Gutkowski]

Pat Farrell wrote:A critical aside, not directly related to your problem, but I have to mention it: never use float or double for money. Ever. Use the integer number of pennies.

Or alternatively BigDecimal.

Winston