calling a method in hibernate DAO through JMX export MBean

[Ankit Chandrawat]

Hi,

I am using spring 3 and hibernate for my application framework and JBoss as application server. I am calling a method inside DAO through an externalized MBean.
and get the following error:

org.hibernate.HibernateException: No Hibernate Session bound to thread, and configuration does not allow creation of non-transactional one here

Here is my DAO class. I have observed that it gives the error on Session session = sessionFactory.getCurrentSession();

@Repository("chatSessionDAO")
public class ChatSessionDAO extends MercerChatDAO {

	/** mySessionFactory */
	@Autowired
	@Qualifier("mySessionFactory")
	private LocalSessionFactoryBean mySessionFactory;

	/** chatAlertsDO */
	@Autowired
	@Qualifier("chatAlertsDO")
	private MHRContChatAlertsDO chatAlertsDO;

	/**
	 * Method to retrieve chat session objects for a particular id
	 * 
	 * @param chatSessionQO
	 * @return
	 * @throws MercerException 
	 */
	public List<?> retrieveSessionInfo(ChatSessionQO chatSessionQO) throws MercerException {
		Criteria criteria = null;
		List<?> lstReturn = null;
		try {

			long chatSessionId = chatSessionQO.getChatSessionId();
			Long chatSessionIdLong = new Long(chatSessionId);
			log.info("creating criteria for chatsession");
			SessionFactory sessionFactory = mySessionFactory.getObject();
			Session session = sessionFactory.getCurrentSession();
			criteria = session.createCriteria(MHRContChatSessionDO.class, "chatSession").add(
					Restrictions.eq("id", chatSessionIdLong));
			if (criteria != null) {
				lstReturn = processQuery(criteria);
			}

		} catch (Exception e) {
			log.error("error :::", e);
			throw new MercerException("No transaction");
		}
		return lstReturn;
	}
}

It extends MercerChatDAO, the code for which is as follows:

public class MercerChatDAO {
	/** log */
	public final static Logger log = Logger.getLogger(MercerChatDAO.class);

	//mercer exception
	/**
	 * @param e
	 * @return 
	 */
	public MercerException convertToMercerException(Exception e) {
		log.error("IN ConvertTOMercerException : ", e);
		MercerException me = new MercerException(e.getMessage());
		me.addError(e.getMessage());

		if (e instanceof MercerException) {
			me = (MercerException) e;
		}
		if (me.getErrorCode().contains("ORA-16000") && (!DatabaseFailoverService.isFlgReadOnly())) {
			DatabaseFailoverService.setFlgReadOnly(true);
		}
		return me;
	}

	// execute 
	/**
	 * @param criteria
	 * @return
	 * @throws MercerException 
	 */
	protected List processQuery(Criteria criteria) throws MercerException {
		List lstReturn = null;
		if (criteria != null) {
			try {
				// set cache to true
				criteria.setCacheable(true);
				// execute query
				lstReturn = criteria.list();
			} catch (Exception e) {
				log.error("exception" + e);
				throw convertToMercerException(e);
			}
		}
		return lstReturn;
	}

}

and here is the configuration for hibernate:

	<bean id="mySessionFactory" class="org.springframework.orm.hibernate3.LocalSessionFactoryBean">
		<!-- TODO: @NSS : can we map folder itself ? like <value>classpath:/com/mercer/content</value> -->
		<property name="mappingLocations">
			<list>
				<value>classpath*:META-INF/com/mercer/userprofile/*.hbm.xml</value>
				<value>classpath*:META-INF/com/mercer/content/*.hbm.xml</value>
				<value>classpath*:META-INF/com/mercer/product/*.hbm.xml</value>
				<value>classpath*:META-INF/com/mercer/order/*.hbm.xml</value>
				<value>classpath*:META-INF/com/mercer/lookup/*.hbm.xml</value>
				<value>classpath*:META-INF/com/mercer/ukalumni/*.hbm.xml</value>
				<!-- Innovation 03: Podcast: START -->
				<value>classpath*:META-INF/com/mercer/podcast/*.hbm.xml</value>				
				<!-- Innovation 03: Podcast: END -->
				<!-- MercerPoll: START -->
				<value>classpath*:META-INF/com/mercer/mercerpoll/*.hbm.xml</value>				
				<!-- MercerPoll: END -->
			
				<value>classpath*:META-INF/com/mercer/userlog/AttachmentDownloadContentDetailProc.hbm.xml</value>
				<value>classpath*:META-INF/com/mercer/userlog/AttachmentDownloadUserDetailProc.hbm.xml</value>
				<value>classpath*:META-INF/com/mercer/userlog/MHRUserLogStoredProc.hbm.xml</value>	
				
			</list>
		</property>
		<property name="hibernateProperties">
			<ref bean="exampleHibernateProperties" />
		</property>
		<property name="dataSource">
			<ref bean="myDataSource" />
		</property>
	</bean>



<bean id="exampleHibernateProperties" class="org.springframework.beans.factory.config.PropertiesFactoryBean">
		<property name="properties">
			<props>
				<prop key="hibernate.dialect">org.hibernate.dialect.Oracle9Dialect</prop>
				<!--prop key="hibernate.query.substitutions">true 'T', false 'F'</prop-->
				<prop key="hibernate.show_sql">true</prop>
				<!-- prop key="hibernate.cache.provider_class">org.hibernate.cache.TreeCacheProvider</prop -->
				<prop key="hibernate.cache.provider_class">org.jboss.hibernate.cache.DeployedTreeCacheProvider</prop>
				<prop key="hibernate.treecache.objectName">jboss.cache:service=TreeCache</prop>
				<prop key="hibernate.cache.use_query_cache">true</prop>
				<prop key="hibernate.cache.use_second_level_cache">true</prop>
				<prop key="hibernate.generate_statistics">true</prop>
				<!-- @APM added for batch processing -->
				<prop key="hibernate.jdbc.batch_size">20</prop>
				<prop key="hibernate.jdbc.fetch_size">20</prop>
				<!-- @APM end added for batch processing -->
				<!-- for transaction and rollback -->
				<prop key="hibernate.connection.release_mode">after_statement</prop>
				<!-- for transaction -->
				<!--prop key="hibernate.use_sql_comments">true</prop-->
				<!--prop key="hibernate.transaction.factory_class">org.hibernate.transaction.JDBCTransactionFactory</prop -->
				<prop key="hibernate.transaction.factory_class">org.hibernate.transaction.JTATransactionFactory</prop>
				<prop key="hibernate.transaction.manager_lookup_class">
					org.hibernate.transaction.JBossTransactionManagerLookup
				</prop>

			</props>
		</property>
	</bean>

<bean id="hibernatePropertieslogdb" class="org.springframework.beans.factory.config.PropertiesFactoryBean">
		<property name="properties">
			<props>
				<prop key="hibernate.dialect">org.hibernate.dialect.Oracle9Dialect</prop>
				<!--prop key="hibernate.query.substitutions">true 'T', false 'F'</prop-->
				<prop key="hibernate.show_sql">true</prop>
				<prop key="hibernate.cache.use_second_level_cache">false</prop>
				<prop key="hibernate.generate_statistics">true</prop>
				<!-- @APM added for batch processing -->
				<prop key="hibernate.jdbc.batch_size">20</prop>
				<prop key="hibernate.jdbc.fetch_size">20</prop>
				<!-- @APM end added for batch processing -->
				<!-- for transaction and rollback -->
				<prop key="hibernate.connection.release_mode">after_statement</prop>
				<!-- for transaction -->
				<!--prop key="hibernate.use_sql_comments">true</prop-->
				<!--prop key="hibernate.transaction.factory_class">org.hibernate.transaction.JDBCTransactionFactory</prop -->
				<prop key="hibernate.transaction.factory_class">org.hibernate.transaction.JTATransactionFactory</prop>
				<prop key="hibernate.transaction.manager_lookup_class">
					org.hibernate.transaction.JBossTransactionManagerLookup
				</prop>

			</props>
		</property>
	</bean>

<!-- For HibernateStats. Please see app*-jmx-quartz.xml for JMX Export -->
	<bean id="statisticsBean" class="org.hibernate.jmx.StatisticsService">
		<property name="statisticsEnabled">
			<value>true</value>
		</property>
		<property name="sessionFactory">
			<ref local="mySessionFactory" />
		</property>
	</bean>

<!-- For implemeting ThreadLocale support for each request -->
	<bean id="openSessionInViewInterceptor"
		class="org.springframework.orm.hibernate3.support.OpenSessionInViewInterceptor">
		<property name="sessionFactory">
			<ref bean="mySessionFactory" />
		</property>
	</bean>

	<bean id="hibernateInterceptor" class="org.springframework.orm.hibernate3.HibernateInterceptor">
		<property name="sessionFactory">
			<ref bean="mySessionFactory" />
		</property>
	</bean>

	<!-- Transaction Related Beans -->
	<bean id="transactionManager" class="org.springframework.transaction.jta.JtaTransactionManager">
		<property name="userTransactionName">
			<null />
		</property>
		<property name="transactionManagerName">
			<value>java:/TransactionManager</value>
		</property>
	</bean>

Please guide me how to go about the solution.

[Ankit Chandrawat]

I did a few changes like added <tx:annotation-driven/> to my applicationContext-db.xml and added @Transactional to the DAO class. I am able to go one step ahead now but facing

ERROR [LazyInitializationException] failed to lazily initialize a collection of role: com.ifs.app.model.adaptors.ScheduleGroupAdaptor.vendorServiceTransports, no session or session was closed

Its because after the data is fetched from the database I try doing a lazy loading from my code as follows:

private void sendEmailToContentManagersAndModerator(MHRContChatSessionDO chatSession) {
		MHRChatUsersDO chatUsers = null;
		Set<MHRChatUsersDO> chatUsersList = new HashSet<MHRChatUsersDO>(0);
		EmailManager emailManager = new EmailManager();
		JavaMailSenderImpl javaMailSenderImpl = new JavaMailSenderImpl();
		chatUsersList = chatSession.getChatUsers();
		Iterator<?> it = chatUsersList.iterator();
		while (it.hasNext()) {
			chatUsers = (MHRChatUsersDO) it.next();
			emailManager.setJavaMailSenderImpl(javaMailSenderImpl);
			StringBuilder sb = new StringBuilder();
			sb.append("<html><body style='font-family:Arial'>");
			sb.append("<strong>Hello,");
			sb.append(",</strong>");
			sb.append("<br><br><br>Please find attached the chat transcript of Chat discussion on the topic  <br>");
			sb.append(chatSession.getPreChatLongHeadline());
			sb.append("held on ");
			sb.append(chatSession.getStartTime());
			sb.append("<br><br>This version of transcript is also available on the website. Please review the content. You can add the updated chat transcript on website by configuring it in corresponding chat session DCR.<br><br>");
			sb.append("<b>Thank You.<b>");
			sb.append("</body></html>");
			String bodyContent = sb.toString();
			EmailVO emailVO = new EmailVO();
			emailVO.setTo(chatUsers.getName());
			emailVO.setSubject("Chat transcript moderation");
			emailVO.setAttachmentFileName(chatSession.getChatLogPath());
			emailVO.setFrom("[e-mail]");
			emailVO.setCustomMsg(bodyContent);
			//emailManager.sendEmail(emailVO);
		}
	}

In the while (it.hasNext()) it throws the error. Please guide me how to go about this now ?