StringIndexOutOfBoundsException in Program for File Upload

[Maya sekar]

Hi,


I have a code to upload files through a jsp page, i read it in my servlet. But it throws an StringIndexOutOfBoundsException when I run it and am not able to figure out why.

This is my code

import java.io.DataInputStream;
import java.io.File;
import java.io.FileOutputStream;
import java.io.IOException;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

/**
 * Servlet implementation class getFileUpload
 */
public class getFileUpload extends HttpServlet {
	private static final long serialVersionUID = 1L;
       
    /**
     * @see HttpServlet#HttpServlet()
     */
    public getFileUpload() {
        super();
        // TODO Auto-generated constructor stub
    }

	/**
	 * @see HttpServlet#doGet(HttpServletRequest request, HttpServletResponse response)
	 */
	protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
		// TODO Auto-generated method stub
	}

	/**
	 * @see HttpServlet#doPost(HttpServletRequest request, HttpServletResponse response)
	 */
	protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
		// TODO Auto-generated method stub
		String contentType = request.getContentType();  
		System.out.println(contentType);
		//here we are checking the content type is not equal to Null and  as well as the passed data from mulitpart/form-data is greater than or  equal to 0 
		if ((contentType != null) && (contentType.indexOf("multipart/form-data") >= 0))
		{         
			System.out.println("inside if");
			DataInputStream in = new DataInputStream(request. getInputStream());  
			//we are taking the length of Content type data        
			int formDataLength = request.getContentLength();         
			byte dataBytes[] = new byte[formDataLength];        
			int byteRead = 0;         
			int totalBytesRead = 0;        
			//this loop converting the uploaded file into byte code         
			while (totalBytesRead < formDataLength) 
			{             
				byteRead = in.read(dataBytes, totalBytesRead,  formDataLength);
				totalBytesRead += byteRead;        
			}          
			
			String outputFile=null;
			String file = new String(dataBytes); 
		
			//for saving the file name    
			//System.out.println(file);
			String saveFile = file.substring(file.indexOf("filename=\\") + 10);  
			System.out.println(saveFile);
			saveFile = saveFile.substring(0, saveFile.indexOf("\n"));
			saveFile = saveFile.substring(saveFile.lastIndexOf("\\")  +1,saveFile.indexOf("\""));   
			int lastIndex = contentType.lastIndexOf("=");       
			String boundary = contentType.substring(lastIndex + 1, contentType.length());    
			int pos;        
			//extracting the index of file         
			pos = file.indexOf("filename=\"");       
			pos = file.indexOf("\n", pos) + 1;       
			pos = file.indexOf("\n", pos) + 1;       
			pos = file.indexOf("\n", pos) + 1;       
			int boundaryLocation = file.indexOf(boundary, pos) - 4;        
			int startPos = ((file.substring(0, pos)).getBytes()).length;    
			int endPos = ((file.substring(0, boundaryLocation)) .getBytes()).length;   
			// creating a new file with the same name and writing the  content in new file  
			FileOutputStream fileOut = new FileOutputStream(outputFile);      
			fileOut.write(dataBytes, startPos, (endPos - startPos));       
			fileOut.flush();       
			
			fileOut.close();  
			
			System.out.println("You have successfully uploaded");
			}
		else
		{
			System.out.println("Error");
		}
		}
	}

Can anyone please tell me how to resolve the issue. Thank you in advance for replying.
Have a nice day

[Maya sekar]

@Bear

Thanks.. Took your advice

[Rob Spoor]

Please provide the exception stack trace. That will tell us where the exception occurred.