create multiple Checkboxes with data base values in jsp

hello

happy new year :D

i faced some problem while i am trying to create a multiple check boxes that comes from data base

this is my code .. in the jsp page .. that takes list of books comes from the local interface

and try to view books as chickboxes using For loop

<%@ page language="java" contentType="text/html; charset=UTF-8"
    pageEncoding="ISO-8859-1"%>
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<%@ page contentType="text/html; charset=UTF-8" %>
<%@ page import="javax.naming.*, java.util.*"%>
<%@ page import ="com.sun.tutorial.javaee.ejb.book" %>
<%@ page import="com.sun.tutorial.javaee.ejb.BookCatalogLocal" %>

<%!
  private BookCatalogLocal bci = null;
  
  Collection<book> list;
  String s1;
	  public void jspInit() {
		  try {
		  
			  InitialContext ic = new InitialContext();
			  bci = (BookCatalogLocal) ic.lookup("BookStoreEar/BookCatalog/local");
			
			  System.out.println("Loaded BookCatalog Bean");
		 
		  } catch (Exception ex) {
			  System.out.println("**************************Error:could noy creat bean class"+
			  ex.getMessage());
		  	}
		}
  
	  public void jspDestroy() {
	  	bci = null;
	  }
%>

<%

try {
		  s1=(String)request.getAttribute("Author");
		
		  if ( s1 != null ) {
		  list = bci.bringBooks(s1);
		
		  System.out.println("books has been brought");
 %>
 
 <body bgcolor="Gainsboro">
	<h1>Books by <%=s1 %></h1>
	<br>
	<hr>
		select any of the listed books and press submit
	<hr>
   		<form ACTION="fainal.jsp">

<%
 
	  String n;
	  	for (Iterator<book> iter = list.iterator(); iter.hasNext();){
		  book element = (book)iter.next();
		  n= element.getB_Name();
		  out.write("<input type='checkbox' name='books' value="+n+">"+n+"<BR>");
 
  		}
  
 	 }//end of if statement 
%>
  
<input type="submit" value="Submit">

</form>
  
  <%

String select[] = request.getParameterValues("Books"); 
		if (select != null && select.length != 0) {
			
			out.println("You have Borrowed : ");
			
			for (int i = 0; i < select.length; i++) {
				System.out.println(select[i]+",");

}
		}
%>

<br>

<%
 
  }// end of try
  catch (Exception e) {
  e.printStackTrace ();
  }
  %>

and every thing is going fine ,but it shoes only the last book in the checkboxes

for example if there is 3 books in the list let's say( book1 , book2 and book3 )

it only shows the last book three times in checkboxes like this :

[] book3
[] book3
[] book3

and i don't know what is the problem , is it because the Iterator or not ??

and i am sure that my list has all 3 books ( i tested it )

i really need your help here :)

hello

i found the mistake

the problem was when i bring the data from DB it comes as result set .. and i want to convert it to a list so i used this function

and i think this function was the problem ( i do not know where )

so i tried to convert the resultset to array of string

and i made the required changes to the classes and the jsp file

and it worked !!!

this is my new jsp file

<%@ page language="java" contentType="text/html; charset=UTF-8"
    pageEncoding="ISO-8859-1"%>
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<%@ page contentType="text/html; charset=UTF-8" %>
<%@ page import="javax.naming.*, java.util.*"%>
<%@ page import ="com.sun.tutorial.javaee.ejb.book" %>
<%@ page import="com.sun.tutorial.javaee.ejb.BookCatalogLocal" %>

<%!
  private BookCatalogLocal bci = null;
  
  String[] list;
  String s1;
	  public void jspInit() {
		  try {
		  
			  InitialContext ic = new InitialContext();
			  bci = (BookCatalogLocal) ic.lookup("BookStoreEar/BookCatalog/local");
			
			  System.out.println("Loaded BookCatalog Bean");
		 
		  } catch (Exception ex) {
			  System.out.println("**************************Error:could noy creat bean class"+
			  ex.getMessage());
		  	}
		}
  
	  public void jspDestroy() {
	  	bci = null;
	  }
%>

<%

try {
		  s1=(String)request.getAttribute("Author");
		
		  if ( s1 != null ) {
		  list = bci.bringBooks(s1);
		
		  System.out.println("books has been brought");
 %>
 
 <body bgcolor="Gainsboro">
	<h1>Books by <%=s1 %></h1>
	<br>
	<hr>
		select any of the listed books and press submit
	<hr>
   		<form ACTION="fainal.jsp">

<%
 
	  String n;
	  	for (int i=0 ; i<list.length;i++){

out.write("<input type='checkbox' name='books' value='"+list[i]+"'>"+list[i]+"<BR>");// i only need books names to view 
 
  		}
  
 	 }//end of if statment
 	 
 	 %>
  
<input type="submit" value="Submit">

</form>
  
  <%

String select[] = request.getParameterValues("Books"); 
		if (select != null && select.length != 0) {
			
			out.println("You have Borrowed : ");
			
			for (int i = 0; i < select.length; i++) {
				System.out.println(select[i]+",");

}
		}
%>

<br>

<%
 
  }// end of try
  catch (Exception e) {
  e.printStackTrace ();
  }
  %>

many thanks to everyone who tried to help :)

That function was the problem.
You need to create a new "book" object for each iteration of the loop.

ie instead of

It needs to be:

Otherwise you just keep adding the 'same' book object multiple times to the list, and overwriting the old values with new ones.
Which is why it looks like a list of just the 'last' book.

It is a common mistake that many of us have made along the way.
Easily made, and easily solved (once you know what to look for)

thank you very much Stefan

i did what you said and it is working very well now

many thanks to you :thumbup: