Form processing using register.java but it doesn't show my hashmap errormessages

[martin brow]

Hi,

I'm having trouble showing my errormessages for my registration form. I just don't see why the <%= regform.getErrorMessage("userName") %> doesn't show my error. What should I change?
If I enter correct information, it processes as it should, so there is nothing wrong with the form nor the bean. It's just the errormessages which won't show...
Register.java

package com.login;

import java.sql.*;
import java.util.*;
import java.util.logging.Level;
import java.util.logging.Logger;
import javax.servlet.http.*;
import com.dbconn.*;
import com.sun.rowset.CachedRowSetImpl;
import java.io.IOException;
import javax.servlet.ServletException;

/**
 *
 * @author martin
 */
public class register extends HttpServlet {

    private String userName;
    private String password;
    private String password_check;
    private String firstName;
    private String lastName;
    private String email;
    private String birthDate;

    public register() {
        userName = "";
        password = "";
        password_check = "";
        firstName = "";
        lastName = "";
        email = "";
        birthDate = "";
    }

    /*
     * Create error codes which can be shown in the different forms with help of the
     * map errorCodes_register
     */
    public static final Integer ERR_USERNAME_EMPTY = new Integer(1);
    public static final Integer ERR_PASSWORD_EMPTY = new Integer(2);
    public static final Integer ERR_PASSWORD_NOT_EQUAL = new Integer(3);
    public static final Integer ERR_FIRSTNAME_EMPTY = new Integer(4);
    public static final Integer ERR_LASTNAME_EMPTY = new Integer(5);
    public static final Integer ERR_EMAIL_EMPTY = new Integer(6);
    public static final Integer ERR_BIRTHDAY_EMPTY = new Integer(7);
    public static final Integer ERR_USERNAME_ALREADY_EXISTS = new Integer(8);
    public static final Integer ERR_INSERT_FAILED = new Integer(9);
    Map errorCodes_register = new HashMap();
    Map msgMap_register;

    public void setErrorMessages(Map msgMap) {
        this.msgMap_register = msgMap;
    }

    public String getErrorMessage(String propName) {
        Integer code = (Integer) (errorCodes_register.get(propName));
        if (code == null) {
            return "";
        } else if (msgMap_register != null) {
            String msg = (String) msgMap_register.get(code);
            if (msg != null) {
                return msg;
            }
        }
        return "Error";
    }

    public boolean isValid() throws ClassNotFoundException, SQLException {
        // Eerst checken of alles is ingevuld en correct is ingevuld
        // en errors uitdelen
        errorCodes_register.clear();
        if (getUserName().isEmpty()) {
            errorCodes_register.put(userName, ERR_USERNAME_EMPTY);
        }
        if (getPassword().isEmpty()) {
            errorCodes_register.put(password, ERR_PASSWORD_EMPTY);
        }
        if (!getPassword().equals(getPassword_check())) {
            errorCodes_register.put(password, ERR_PASSWORD_NOT_EQUAL);
        }
        if (getFirstName().isEmpty()) {
            errorCodes_register.put(firstName, ERR_FIRSTNAME_EMPTY);
        }
        if (getLastName().isEmpty()) {
            errorCodes_register.put(lastName, ERR_LASTNAME_EMPTY);
        }
        if (getEmail().isEmpty()) {
            errorCodes_register.put(email, ERR_EMAIL_EMPTY);
        }
        if (getBirthDate().isEmpty()) {
            errorCodes_register.put(birthDate, ERR_BIRTHDAY_EMPTY);
        }
        // Checken of userName UNIQUE is
        String query = "SELECT `gebruikersnaam` FROM `gebruiker`";
        DBConnection dbc = new DBConnection();
        CachedRowSetImpl crst = dbc.executeQuery(query);
        if (crst.next()) {
            do {
                if (crst.getString("gebruikersnaam").equals(userName)) {
                    errorCodes_register.put(userName, ERR_USERNAME_ALREADY_EXISTS);
                }
            } while (crst.next());
        }
        // Als er geen errors zijn, ga verder, anders stoppen
        if (!errorCodes_register.isEmpty()) {
            
            return false;
        } else {
            query = "INSERT INTO gebruiker (gebruikersnaam, wachtwoord, voornaam, email, geboortedatum, achternaam) VALUES(";
            query = query +"'"+userName+ "', '" +password+ "', '" +firstName+ "', '" +email+"', '"+birthDate+ "', '"+lastName+"')";
            System.out.println(query);
            if(dbc.insert(query)) {
                return true;
            } else {
                errorCodes_register.put(userName, ERR_INSERT_FAILED);
                
                return false;
            }
        }
    }

    public boolean process() throws ClassNotFoundException, SQLException {
        if(!isValid()) {
            return false;
        }
        errorCodes_register.clear();
        return true;
    }

    /**
     * @return the userName
     */
    public String getUserName() {
        return userName;
    }

    /**
     * @param userName the userName to set
     */
    public void setUserName(String userName) {
        this.userName = userName;
    }

    /**
     * @return the password
     */
    public String getPassword() {
        return password;
    }

    /**
     * @param password the password to set
     */
    public void setPassword(String password) {
        this.password = password;
    }

    /**
     * @return the password_check
     */
    public String getPassword_check() {
        return password_check;
    }

    /**
     * @param password_check the password_check to set
     */
    public void setPassword_check(String password_check) {
        this.password_check = password_check;
    }

    /**
     * @return the firstName
     */
    public String getFirstName() {
        return firstName;
    }

    /**
     * @param firstName the firstName to set
     */
    public void setFirstName(String firstName) {
        this.firstName = firstName;
    }

    /**
     * @return the lastName
     */
    public String getLastName() {
        return lastName;
    }

    /**
     * @param lastName the lastName to set
     */
    public void setLastName(String lastName) {
        this.lastName = lastName;
    }

    /**
     * @return the email
     */
    public String getEmail() {
        return email;
    }

    /**
     * @param email the email to set
     */
    public void setEmail(String email) {
        this.email = email;
    }

    /**
     * @return the birthDate
     */
    public String getBirthDate() {
        return birthDate;
    }

    /**
     * @param birthDate the birthDate to set
     */
    public void setBirthDate(String birthDate) {
        this.birthDate = birthDate;
    }
}

index.jsp:

<%@page import="com.login.register"%>
<%@page import="com.request_response"%>
<%@page import="com.login.CheckLogin"%>
<%@page import="com.login.login"%>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<%@ page contentType="text/html;charset=UTF-8"%>
<%-- <%@ page errorPage="error.jsp"%> --%>
<%@ page language="java" import="java.sql.*,javax.servlet.http.Cookie"%>
<jsp:useBean id="loginform" class="com.login.login" scope="request" >
    <jsp:setProperty name="loginform" property="errorMessages" value='<%= errorMap_login%>' />
</jsp:useBean>
<jsp:useBean id="regform" class="com.login.register" scope="application" >
    <jsp:setProperty name="regform" property="errorMessages" value='<%= errorMap_register%>' />
</jsp:useBean>
<jsp:useBean id="req_res" class="com.request_response" scope="request" />
<jsp:useBean id="checkLogin" class="com.login.CheckLogin" scope="request" />
<jsp:useBean id="getcookies" class="com.Cookies.getCookies" scope="request" />
<jsp:useBean id="logoff_form" class="com.login.logoff" scope="request">
    <jsp:setProperty name="logoff_form" property="errorMessages" value='<%= errorMap_login%>' />
</jsp:useBean>

<%
            req_res.set(request, response);
            checkLogin.doPost(request, response);
            if ("true".equals(request.getParameter("loginform_process"))) {
%>
<jsp:setProperty name="loginform" property="*" />
<%
                if (loginform.process()) {
                    response.sendRedirect("JSP/index.jsp");
                    return;
                }
            }
            if ("true".equals(request.getParameter("logoff_form_process"))) {
%>
<jsp:setProperty name="logoff_form" property="*" />
<%
                if (logoff_form.process()) {
                    response.sendRedirect("JSP/index.jsp");
                    return;
                }
            }
            if ("true".equals(request.getParameter("regform_process"))) {
%>
<jsp:setProperty name="regform" property="*" />
<%
                if (regform.process()) {
                    
                    response.sendRedirect("index.jsp");
                    return;
                }
            }
%>

<html xmlns="http://www.w3.org/1999/xhtml" >
    <head>
        <title>Brabbel</title>
        <meta http-equiv="content-type" content="text/html; charset=iso-8859-1" />
        <link rel="stylesheet" type="text/css" href="stylesheet.css" />
    </head>
    <body>
        <% if (checkLogin.process()) {%>
        <form action='<%= request.getRequestURI()%>' method="POST" >
            Vergeet mij <input type="checkbox" name="forget" value="forget" />
            <input type="submit" name="logoff" value="button"/>
            <input type="hidden" name="logoff_form_process" value="true" />
        </form>
        <% } else {%>
        <form action='<%= request.getRequestURI()%>' method="POST">
            <p><%= loginform.getErrorMessage("userName")%></p>
            <p> <label>login: </label>
                <label>userName: </label><input type="text" name="userName" value='<jsp:getProperty name="checkLogin" property="userName"/>' />
                <label>password:</label> <input type="password" name="password" />
                <input type="submit" value="Login!"  />
                <input type="hidden" name="loginform_process" value="true" />
            </p>
        </form>
        <form action='<%= request.getRequestURI()%>' method="POST">
            <p><label>register:</label>
                <p><%= regform.getErrorMessage("userName")%>
                </p><label>username: </label><input type="text" name="userName" value='<jsp:getProperty name="regform" property="userName"/>' /><br />
                <p><%= regform.getErrorMessage("password")%></p>
                <label>password: </label><input type="password" name="password" /><br />
                <label>password(2x): </label><input type="password" name="password_check" /><br />
                <p><%= regform.getErrorMessage("firstName")%></p>
                <label>voornaam: </label><input type="text" name="firstName" value='<jsp:getProperty name="regform" property="firstName"/>' /><br />
                <p><%= regform.getErrorMessage("lastName")%></p>
                <label>achternaam: </label><input type="text" name="lastName" value='<jsp:getProperty name="regform" property="lastName"/>' /><br />
                <p><%= regform.getErrorMessage("email")%></p>
                <label>email: </label><input type="text" name="email" value='<jsp:getProperty name="regform" property="email"/>' /><br />
                <p><%= regform.getErrorMessage("birthDate")%></p>
                <label>geboortedatum: </label><input type="text" name="birthDate" value='<jsp:getProperty name="regform" property="birthDate"/>' /><br />
                <input type="submit" value="register!" /><br />
                <input type="hidden" name="regform_process" value="true" /><br />
            </p>

        </form>
        <%    }%>
    </body>
</html>

<%!    java.util.Map errorMap_login = new java.util.HashMap();
java.util.Map errorMap_register = new java.util.HashMap();

    public void jspInit() {
        errorMap_login.put(login.ERR_INVALID_COMBINATION, "Combinatie gebruikersnaam en wachtwoord niet correct");
        errorMap_login.put(login.ERR_USERNAME_NOT_EXISTS, "Username bestaat niet");
        errorMap_login.put(login.ERR_QUERY_EMPTY, "Database returned an empty query");
        errorMap_login.put(login.ERR_SQL_EXCEPTION, "SQL Exception");
        errorMap_login.put(login.ERR_CLASS_NOT_FOUND, "Class not found");
        errorMap_login.put(login.ERR_RES_NOT_INSTANTIATED, "response not instantiated");
        errorMap_login.put(CheckLogin.ERR_REQ_NOT_INSTANTIATED, "Request not ready :- Empty Cookie set");
        errorMap_login.put(CheckLogin.ERR_NO_COOKIES, "Empty Cookie set");
        errorMap_login.put(request_response.ERR_RES_NOT_INITIATED, "Response not initialized");
        errorMap_login.put(request_response.ERR_REQ_NOT_INITIATED, "Request not initialized");
        errorMap_register.put(register.ERR_USERNAME_EMPTY, "Username was leeg");
        errorMap_register.put(register.ERR_PASSWORD_EMPTY, "Password was leeg");
        errorMap_register.put(register.ERR_PASSWORD_NOT_EQUAL, "Wachtwoorden waren niet gelijk");
        errorMap_register.put(register.ERR_FIRSTNAME_EMPTY, "Voornaam was leeg");
        errorMap_register.put(register.ERR_LASTNAME_EMPTY, "Achternaam was leeg");
        errorMap_register.put(register.ERR_EMAIL_EMPTY, "Email was leeg");
        errorMap_register.put(register.ERR_BIRTHDAY_EMPTY, "Geboortedatum was leeg");
        errorMap_register.put(register.ERR_USERNAME_ALREADY_EXISTS, "Gebruikersnaam bestaat al");
        errorMap_register.put(register.ERR_INSERT_FAILED, "Insert Failed");

    }

%>

I really hope you can help me solving this problem.

Thanks,

Hadez