Proper Usage of the Dependency Injection in MVC

[Csabba Csurja]

Hello Guys,

I am curious about your opinion regarding to the proper implementation/usage of DI in Spring MVC:

There are two classes: One Controller which works with a List (for dropdown menu) and there is an another Service class which carries the List elements from DB layer.
How would you inject Service into Contoller in Spring MVC?

@Controller
@RequestMapping("/showDropdowns")
public class DropDownController{
  private List<String> dropDownItems;

  // This class pass dropDownItems to Model for the usage of the JSP site
  @ModelAttribute
  public void initModelAttribute(Model model){
     model.addAttribute("dropDownItems",dropDownItems);
     //...this dropDown items shall be used on JSP/JSTL Page as a dropdown menu let's say with ...<form:options path="${dropDownItems}"/>... Tag
  ...

public class DropDownSerivce{
  
   public List<String> getDropDownItems(){
             // Service use some DAO class which carries the values from DB         
            return dropDownItemsDAO.getDropDownsItems();
   }
}

My questions:
Is there a way to inject DropDownService.getDropDownItems() elements into DropDownController.dropDownItems List through Dependency Injection in this case? If yes, then how ;-)

Actually, I am looking for the most sophisticated solution, for this reason I am curious about your opinion!

Thanks,
Csaba

[Mark Spritzler]

@Controller  
@RequestMapping("/showDropdowns")  
public class DropDownController{  
  
    @Autowired
    private DropDownSerivce dropDownService;
  
  // This class pass dropDownItems to Model for the usage of the JSP site  
  @ModelAttribute("dropDownItems")  
  public List<String initModelAttribute(Model model){  
      return dropDownService.getDropDownItems;
  }

To me that is the easiest. I am also under the assumption that you see the typo in your DropDownSerivce class and that that class is defined in a Spring configuration, either with @Service or as a ><bean> in your xml.

Mark

[Csabba Csurja]

Thanks Mark!

Can I say, that I was not able to see the wood for the trees ? ;-)