problem in ActionListener

[sagar khana]

i am having problem in this actionlistner while running first time it get called once and next time it called twice then four times and so on

here is code please give me any solution

thank you very much

public void launch()
{
try
{
Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
Connection con=DriverManager.getConnection("jdbc:odbc:cone");
try
{
Statement st=con.createStatement();
String str="SELECT * FROM quizcontest";
ResultSet rs=st.executeQuery(str);

while(rs.next())
{
id[i]=rs.getInt("id");
ques[i]=rs.getString("ques");
a[i]=rs.getString("a");
b[i]=rs.getString("b");
c[i]=rs.getString("c");
d[i]=rs.getString("d");
cor[i]=rs.getString("cor");
//System.out.println(" "+id[i]+" "+ques[i]+" "+a[i]+" "+b[i]+" "+c[i]+" "+d[i]);
i++;
}
i--;
con.close();
}
catch(SQLException e)
{
System.out.println("Table creation process denied");}
}
catch(Exception e)
{
    e.printStackTrace();
}

}

public void display()
{
   // System.out.println("value of g in display="+g+"\n\n");
if(g<=i)
{
    
//System.out.println(" "+id[g]+" "+ques[g]+" "+a[g]+" "+b[g]+" "+c[g]+" "+d[g]);
 //   System.out.println("display"+g);
//f1.dispose();
p1=new JPanel();
p2=new JPanel();
p3=new JPanel();
p4=new JPanel();
p5=new JPanel();
//p1.removeAll();

l1=new JLabel(ques[g]);
r1=new JRadioButton(a[g]);
r2=new JRadioButton(b[g]);
r3=new JRadioButton(c[g]);
r4=new JRadioButton(d[g]);

p1.add(l1);
b2.add(p1);

p2.add(r1);
p2.add(r2);
b2.add(p2);

p3.add(r3);
p3.add(r4);
b2.add(p3);

p4.add(b1);
b2.add(p4);
f1.add(b2);
f1.pack();
f1.setVisible(true);
b1.addActionListener(this);
}}

//    @Override
    public void actionPerformed(ActionEvent e) {
  

                   if(g<i)
                    g=g+1;
                    p1.remove(l1);
                    p2.remove(r1);
                    p2.remove(r2);
                    p3.remove(r3);
                    p3.remove(r4);
                    b2.remove(p1);
                    b2.remove(p2);
                    b2.remove(p3);
                    
                     System.out.println("submit"+g);
                    display();
                    System.out.println("value of g in listner="+g);
                    //l1.remove(ques);                    
                
      }

[Matthew Brown]

Every time actionPerformed() is called it calls display(). And display() creates a load of new components and adds the ActionListener again. You really need to rethink your logic there. You ought to have some initialisation code that creates the components and adds event listeners, and then the event handlers should do the minimum amount of work needed to update the display.

In terms of design, I'd also be worried about a class that contains GUI code and database code, as these are completely separate concerns, but that's not your immediate problem.

[sagar khana]

Matthew Brown wrote:Every time actionPerformed() is called it calls display(). And display() creates a load of new components and adds the ActionListener again. You really need to rethink your logic there. You ought to have some initialisation code that creates the components and adds event listeners, and then the event handlers should do the minimum amount of work needed to update the display.

In terms of design, I'd also be worried about a class that contains GUI code and database code, as these are completely separate concerns, but that's not your immediate problem.

thank you i put addactionlistner outside and it works well