Code improvement: 2 similar methods

[Matt Kurz]

Below 2 similar methods which connect per cxf to web service servers. Each method connects to a different one. How can I improve this code?

    public void connectWS1(String wsUrl, String wsUser, String wsPass) throws DataException {
        try {
            JaxWsProxyFactoryBean factory = getJaxWsProxyFactory(FirstServicePortType.class, wsUrl,
                    wsUser, wsPass);
            this.firstService = (FirstServicePortType) factory.create();

            FirstService params = new FirstService();
            FirstService.TTABLE table = new FirstService.TTABLE();
            FirstItem searchItem = new FirstItem();
            table.getItem().add(searchItem);
            params.setTTABLE(table);
            FirstServiceResponse lfResponse = firstService.FirstService(params);
            List<FirstItem> items = lfResponse.getTTABLE().getItem();

            List<Map<String, String>> list = new ArrayList<Map<String, String>>();

            for (FirstItem item : items) {
                if (gueltigBisIsAfterNow(item.getGUELTIGBIS())) {
                    if (isILN(item.getILNNRLF())) {
                        HashMap<String, String> hash = new HashMap<String, String>();
                        hash.put(RcvData.Tags.MESTYP.toString(), item.getMESTYP());
                        hash.put(RcvData.Tags.ILNNR_LF.toString(), item.getILNNRLF());
                        hash.put(RcvData.Tags.GUELTIG_BIS.toString(), item.getGUELTIGBIS());
                        hash.put(RcvData.Tags.LF_NAME_KURZ.toString(), item.getLFNAMEKURZ());
                        hash.put(RcvData.Tags.SACHBEARBEITER.toString(), item.getSACHBEARBEITER());
                        hash.put(RcvData.Tags.CONTROL.toString(), item.getCONTROL());
                        hash.put(RcvData.Tags.TURN_CRME.toString(), item.getTURNCRME());
                        hash.put(RcvData.Tags.VARIANTE.toString(), item.getVARIANTE());

                        Map<String, String> u_map = Collections.unmodifiableMap(hash);
                        list.add(u_map);
                    }
                }
            }
            this.RcvData = new RcvData(Collections.unmodifiableList(list));
        } catch (Exception e) {
            throw new DataException("Failed to update data.", e);
        }
    }


    public void connectWS2(String wsUrl, String wsUser, String wsPass) throws DataException {
        try {
            JaxWsProxyFactoryBean factory = getJaxWsProxyFactory(ZSTDCG.class, wsUrl,
                    wsUser,
                    wsPass);
            this.secondService = (ZSTDCG) factory.create();

            SecondService params = new SecondService();
            SecondService.TTABLE table = new SecondService.TTABLE();
            SecondItem searchItem = new SecondItem();
            table.getItem().add(searchItem);
            params.setTTABLE(table);
            SecondServiceResponse lfrResponse = secondService.SecondService(params);
            List<SecondItem> items = lfrResponse.getTTABLE().getItem();

            List<Map<String, String>> list = new ArrayList<Map<String, String>>();

            for (SecondItem item : items) {
                if (gueltigBisIsAfterNow(item.getGUELTIGBIS())) {
                    if (isILN(item.getILNNRLF())) {
                        HashMap<String, String> hash = new HashMap<String, String>();
                        hash.put(RcvData2.Tags.MESTYP.toString(), item.getMESTYP());
                        hash.put(RcvData2.Tags.ILNNR_LF.toString(), item.getILNNRLF());
                        hash.put(RcvData2.Tags.REGIO.toString(), item.getREGIO());
                        hash.put(RcvData2.Tags.VERSION.toString(), item.getVERSION());
                        hash.put(RcvData2.Tags.GUELTIG_BIS.toString(), item.getGUELTIGBIS());
                        hash.put(RcvData2.Tags.STATUS.toString(), item.getSTATUS());

                        Map<String, String> u_map = Collections.unmodifiableMap(hash);
                        list.add(u_map);
                    }
                }
            }
            this.RcvData2 = new RcvData2(Collections.unmodifiableList(list));
        } catch (Exception e) {
            throw new DataException("Failed to update data.", e);
        }
    }

 
    private JaxWsProxyFactoryBean getJaxWsProxyFactory(Class<?> serviceClass, String wsUrl, String wsUser,
            String wsPass) {
        JaxWsProxyFactoryBean factory = new JaxWsProxyFactoryBean();
        factory.getInInterceptors().add(new LoggingInInterceptor());
        factory.getOutInterceptors().add(new LoggingOutInterceptor());
        factory.setServiceClass(serviceClass);
        factory.setAddress(wsUrl);
        factory.setUsername(wsUser);
        factory.setPassword(wsPass);
        return factory;
    }

[Mohamed Sanaulla]

Are FirstService and SecondService, FirstItem and SecondItem and FirstServiceResponse and SecondServiceResponse not related to each other? You can create an Interface for Service and Item which these would implement and then in your connectWS1 method you can program to an interface. You should make your method unaware of the type by encapsulating the type information as well.

[Matt Kurz]

Mohamed Sanaulla wrote:Are FirstService and SecondService, FirstItem and SecondItem and FirstServiceResponse and SecondServiceResponse not related to each other? You can create an Interface for Service and Item which these would implement and then in your connectWS1 method you can program to an interface. You should make your method unaware of the type by encapsulating the type information as well.

I've thought about an interface, too, but it I'am unsure if it's without prblems to modify the automatic generated code of these classes. They were created by wsdl2java. I'am thinking about generics, too. Maybe a generic method would be fine to shorten the code until the for loop.