JS error - Message: Member not found

[Dan Drillich]

Good Day,

I get this error in IE8 and a recent Firefox -

Message: Member not found.

Line: 130
Char: 5
Code: 0
URI: http://xxxx.com/sites/healthpromotion/scripts/scroll.js

function toggleView(id) {
  var item = document.getElementById(id);
  var value = parseInt(item.style.height);
  
  if (value > 0) {
  	document.getElementById("img_" + id).src = "/sites/healthpromotion/images/h3-Arrow_down_orange.png";
	document.getElementById("img_" + id).alt = "Click to expand this content.";
	document.getElementById("img_" + id).style = "margin-right:10px;";
  }
  else {
  	document.getElementById("img_" + id).src = "/sites/healthpromotion/images/h3-Arrow_orange.png";
    document.getElementById("img_" + id).alt = "Click to collapse this content.";
    document.getElementById("img_" + id).style = "margin-right:10px;";
  }
}

Commenting out the four lines that refer to alt and style clear the error. I think it's the style lines...

Any idea why?

Regards,
Dan

[Bear Bibeault]

You've narrowed it down to 4 lines. Next step is to narrow it down to 1.

[Bear Bibeault]

P.S. Are you using any debugging tool? All modern browsers have JavaScript debuggers built in (except Firefox where you need the Firebug plugin). Do you get better error messages from the other browsers?

[Dan Drillich]

Thank you Bear.

[Bear Bibeault]

You're welcome.

What are you finding? None of those assignment statements should cause an issue (unless the reference evaluates as null) because if a property does not exist on a JavaScript object, it is created.

[Dan Drillich]

Hi Bear,

Interesting thing, the following line breaks the code -

document.getElementById("img_" + id).style = "margin-right:10px;";

Throwing the error -

Message: Member not found.

The references in the img tags are -

<img  id="img_content1" border="0"    >
<img  id="img_content2" border="0"    >
<img  id="img_content3" border="0"    >
<img  id="img_content4" border="0"    >
<img  id="img_content5" border="0"    >
<img  id="img_content6" border="0"    >
<img  id="img_content7" border="0"    >
<img  id="img_content8" border="0"    >
<img  id="img_content9" border="0"    >
<img  id="img_content10" border="0"    >
<img  id="img_content11" border="0"    >
<img  id="img_content12" border="0"    >

And the divs look like -

<div id="content4">

Any insight would be greatly appreciated.

Regards,
Dan

[Bear Bibeault]

The message "Message: Member not found." isn't very illuminating. It gives this exact message in both failing browsers? (If not, withholding the other message isn't helping any.)

Are you sure that the element reference is valid when the error occurs?

[Dan Drillich]

Hi Bear,

It might be easier to see the error as it happens when expanding any of the sections on the page .... removed...

Regards,
Dan

[Bear Bibeault]

I get no errors in Firefox 10. Nor on any other browser running on my Mac. Cant help you with testing IE. No Windows here.

And you haven't answered my question about the reference.

[Dan Drillich]

Thank you Bear.

Sorry but I don't know if the element reference is valid when referenced.

Regards,
Dan

[Bear Bibeault]

Well, that's easy enough to find out. Test that the reference really points to the element.

Enable the JavaScrip console (or Firebug) and either set a breakpoint, or add a log statement.

[Dan Drillich]

Much appreciated Bear.

Regards,
Dan

[Bear Bibeault]

Let us know what you discover.

[Eric Pascarello]

This is not the correct way to set a style, hence the error.

    document.getElementById("img_" + id).style = "margin-right:10px;";   

Eric