javaScipt onsubmit problem in jsp

hi ranchers,

here is a jsp file which accepts the user id and password.When user does not enters the id and password and submit the form
then it should display the alert box message as wriiten in javascrpit.

but what is happening is it does not showing alert box when i submit the form without providing id and password.

can anyone help with this.

Use a JavaScript debugger to see what's going in inside your function. Find out:
Is the function being called at all?
Is it fetching the right element values?
Is the comparison working as expected?

and so on

All modern browsers have JavaScript consoles except for Firefox, for which you can use the Firebug plugin.

And, why are you checking for null?

Hi Naveen,

There's a very minor issue in your code. Here it is :

In your javascript function

you have defined both variables as x. whereas the second one where you collect the password should be y.

Moreover instead of using the && operator in the check, you should use ||. Because && operator will not satisfy the condition where one of the fields is null. So all in all your code should be better written as

To enhance it even further you can do separate validation for user id and password. Also note that as good coding practices, its better to give meaningful names to variables.

Hope this helps!

Thanks and Regards,
-------------------------------------------------------------------------------------
Komal Renu | krenu@infocepts.com | www.infocepts.com
-------------------------------------------------------------------------------------

Do you not think it would have been better to help him learn how to find such errors himself?

Sigh.

In any case, I ask again. Why the comparisons for null? The value of an element will never be null.

Yes a check with null isn't actually required. my bad!

Komal

Komal Renu wrote:Hi Naveen,

There's a very minor issue in your code. Here it is :

In your javascript function

var x=document.forms["myForm"]["id"].value; var x=document.forms["myForm"]["pwd"].value;

you have defined both variables as x. whereas the second one where you collect the password should be y.

Moreover instead of using the && operator in the check, you should use ||. Because && operator will not satisfy the condition where one of the fields is null. So all in all your code should be better written as

function validateForm() { var userId=document.forms["myForm"]["id"].value; var password=document.forms["myForm"]["pwd"].value; if (userId=="" || password=="") { alert("User id and password are mandatory fields."); return false; } }

To enhance it even further you can do separate validation for user id and password. Also note that as good coding practices, its better to give meaningful names to variables.

Hope this helps!

Thanks and Regards,
-------------------------------------------------------------------------------------
Komal Renu | krenu@infocepts.com | www.infocepts.com
-------------------------------------------------------------------------------------

yes that was the problem and it is resolved.

thanks

You should really validate your HTML form, it has tons of errors.

http://validator.w3.org/

Eric