can you help me?

[naved momin]

i have written a method which zip a folder which only contains multiple files but when there is sub folder within that folder my code breaks, so i have written this method
which list the entire files in a directory by recursive call but still this code fails to achieve what i want
output of this code is just a folder with the name like if i specify to zip a "abc " folder and the destination name would be "abc.zip" i get a "folder" named "abc.zip"

can any one help me ?

void foo(File scr , File dest) throws FileNotFoundException, IOException
    {
        FileInputStream inputStream;
        ZipOutputStream zipOs ;
        
        if(scr.isDirectory())
        {
            if( !dest.exists() )
            {
                dest.mkdir();
            }
            
            String[] list = scr.list();
            for(String file : list)
            {
                File newScr = new File(scr, file);
                File newDest = new File(dest, file);
                foo(newScr, newDest);
            }
        }else
        {
           
            inputStream = new FileInputStream( scr );
            zipOs = new ZipOutputStream( new FileOutputStream( dest ) );
             
            zipOs.setLevel( 1 );
            zipOs.putNextEntry( new ZipEntry( scr.getName() ));
            int len = 0;
            byte[] buffer = new byte[1024];
            while(( len = inputStream.read( buffer ) ) > 0 )
            {
                zipOs.write( buffer, 0, len );
            }
            
            zipOs.flush();
            zipOs.close();
        }
        
    }

[Jeff Verdegan]

In the future, please UseAMeaningfulSubjectLine(⇐click) so people will know at a glance what your question is about and can then easily decide whether they're interested in pursuing it.

[Jeff Verdegan]

It would be easier to understand what you're trying to do if you gave your method a meaningful name. I think what you're trying to do (but I'm not sure) is zip up an entire directory structure--including files and subdirectories--into a single zip file. Is that right?

If this is what you're trying to do, then why are you creating a new output file for each input file you encounter?

If this is not what you're trying to do, please explain it more clearly.

[Steve Luke]

If I understand correctly, you want a File named "abc.zip." But what is really happening is that a Folder named "abc.zip" is being created, not a File.

The reason for this is line 10:

dest.mkdir();

This method specifically makes the a Folder (or directory) with the name you provide it. Instead, if you want to make sure all the folders in which the abc.zip file is supposed to be stored are made, then you should do:

dest.getParentFile().mkdirs();