ajax not working with jsp

[Anand Shrivastava]

Dear friends,

Kindly consider the following function:

<script type="text/javascript">
function validate()
{
	message="";																																																
	appendError(checkEmpty("name"));
	appendError(checkEmpty("address"));
	appendError(checkEmpty("phone"));
	appendError(checkEmpty("mobile"));
	appendError(checkEmpty("email"));
	appendError(checkNumber("phone"));
	appendError(checkNumber("mobile"));
	appendError(checkEmail("email"));
	if (printError())
		{
			return false;
		}
	else
		{
			var name = document.getElementById("name").value;
			var address = document.getElementById("address").value;
			var phone = document.getElementById("phone").value;
			var mobile = document.getElementById("mobile").value;
			var email = document.getElementById("email").value;
			
			/*SAVING THROUGH AJAX*/

			xmlhttp=getXMLObject();
			if (!xmlhttp)
				{
					alert ("Your browser does not support XMLHTTP!");
					return;
				}
			var url="savesupplier.jsp";
			url=url+"?name="+escape(name)+"?address="+escape(address)+"?telephone="+escape(phone)+"?mobile="+escape(mobile)+"?email="+escape(email)
			url=url+"&sid="+Math.random();
			alert(url);
			xmlhttp.onreadystatechange=stateChanged;
			xmlhttp.open("GET",url,true);
			xmlhttp.setRequestHeader('Content-Type', 'application/x-www-form-urlencoded');
			xmlhttp.send(null);
			return true;
		}
		
}

function stateChanged()
{
if (xmlhttp.readyState == 4) {
     if(xmlhttp.status == 200) {
       alert("saved");
     }
     else {
        alert("Error during AJAX call. Please try again. Status -" + xmlhttp.status);
     }
   }
  
}

function getXMLObject()  //XML OBJECT
{
   var xmlHttp = false;
   try {
     xmlHttp = new ActiveXObject("Msxml2.XMLHTTP")  // For Old Microsoft Browsers
   }
   catch (e) {
     try {
       xmlHttp = new ActiveXObject("Microsoft.XMLHTTP")  // For Microsoft IE 6.0+
     }
     catch (e2) {
       xmlHttp = false   // No Browser accepts the XMLHTTP Object then false
     }
   }
   if (!xmlHttp && typeof XMLHttpRequest != 'undefined') {
     xmlHttp = new XMLHttpRequest();        //For Mozilla, Opera Browsers
   }
   return xmlHttp;  // Mandatory Statement returning the ajax object created
}

</script>

And the following jsp file which is used for saving in database only

<%@ page import="Codes.*, java.util.*" %>
<%
	Supplier sup = new Supplier();
	sup.setName(request.getParameter("name"));
	sup.setAddress(request.getParameter("address"));
	sup.setTelephone(Long.parseLong(request.getParameter("telephone").trim()));
	sup.setMobile(Long.parseLong(request.getParameter("mobile").trim()));
	sup.setEmail(request.getParameter("email"));
	sup.Save();
%>

However, the ajax is not working and the data is not getting saved and i get the status as 0. Please help.

[Wendy Gibbons]

taken my comments back.

[Stefan Evans]

Looks ok to me at a glance.

That java code should really be in a servlet rather than a jsp.

Are you able to tell if your JSP url is being invoked (use a net monitor in your browser, or a tool like Fiddler)
Are there any javascript errors in your console?

Are you perchance using firefox? http://stackoverflow.com/questions/3881359/xmlhttprequest-returns-status-of-0-in-firefox-3-6-10-and-up-from-cross-origin-re

[Koen Aerts]

Does the JSP file get executed at all? If yes, does it return anything? Perhaps the content type needs to be set correctly in the JSP code. At the following link you can find a complete AJAX example, using a JSP file: http://koenaerts.ca/a-complete-ajax-example/
The example uses a POST rather than a GET to send the request, which I would recommend because the GET URL has limitations on how long it can be, something like 1024 characters or something like it, I can't remember exactly.

[Bear Bibeault]

Koen Aerts wrote:The example uses a POST rather than a GET to send the request, which I would recommend because the GET URL has limitations on how long it can be

This is not the proper criteria on which to determine whether to use a GET or a POST. These methods have clearly defined roles within HTTP.

GET should be used for idempotent requests used to fetch a resource. POST for operations that are potentially non-idempotent.

[Anand Shrivastava]

Dear friends,

Thanks a lot. I figured it out.
The URL is malformed
It was

var url="savesupplier.jsp";  
 url=url+"?name="+escape(name)+"?address="+escape(address)+"?telephone="+escape(phone)+"?mobile="+escape(mobile)+"?email="+escape(email)  
url=url+"&sid="+Math.random();  

whereas, "&" should be used in place of "?" and it should be

var url="savesupplier.jsp";  
 url=url+"?name="+escape(name)+"&address="+escape(address)+"&telephone="+escape(phone)+"&mobile="+escape(mobile)+"&email="+escape(email)  
url=url+"&sid="+Math.random();  

Thanks a lot friends.