Optimization algorithm

[Dmitriy Logov]

import java.awt.Dimension;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
import javax.swing.JFrame;
import javax.swing.JScrollPane;
import javax.swing.JTable;
import javax.swing.JButton;
import javax.swing.event.TableModelListener;
import javax.swing.table.TableModel;
import java.awt.*;
import java.awt.event.*;

public class TestFrame extends JFrame {

	static int i = 0;
	JButton accept = new JButton("Accept");
	JScrollPane tabled;
	ArrayList<Struct> Alist = new ArrayList<Struct>();
	TableModel model;
	JTable table;
	public TestFrame() {
		super("Тестовое окно");
		setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		for (int i = 0; i < 5; i++) {
			Alist.add(new Struct(i, "c1 " + i));
		}
		model = new MyTableModel(Alist);
		table = new JTable(model);
		getContentPane().setLayout( null ); 
		tabled = new JScrollPane(table);
		
		tabled.setBounds( 15, 15, 600, 380 );
		getContentPane().add(tabled);
		accept.setBounds( 15, 410, 100, 24 );
		getContentPane().add(accept);

		setPreferredSize(new Dimension(640, 480));
		pack();
		setLocationRelativeTo(null);
		setVisible(true);
		accept.addActionListener(new AcceptListener( ));
	}
	class AcceptListener implements ActionListener
	{
		public void actionPerformed(ActionEvent event)
		{
			Alist.add(new Struct(i, "b " + i)); ++i;
			//table.updateUI();
		}
	}
	public static void main(String[] args) {
		javax.swing.SwingUtilities.invokeLater(new Runnable() {
			public void run() {
				JFrame.setDefaultLookAndFeelDecorated(true);
				new TestFrame();
			}
		});
	}
	public class MyTableModel implements TableModel {

		private Set<TableModelListener> listeners = new HashSet<TableModelListener>();
		private List<Struct> Alist;

		public MyTableModel(List<Struct> Alist) {
			this.Alist = Alist;
		}
		public void addTableModelListener(TableModelListener listener) {
			listeners.add(listener);
		}
		public Class<?> getColumnClass(int columnIndex) {
			if (columnIndex == 0) return int.class;
			else return String.class;
		}
		public int getColumnCount() {
			return 2;
		}
		public String getColumnName(int columnIndex) {
			switch (columnIndex) {
			case 0:
				return "Title1";
			case 1:
				return "Title2";
			}
			return "";
		}
		public int getRowCount() {
			return Alist.size();
		}
		public Object getValueAt(int rowIndex, int columnIndex) {
			Struct bean = Alist.get(rowIndex);
			switch (columnIndex) {
			case 0:
				return bean.getNum();
			case 1:
				return bean.getstr1();
			}
			return "";
		}
		public boolean isCellEditable(int rowIndex, int columnIndex) {
			return false;
		}
		public void removeTableModelListener(TableModelListener listener) {
			listeners.remove(listener);
		}
		public void setValueAt(Object value, int rowIndex, int columnIndex) {
		}

	}
	public class Struct {
		private int num;
		private String str1;
		public Struct(int num, String str1) {
			this.setNum(num);
			this.setstr1(str1);
		}
		public void setNum(int num) {
			this.num = num;
		}
		public int getNum() {
			return num;
		}
		public void setstr1(String str1) {
			this.str1 = str1;
		}
		public String getstr1() {
			return str1;
		}
	}
}

When I press the button "accept" the table is not updated. I use updateUI. But when more than 1000 lines updated 30 times per second - this method is not suitable. Are there ways to optimize?

[Darryl Burke]

Calling updateUI() is a mistake. That method is to be called after changing the Look&Feel.

There's too much code there that's unrelated to the stated problem. To get better help sooner, post a SSCCE (Short, Self Contained, Compilable and Executable) example.

edit But I do see that your TableModel implementation doesn't seem to be firing any updates. Fixing that iwll probably solve your problem.

[Dmitriy Logov]

Darryl Burke, сan you give some examples or help to fix my code?

[Darryl Burke]

Go through the source of AbstractTableModel and DefaultTableModel for inspiration.