help me it is a simple code but i need help

[Ashutosh Raikvar]

package innerclasstr;
import javax.swing.*;
import java.awt.event.*;
import java.awt.*;

public class Innerclasstr {
    JFrame frame;
    JLabel label;
    Drawpanel drawpanel;
    int x=70,y=70;
    public static void main(String[] args) 
    {
        Innerclasstr ictr=new Innerclasstr();
        ictr.go();
    }
    void go(){
        //code for construction of frame or window
        frame=new JFrame();
        frame.setSize(300, 300);
        frame.setVisible(true);
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        
        JButton labelbutton=new JButton("change label");
        JButton colorbutton=new JButton("change color");
        label=new JLabel("i am a label");
        drawpanel =new Drawpanel();
        
        frame.getContentPane().add(BorderLayout.WEST,label);
        frame.getContentPane().add(BorderLayout.EAST,labelbutton);
        frame.getContentPane().add(BorderLayout.SOUTH,colorbutton);
        frame.getContentPane().add(BorderLayout.CENTER,drawpanel);
        
        colorbutton.addActionListener(new Color1());
        labelbutton.addActionListener(new Label());
        }
    
    class Label implements ActionListener{
        public void actionPerformed(ActionEvent el)
        {
            label.setText("foolhardy");
        }
    }
    class Color1 implements ActionListener{
        public void actionPerformed(ActionEvent ec)
        {
            for(int i=0;i<130;i++)
            {
            
            x=x+2;
            y=y+2;
            drawpanel.repaint();
            try{Thread.sleep(50);}catch(Exception ex){}
            }
        }
    }


class Drawpanel extends JPanel{
    public void paintComponent(Graphics g){
        Graphics2D g2d=(Graphics2D) g;
        int red=(int)(Math.random()*255);
        int blue=(int)(Math.random())*255;
        int green=(int)( Math.random()*255);
        Color sc=new Color(red,blue,green);
        
        int red1=(int)(Math.random()*255);
        int blue1=(int)(Math.random()*255);
        int green1=(int)(Math.random()*255);
        Color ec=new Color(red1,blue1,green1);
        GradientPaint gp=new GradientPaint(70,70,sc,150,150,ec);
        g2d.setColor(Color.white);
        g2d.fillRect(0, 0, this.getWidth(),this.getHeight());
        g2d.setPaint(gp);
        g2d.fillOval(x, y, 40, 40);
    }
}
}

IMPLEMENTING-ANIMATION
what i want:-
i want the text(on left)to change when i press R.H.S button and animation(a circle moving downwards) to run when i press South side button.
what i am getting:-
what i am getting is rapid movement of circle also when i press LHS which has no relation with the circle thing the color of circle changes.
some1 plse help me......
thanks in adv T_T

[Michael Dunn]

1) never use Thread.sleep in Swing's EDT, use a Timer

2) int x=70,y=70;
should be in DrawPanel, that way the class can be re-used in applets, frames etc,
as is, it can't.

3) do you really want the color of the background and ball to change 20 times per second?
and at random times when the panel is painted? (this happens more often than most realize)

4) class Label implements ActionListener
is really a poor choice for a name - there exists an awt class Label = confusion/conflict

that should do for starters

[Ashutosh Raikvar]

 * To change this template, choose Tools | Templates
 * and open the template in the editor.
 */
package javaapplication14;
import javax.swing.*;
import java.awt.*;
import java.awt.event.*;
public class SimpleAnimation {
int x=70;
int y=70;
    public static void main(String[] args) {
        SimpleAnimation gui=new SimpleAnimation();
        gui.go();
        }
    public void go(){
    JFrame frame =new JFrame();
    frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    MyDrawPanel drawpanel = new MyDrawPanel();
    frame.getContentPane().add(drawpanel);
    frame.setSize(300, 300);
    frame.setVisible(true);
    for(int i=0;i<130;i++)
    {
        x++;
        y++;
        drawpanel.repaint();
        try{
            Thread.sleep(50);
        }catch(Exception ex){
            
        }
    }
}
    class MyDrawPanel extends JPanel
    {
        public void paintComponent(Graphics g){
            g.setColor(Color.white);
            g.fillRect(0, 0, this.getWidth(),this.getHeight());
            g.setColor(Color.green);
        g.fillOval(x, y, 40, 40);
        
        }
    }
}

here is some other working code (with animation working and no major GUI).my code has flaws i would appreciate if you change it to work the way i want it to work.one more thing above code i copied from head-first java book

[fred rosenberger]

I have added code tags to both your posts. Notice how it is now context high-lighted, and the formatting is preserved? This make it MUCH easier to read.

Next time, after you past your code in, highlight it all and hit the little 'code' formatting button - just like you wanted to make it italic or bold.

[Joanne Neal]

Ashutosh Raikvar wrote:here is some other working code (with animation working and no major GUI).my code has flaws i would appreciate if you change it to work the way i want it to work.one more thing above code i copied from head-first java book

And what would you learn if someone did that for you ? It's much better if you make the changes you need and then if you come across a specific problem you can ask about it here.

[Ashutosh Raikvar]

Right now i dont have sufficient knowledge of java programming so i guess i will be able to identify the problem after spending more time programming.thanks for every thing