How to add a merge array from 2 others arrays and print it

[Victor Varela]

Hi, Please I need your help.
I am asking for advice and help on:
(I already try many times but always one of the arrays became empty)

How to add a merge array from 2 others arrays and print it.
This is the code I have written:

//////////////////////////////////////////////////////
public class OrderedApp
   {
   public static void main(String[] args)
      {
      int maxSize = 25;             // array size
      OrdArray arr;                  // reference to array
      arr = new OrdArray(maxSize);   // create the array

      int maxSize1 = 25;                  // arr1ay size
      OrdArray arr1;                    // reference to arr1ay
      arr1 = new OrdArray(maxSize1);    // create the arr1ay
 
      arr.insert(77);     // inserts in array 1          
      arr.insert(13);
      arr.insert(13);
      arr.insert(33);
    		  
      arr1.insertb(47);   // inserts in array 2           
      arr1.insertb(89);
      arr1.insertb(69);
      arr1.insertb(32);
      arr1.insertb(99);

      System.out.print("array 1 \n");
      arr.display();                 // display items again
      System.out.print("===================================================\n");

      System.out.print("array 2 \n");      
      arr1.display();                 // display items 
      System.out.print("===================================================\n");

 

      }
   }
////////////////////////////////////////////////////////////////////

// inside this class add a third array which merge arr and arr1
// and print it
//

class OrdArray
   {
   private static long[] a;          // ref to array a
   private static int nElemsa;       // number of data items

   private long[] b;                // ref to array b
   private int nElemsb;             // number of data items

   //-----------------------------------------------------------
   public OrdArray(int max)          // constructor
      {
      a = new long[max];             // create array
      nElemsa = 0;

      b = new long[max];             // create array
      nElemsb = 0;
      }

   //-----------------------------------------------------------
   public int size()
      { return nElemsa; }

   //-----------------------------------------------------------
   public void insert(long value)     // put element into array
      {
      int j;
      for(j=0; j<nElemsa; j++)        // find where it goes
         if(a[j] > value)             // (linear search)
            break;
      for(int k=nElemsa; k>j; k--)    // move bigger ones up
         a[k] = a[k-1];
      a[j] = value;                   // insert it
      nElemsa++;                      // increment size
      }  // end insert()
   //-----------------------------------------------------------

   public void insertb(long value)     // put element into array
      {
      int j;
      for(j=0; j<nElemsb; j++)         // find where it goes
         if(b[j] > value)              // (linear search)
            break;
      for(int k=nElemsb; k>j; k--)     // move bigger ones up
         b[k] = b[k-1];
      b[j] = value;                    // insert it
      nElemsb++;                       // increment size
      }  // end insert()

   //-----------------------------------------------------------
   public static void display()             // displays array contents
      {
	
      for(int j=0; j<nElemsa; j++)    	   // for each element,
      {
         System.out.print(a[j] + " ");     // display it

      }
         System.out.println(""); 

      }
   //-----------------------------------------------------------
    
// here I added a merge method called from main to read array a and array b
// but when array a has info the array b is empty, and viceveresa

////////////////////////////////////////////////////////////////

}

[Darryl Burke]

Victor, welcome to the Ranch! We don't have too many rules here, but we do ask that you BeForthrightWhenCrossPostingToOtherSites
http://www.java-forums.org/new-java/57515-how-add-merge-array-2-others-arrays.html

[Aditya Jha]

You have to provide your merge method and explain what you have tried to do in it, before one could help you.

By the way, in the code that you have posted, method void display() is static, hence the calls arr.display(); and arr1.display(); are no different. In other words, they are going to perform exactly the same task regardless of which reference you are using to call it. This is why it is always recommended to call static methods using the class name (OrdArray.display();), which avoids confusion.

Please note that this method is printing only one of the two arrays (which may be what you want, but I'm not sure).

[Winston Gutkowski]

Victor Varela wrote:How to add a merge array from 2 others arrays and print it.

That's two separate tasks, and you don't appear to have tried either.
Another little rule we ask is that you ShowSomeEffort (←click).

And before you write your merge() method (or get any suggestions), you also need to tell us what it's supposed to do. As far as I know, all you might need is for it add one array onto the end of the other.

As far as displaying is concerned, you might want to have a look at Arrays.toString() (in fact a look at the whole java.util.Arrays class might not be a bad idea, because it has several methods that you can probably use).

Winston

[Victor Varela]

I have tried the following merge method

   public int[] merge(int[]... arr)
 {
       int arrSize = 0;
       for (int[] array : arr) 
   {
        arrSize += array.length;
   }
       int[] result = new int[arrSize];
       int j = 0; 
     for (int[] array : arr)
 { 
       for (int s : array)
 {  
      result[j++] = s;
                       
 }               
 }               
 return result;   
   }

////////////////////////////////////////////////////

I have tried the following from main

  OrdArray arrC;                  // reference to array
     arrC = new OrdArray(maxSize);   // create the array
int M[] = (int[]) arrC.merge(arr, arr1);

it is giving me the error
The method merge(int[], int[]) in the type OrdArray is not applicable for the arguments (OrdArray,
OrdArrayb)
I have no clue how to mend it

[Victor Varela]

besides... I already have spent 30 hours trying everything I found on internet and still not working.
and this is the result that the program should get
array 1 after sorting
13 33 77
===================================================
array 2 after sorting
32 47 69 89 99
===================================================
Merged Array is:
13 32 33 47 69 77 89 99
===================================================

[Winston Gutkowski]

Victor Varela wrote:it is giving me the error
The method merge(int[], int[]) in the type OrdArray is not applicable for the arguments (OrdArray,
OrdArrayb)

And that's because those arguments are NOT int[]s; they're OrdArrays.

Winston

[Winston Gutkowski]

Victor Varela wrote:besides... I already have spent 30 hours trying everything I found on internet and still not working.
and this is the result that the program should get
array 1 after sorting
13 33 77
===================================================
array 2 after sorting
32 47 69 89 99
===================================================
Merged Array is:
13 32 33 47 69 77 89 99
===================================================

Then you need to look at your merge() method again, because that is NOT what it will produce.

Winston

[Victor Varela]

when I used the following is working ok the merge and the call method, but I need to make it work with arr and arr1 arrays

      OrdArray arrC;                  // reference to array
     arrC = new OrdArray(maxSize);   // create the array
    

      int[] ay1 ={13, 33, 77};
      int[] ay2 ={32, 47, 69, 89, 99};
     
 //     System.out.print("===================================================\n");
      int M[] = (int[]) arrC.merge(ay1, ay2);
      
     System.out.println("Merged Array is: "); 
      for (int i = 0; i < M.length; i++)
      {
   	  System.out.print(M[i]+ " ");
       
      

the code above prints:
Merged Array is:
13 32 33 47 69 77 89 99
===================================================
so the merge method is working ok
for that code
BUT, IT IS NOT what i need... i have to use the arrays created by main with arr.insert

[Winston Gutkowski]

Victor Varela wrote:the code above prints:
Merged Array is:
13 32 33 47 69 77 89 99
===================================================
so the merge method is working ok

Then you must have changed it since you posted, because the code you showed will NOT produce the results above; it will produce a concatenation of the two arrays.

Winston

[Edit] I see now that if you then run insert() on all the elements in your merged array, it might work; but that's NOT what you've posted so far.

[Victor Varela]

I did not changed anything
what I need to make work is creating a third array which will be the merge of two arrays

the two arrays I create in main doing the following coding which will insert and sort them:

//////////////////////////////////////////////////////
public class OrderedApp
   {
   public static void main(String[] args)
      {
      int maxSize = 25;             // array size
      OrdArray arr;                  // reference to array
      arr = new OrdArray(maxSize);   // create the array

      int maxSize1 = 25;                  // arr1ay size
      OrdArray arr1;                    // reference to arr1ay
      arr1 = new OrdArray(maxSize1);    // create the arr1ay
 
      arr.insert(77);     // inserts in array 1          
      arr.insert(13);
      arr.insert(13);
      arr.insert(33);
    		  
      arr1.insertb(47);   // inserts in array 2           
      arr1.insertb(89);
      arr1.insertb(69);
      arr1.insertb(32);
      arr1.insertb(99);
    }
    }
////////////////////////////////////////////////////////////////////

Then I have to create the third array as result of merging the two arrays created in main
and that is where i am lost

when I hardcoded the main using:

     OrdArray arrC;                  // reference to array
     arrC = new OrdArray(maxSize);   // create the array    

      int[] ay1 ={13, 33, 77};
      int[] ay2 ={32, 47, 69, 89, 99};
     
      int M[] = (int[]) arrC.merge(ay1, ay2);
      
     System.out.println("Merged Array is: "); 
      for (int i = 0; i < M.length; i++)
      {
   	  System.out.print(M[i]+ " ");
       

shows me that the merge method is working ok
but i have to remove that hardcode and use the arrays created with the inserts

in all thread of communications I have not changed the methods, code, examples, requirements

recap
I have created two arrays; now i have to create a third array, which is the merge of the two created
and i do not getting results with what i have tried so far