Reading Webservice data and writing into a file

[Igor Santos]

So here I am trying to read some xml from a WSDL Webservice. I read it with a buffer, store it in a String and then save it to a .xml file. Problem is... So far with 200 or so blocks of content, it works. Thought this client is supposed to save data from a hundred thousand blocks of content. What I've read so far that has been useful, but hasn't solved the problem is this: Stack Overflow.

My piece of code is really bad for now. So.. If you guy point me in the right direction and just find a way.
(Here's the code)

	public static void main(String[] args) {
		
		Client obj = new Client();

		String url = "http://200.219.151.59:8080/axis2/services/Webservice/getXMLUsuario?user=user&pass=pass";
		
		String xml = obj.readXML(url);
				
		obj.writeXML("/temp/" + obj.setXMLName() + ".xml", xml);
	
	}

	private String readXML(String url) {	
		String output = "";
		
		try {
			URL urlObj = new URL(url);
			URLConnection tc = urlObj.openConnection();
			
			BufferedReader in = new BufferedReader(new InputStreamReader(tc.getInputStream(), "UTF-8"));
			String line;
			
			while ((line = in.readLine()) != null) {
				output += line + "\n";
			}

			in.close();
		} catch (MalformedURLException e) {
			return e.getMessage();
		} catch (IOException e) {
			return e.getMessage();
		}
		return output;
	}
	
	private void writeXML(String arq, String texto) {		
		if (!"".equals(arq) && arq != null) 
			try {
				File arquivo = new File(arq);
				FileOutputStream fos = new FileOutputStream(arquivo, true);
				
				fos.write(texto.getBytes());
				fos.close();
			} catch (Exception e) {
				e.printStackTrace();
			}
	}
	
	private String setXMLName() {
		GregorianCalendar now = new GregorianCalendar();
		return new SimpleDateFormat("ddMMyyyyHHmmss").format(now.getTime());
 	}

I know the problem with storing the all the xml data into a String. And I tried to use the Read and Write at the same time, but I get some crashes..
As stated above, I just need to be pointed into something helpful

[Anurag Verma]

why are you taking the response into memory & then writing it to file. do reading & writing in parallel, like this -

	private static final int BUFFER_SIZE = 4096; //4096 = 4kb, you can have it as you wish 4kb & 8kb are preferred.

	public void getResponseInFile(String address, File file) throws IOException {
		if (!file.exists()) {
			file.createNewFile();
		}

		InputStream inputStream = null;
		OutputStream outputStream = null;
		try {
			URL url = new URL(address);
			URLConnection connection = url.openConnection();

			inputStream = connection.getInputStream();
			outputStream = new FileOutputStream(file);

			byte[] data;
			if (inputStream.available() > BUFFER_SIZE) {
				data = new byte[BUFFER_SIZE];
			} else {
				data = new byte[inputStream.available()];
			}

			int dataCount;
			while ((dataCount = inputStream.read(data)) > 0) {
				outputStream.write(data, 0, dataCount);
			}

		} finally {
			try {
				inputStream.close();
			} catch (Exception e) {
			}
			try {
				outputStream.close();
			} catch (Exception e) {
			}
		}
	}

[Igor Santos]

Srry I took this long to answer. I was testing it with as many results as possible.
It worked just fine, tyvm! I had never used a BufferedReader with bytes before,
and that's probably the reason I didn't find a solution online for myself.

TYVM indeed, sir