Problem in uploading image to to mysql database

Hi, need some help here, i have a program where a user can input name, city and upload image. when a user click the submit button the name, city and the image(Save as BLOB) must be save in the database. and the image will also save in the desired folder. i have no problem in saving the image in the folder, my problem is it can't save the record to mysql database.

heres my code...

index.jsp

upload.jsp

<%@ page import="java.io.*" %>
<%@ page import="java.sql.*" %>
<%@ page import="java.util.zip.*"%>
<%
    String saveFile = "";
    String contentType = request.getContentType();
    if ((contentType != null) && (contentType.indexOf("multipart/form-data") >= 0)) {
        DataInputStream in = new DataInputStream(request.getInputStream());
        int formDataLength = request.getContentLength();
        byte dataBytes[] = new byte[formDataLength];
        int byteRead = 0;
        int totalBytesRead = 0;
        while (totalBytesRead < formDataLength) {
            byteRead = in.read(dataBytes, totalBytesRead, formDataLength);
            totalBytesRead += byteRead;
        }
        String file = new String(dataBytes);
        saveFile = file.substring(file.indexOf("filename=\"") + 10);
        saveFile = saveFile.substring(0, saveFile.indexOf("\n"));
        saveFile = saveFile.substring(saveFile.lastIndexOf("\\") + 1, saveFile.indexOf("\""));
        int lastIndex = contentType.lastIndexOf("=");
        String boundary = contentType.substring(lastIndex + 1, contentType.length());
        int pos;
        pos = file.indexOf("filename=\"");
        pos = file.indexOf("\n", pos) + 1;
        pos = file.indexOf("\n", pos) + 1;
        pos = file.indexOf("\n", pos) + 1;
        int boundaryLocation = file.indexOf(boundary, pos) - 4;
        int startPos = ((file.substring(0, pos)).getBytes()).length;
        int endPos = ((file.substring(0, boundaryLocation)).getBytes()).length;
        File ff = new File("C:/f/" + saveFile);
        FileOutputStream fileOut = new FileOutputStream(ff);
        fileOut.write(dataBytes, startPos, (endPos - startPos));
        fileOut.flush();
        fileOut.close();
%><Br><table border="2"><tr><td><b>You have successfully upload the file:</b>
            <% out.println(saveFile);%></td></tr></table>
            <%
            String Name = request.getParameter("name");
                    String City = request.getParameter("city");
                    if (Name != null && City != null) {
                    Connection connection = null;
                    String connectionURL = "jdbc:mysql://localhost:3306/dropdown";
                    ResultSet rs = null;
                    PreparedStatement psmnt = null;
                    FileInputStream fis;
                    
                        try {
                            Class.forName("com.mysql.jdbc.Driver").newInstance();
                            connection = DriverManager.getConnection(connectionURL, "root", "password");
                            File f = new File("C:/f/" + saveFile);
                            psmnt = connection.prepareStatement("insert into save_image(name, city, image) values(?, ?, ?)");
                            psmnt.setString(1, Name);
                            psmnt.setString(2, City);
                            fis = new FileInputStream(f);
                            psmnt.setBinaryStream(3, (InputStream) fis, (int) (f.length()));
                            int s = psmnt.executeUpdate();
                            if (s > 0) {
                                System.out.println("Uploaded successfully !");
                            } else {
                                System.out.println("Error!");
                            }
                        } catch (Exception e) {
                            e.printStackTrace();
                        }
                    }
                }
            %>
<a href="view.jsp">View Image</a>

O.T

but when i try to input the record manually to the code like this it will successfully save... see difference in line 53-54(code at the top) from 51-52(here) and i remove some code in line 39-40

<%@ page import="java.io.*" %>
<%@ page import="java.sql.*" %>
<%@ page import="java.util.zip.*"%>
<%
    String saveFile = "";
    String contentType = request.getContentType();
    if ((contentType != null) && (contentType.indexOf("multipart/form-data") >= 0)) {
        DataInputStream in = new DataInputStream(request.getInputStream());
        int formDataLength = request.getContentLength();
        byte dataBytes[] = new byte[formDataLength];
        int byteRead = 0;
        int totalBytesRead = 0;
        while (totalBytesRead < formDataLength) {
            byteRead = in.read(dataBytes, totalBytesRead, formDataLength);
            totalBytesRead += byteRead;
        }
        String file = new String(dataBytes);
        saveFile = file.substring(file.indexOf("filename=\"") + 10);
        saveFile = saveFile.substring(0, saveFile.indexOf("\n"));
        saveFile = saveFile.substring(saveFile.lastIndexOf("\\") + 1, saveFile.indexOf("\""));
        int lastIndex = contentType.lastIndexOf("=");
        String boundary = contentType.substring(lastIndex + 1, contentType.length());
        int pos;
        pos = file.indexOf("filename=\"");
        pos = file.indexOf("\n", pos) + 1;
        pos = file.indexOf("\n", pos) + 1;
        pos = file.indexOf("\n", pos) + 1;
        int boundaryLocation = file.indexOf(boundary, pos) - 4;
        int startPos = ((file.substring(0, pos)).getBytes()).length;
        int endPos = ((file.substring(0, boundaryLocation)).getBytes()).length;
        File ff = new File("C:/f/" + saveFile);
        FileOutputStream fileOut = new FileOutputStream(ff);
        fileOut.write(dataBytes, startPos, (endPos - startPos));
        fileOut.flush();
        fileOut.close();
%><Br><table border="2"><tr><td><b>You have successfully upload the file:</b>
            <% out.println(saveFile);%></td></tr></table>
            <%
           
                    Connection connection = null;
                    String connectionURL = "jdbc:mysql://localhost:3306/dropdown";
                    ResultSet rs = null;
                    PreparedStatement psmnt = null;
                    FileInputStream fis;
                    
                        try {
                            Class.forName("com.mysql.jdbc.Driver").newInstance();
                            connection = DriverManager.getConnection(connectionURL, "root", "password");
                            File f = new File("C:/f/" + saveFile);
                            psmnt = connection.prepareStatement("insert into save_image(name, city, image) values(?, ?, ?)");
                            psmnt.setString(1, "myName");
                            psmnt.setString(2, "myCity");
                            fis = new FileInputStream(f);
                            psmnt.setBinaryStream(3, (InputStream) fis, (int) (f.length()));
                            int s = psmnt.executeUpdate();
                            if (s > 0) {
                                System.out.println("Uploaded successfully !");
                            } else {
                                System.out.println("Error!");
                            }
                        } catch (Exception e) {
                            e.printStackTrace();
                        }
                    }
                }
            %>
<a href="view.jsp">View Image</a>

Why is the upload code in a JSP and not a servlet?

Step1: Change the forma action to submit to a servlet into which you move the upload code.

Thank for replying sir, but can you give me a hint.. like some code to follow.. thanks in advance

Have you moved the code out of the JSP and into a servlet?

And what are the symptoms of your problem? It appears from what you wrote that the record is not being written to the database, but that isn't very helpful. Especially when you have debugging code in place already, which you aren't telling us about.

Hi Bear Bibeault,

i put my code into servlet,

upload.jsp to upload.java

package fileUpload;

import java.io.DataInputStream;
import java.io.File;
import java.io.FileInputStream;
import java.io.FileOutputStream;
import java.io.IOException;
import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.PreparedStatement;
import java.sql.ResultSet;

import javax.servlet.ServletException;
import javax.servlet.annotation.WebServlet;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

/**
 * Servlet implementation class FileUploadServlet
 */
@WebServlet("/FileUploadServlet")
public class FileUploadServlet extends HttpServlet {
	private static final long serialVersionUID = 1L;
       
    /**
     * @see HttpServlet#HttpServlet()
     */
	protected void processRequest(HttpServletRequest request, HttpServletResponse response)  
            throws ServletException, IOException { 
		
		String saveFile = "";
	    String contentType = request.getContentType();

if ((contentType != null) && (contentType.indexOf("multipart/form-data") >= 0)) {
	        DataInputStream in = new DataInputStream(request.getInputStream());
	        int formDataLength = request.getContentLength();
	        byte dataBytes[] = new byte[formDataLength];
	        int byteRead = 0;
	        int totalBytesRead = 0;
	        while (totalBytesRead < formDataLength) {
	            byteRead = in.read(dataBytes, totalBytesRead, formDataLength);
	            totalBytesRead += byteRead;
	        }
	        String file = new String(dataBytes);
	        saveFile = file.substring(file.indexOf("filename=\"") + 10);
	        saveFile = saveFile.substring(0, saveFile.indexOf("\n"));
	        saveFile = saveFile.substring(saveFile.lastIndexOf("\\") + 1, saveFile.indexOf("\""));
	        int lastIndex = contentType.lastIndexOf("=");
	        String boundary = contentType.substring(lastIndex + 1, contentType.length());
	        int pos;
	        pos = file.indexOf("filename=\"");
	        pos = file.indexOf("\n", pos) + 1;
	        pos = file.indexOf("\n", pos) + 1;
	        pos = file.indexOf("\n", pos) + 1;
	        int boundaryLocation = file.indexOf(boundary, pos) - 4;
	        int startPos = ((file.substring(0, pos)).getBytes()).length;
	        int endPos = ((file.substring(0, boundaryLocation)).getBytes()).length;
	        File ff = new File("web/uploadedpics/" + saveFile);
	        FileOutputStream fileOut = new FileOutputStream(ff);
	        fileOut.write(dataBytes, startPos, (endPos - startPos));
	        fileOut.flush();
	        fileOut.close();
	        System.out.println("You have successfully upload the file: "); 
	          
	            
	        String Name = request.getParameter("name");
	        String City = request.getParameter("city");
	               Connection connection = null;
	               String connectionURL = "jdbc:mysql://localhost:3306/dropdown";
	               ResultSet rs = null;
	               PreparedStatement psmnt = null;
	                    FileInputStream fis;
	                   if (Name != null && City != null ) {

try {
	                     Class.forName("com.mysql.jdbc.Driver").newInstance();
	                     connection = DriverManager.getConnection(connectionURL, "root", "password");
	                     File f = new File("/uploadedpics/" + saveFile);
	                     psmnt = connection.prepareStatement("insert into save_image(name, city, image) values(?, ?, ?)");
	                     psmnt.setString(1,Name);
	                     psmnt.setString(2, City);

fis = new FileInputStream(f);
	                     psmnt.setString(3, saveFile);
	                     int s = psmnt.executeUpdate();
	                     	if (s > 0) {
	                            System.out.println("Uploaded successfully !");
	                        } else {
	                            System.out.println("Error!");
	                               }
	               } catch (Exception e) {
	                           e.printStackTrace();
	                         System.out.println(e.getMessage());
	                            }
	                        }
	                  }
	}
	protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
		processRequest(request, response);  
	}
	public String getServletInfo() {  
        return "Short description";  
  
  
    }// </editor-fold>  
}

can you please check if its correct, and after this, what should be my next step?

thanks sir

Daryll sabate wrote:i put my code into servlet

Excellent!

what should be my next step?

Answer Pauls' questions.

Actually my from now i can upload the image and it successfully save in my database, my problem is, i can't save the text input to my database.. it always appear NULL.

so it means the my STRING Name = request.getParameter("name") is not working..

my question is, how can i saved this text input to my database, is it ok if try to use another connection just to get the value of the text input.?

all i want from now is to save that text input to my database.

To me it looks like you're processing a multipart request with that code. I've done that, but I never considered trying to parse the request myself. Instead, I used the Apache FileUpload package which works just fine and I don't have to hack around with boundaries or any of that. And it can store the file upload in a temporary file if you ask it to do so.

Anyway, one feature of multipart request is that what you think of as "parameters" (i.e. the HTML form fields which aren't file uploads) are not treated as request parameters. One of your code samples appeared to be assuming that they were. But they aren't. They are just another "part" of the request (or maybe one part per parameter, I don't know) so you're going to have to extract them from the request in just the same way as you extracted the file upload.

As Paul said use the Apache FileUpload package which is works fine for me.