downloaded file not written properly(File content written from 10th line why)

[rajareddya reddy]

Hi,
My requirement is to get the file content from temporary file and then I am writing to one more file which I created and I need to download the same file. When I am executing the following code , I am able to download the file but I am seeing 10 lines with empty spaces. That means code is writing the conent in the new file from 10th line.Please corerct the code,why its writing content from 10th line in the new file.

<%@ page import="java.io.FileInputStream" %>
<%@ page import="java.io.BufferedInputStream" %>
<%@ page import="java.io.* " %>
<%@ page import="java.io.IOException" %>
<%@ page import="java.util.*" %>
<%@ page errorPage="/thub/transHistory/error_page.jsp" %>
<%@ page import="com.crimsonlogic.trade.thub.transHistory.domain.TransHistoryManager" %>
<%
final TransHistoryManager transHistoryService=new TransHistoryManager();
String ext = new String();
      try{
             String msgId = request.getParameter("id");
             String fileType = request.getParameter("ftype");
           String fileName = transHistoryService.getFileName(msgId,fileType);
           String[] fName = fileName.split("/");
           String fileNameTemp = fName[fName.length-1];
           int index = fileNameTemp.lastIndexOf(".");
           if(index!=-1)
        	   ext =  fileNameTemp.substring(index+1, fileNameTemp.length());
           else
        	   ext = "";
            File file = new File(fileName);
                            String Name = file.getName();
                                 File sourceFile = new File(fileName);
                                                    int size = 0; 
                                                    FileInputStream fis = new FileInputStream(sourceFile);
                                                    byte[] fileContent = new byte[(int)sourceFile.length()];
                                                    fis.read(fileContent);
                                                    response.setContentType("application/x-download");
                                OutputStream out33 = response.getOutputStream();
                                InputStream stream = new FileInputStream(file);
                    			byte[] bytes = new byte[stream.available()];
                				stream.read(bytes);
                				response.setHeader("Content-Disposition", "attachment; filename="+fileNameTemp);
                			     out33.write(fileContent);
                		             out33.flush();
                                     stream.close();
                                     out33.close();
                                     response.flushBuffer();
                                  System.out.println("File Downloaded Successfully");
	  }
	   catch(FileNotFoundException e)
	  {
	  throw e;

	  }
	  catch(Exception e)
	  {
	  throw e;
	  }
%>

[Bear Bibeault]

Step 1: Move the code out of a JSP and into a Java servlet. Then we can take it from there.

[William P O'Sullivan]

1. Bear is right.

2. JSP generates blank lines everywhere and anywhere it can! that is the nature of the beast.

WP

[Rob Spoor]

In this case, lines 1-7 all add one line break before any binary data is written to the response.

[Bear Bibeault]

Please read this article to find out why using a JSP for this purpose is a big FAIL.

[rajareddya reddy]

Thanks for all for your replies.
I tried the same code with servlet . now its working fine.

[Bear Bibeault]

Using the right tool for the job frequently yields better results.