Converting JSP to servlet

[Megha Singhal]

following is the code

int i=0; while(rs.next()){ %>
	<tr><td><input type="checkbox" name="check<%=i%>" value=<%= rs.getString("bookid") %>></td>
	<td><%= rs.getString("bookid") %></td><td><%= rs.getString("author") %></td>
	<td><%= rs.getString("title") %></td>
	</tr><%
	i++;
	}

how can we write following line in servlet

><input type="checkbox" name="check<%=i%>"value=<%= rs.getString("bookid") %>></td>

[Bear Bibeault]

Why would you want to to do that?

Granted, putting JDBC code into a JSP is a bad practice, but so it emitting HTML from a servlet.

if you are going to refactor this code, you should move the JDBC code into the Model layer, and use the servlet to fetch the data from the model as a Java collection, not a result set. This collection will be sent to the JSP page for creating the view.

For more information of properly structuring web apps please read this article.

[Megha Singhal]

Megha Singhal wrote:following is the code

int i=0; while(rs.next()){ %>
	<tr><td><input type="checkbox" name="check<%=i%>" value=<%= rs.getString("bookid") %>></td>
	<td><%= rs.getString("bookid") %></td><td><%= rs.getString("author") %></td>
	<td><%= rs.getString("title") %></td>
	</tr><%
	i++;
	}

how can we write following line in servlet

><input type="checkbox" name="check<%=i%>"value=<%= rs.getString("bookid") %>></td>

i convert it like following, am i wrong somewhere.

 int i=0;
	            while(rs.next()){ 	        	
	            out.println("<tr><td><input type=\"checkbox\" name=\"check '+i+'\" value="+ rs.getString("bookid")+" ></td>"+
	           "<td>"+rs.getString("bookid") +"</td>"+
	            "<td>"+rs.getString("author")+"</td>"+
	        	"<td>"+rs.getString("title")+"</td>"+
	        	"</tr> ");
	        	i++;
	        	}

[bhavesh gawade]

hi,

As long as above servlet code is working well there is no issue. But it might suffer from performance related issue if number of records are more in ResultSet. Use StringBuffer object in loop to create entire output string and then pass the same to out.println() function.

[Megha Singhal]

bhavesh gawade wrote:hi,

As long as above servlet code is working well there is no issue. But it might suffer from performance related issue if number of records are more in ResultSet. Use StringBuffer object in loop to create entire output string and then pass the same to out.println() function.

Thanks for your help, my problem has solved.