Topic is not saved in correct encoding when I post in Tradit

[Migrated From Jforum.net]

Dear Rafael,
I use the CVS code of PostAction.java,v 1.1 2004/08/30 23:51:19, and I found that the insertSave() would save Topic.title in the wrong encoding into jforum_topics when I post a new topic in Traditional Chinese. However, the subject is correctly saved in jforum_topics_text.
I checked the PostCommon.java and PostAction.java, then I fixed the insertSave() with some technique copied from PostCommon.java's fillPostFromRequest(). Here's the fixing:

	public void insertSave() throws Exception
	{
		Topic t = new Topic();
		t.setForumId(Integer.parseInt(JForum.getRequest().getParameter("forum_id")));
		
		if (!this.shallProceed(t.getForumId())) {
			return;
		}

		int topicId = -1;
		
		TopicModel tm = DataAccessDriver.getInstance().newTopicModel();
		PostModel pm = DataAccessDriver.getInstance().newPostModel();
		ForumModel fm = DataAccessDriver.getInstance().newForumModel();
		
		if (JForum.getRequest().getParameter("topic_id") != null) {
			topicId = Integer.parseInt(JForum.getRequest().getParameter("topic_id"));
			t = tm.selectById(topicId);

			// Cannot insert new messages on locked topics
			if (t.getStatus() == Topic.STATUS_LOCKED) {
				this.topicLocked();
				return;
			}
		}
		
		if (JForum.getRequest().getParameter("topic_type") != null) {
			t.setType(Integer.parseInt(JForum.getRequest().getParameter("topic_type")));
		}
		
		UserSession us = SessionFacade.getUserSession();
		User u = new User();
		u.setId(us.getUserId());
		u.setUsername(us.getUsername());

		t.setPostedBy(u);
		
		// Set the Post
		Post p = PostCommon.fillPostFromRequest();
		p.setForumId(Integer.parseInt(JForum.getRequest().getParameter("forum_id")));
		[color=red]// You have to import net.jforum.ActionServletRequest
		String encoding = SystemGlobals.getValue(ConfigKeys.ENCODING);
		System.out.println("PostAction.insertSave():encoding="+encoding);
		ActionServletRequest request = JForum.getRequest();
		request.setCharacterEncoding(encoding);[/color]		        
		boolean preview = (JForum.getRequest().getParameter("preview") != null);
		if (!preview) {
			// If topic_id is -1, then is the first post
			if (topicId == -1) {		
				t.setTime(new GregorianCalendar().getTimeInMillis());
				[color=red]//t.setTitle(JForum.getRequest().getParameter("subject"));
				
				t.setTitle(new String(JForum.getRequest().getParameter("subject").getBytes("ISO-8859-1"), encoding));[/color]				
				
				topicId = tm.addNew(t);
				t.setId(topicId);
				fm.incrementTotalTopics(t.getForumId(), 1);
			}
			else {
				tm.incrementTotalReplies(topicId);
				tm.incrementTotalViews(topicId);
				
				// Ok, we have an answer. Time to notify the subscribed users
				if (SystemGlobals.getBoolValue(ConfigKeys.MAIL_NOTIFY_ANSWERS)) {
					try {
						QueuedExecutor.getInstance().execute(new EmailSenderTask(new TopicSpammer(t, tm.notifyUsers(t))));
					}
					catch (Exception e) {
						// Shall we log the error?
					}
				}
			}
			
			// Topic watch
			if (JForum.getRequest().getParameter("notify") != null) {
				this.watch(tm, topicId, u.getId());
			}
			
			p.setTopicId(topicId);
			
			// Save the remaining stuff
			int postId = pm.addNew(p);
			
			if (JForum.getRequest().getParameter("topic_id") == null) {
				t.setFirstPostId(postId);
			}
			
			t.setLastPostId(postId);
			tm.update(t);
			
			fm.setLastPost(t.getForumId(), postId);
			
			ForumRepository.reloadForum(t.getForumId());
			TopicRepository.clearCache(t.getForumId());

			String path = JForum.getRequest().getContextPath() +"/posts/list/";

			String start = JForum.getRequest().getParameter("start");
			if (start != null && !start.equals("") && !start.equals("0")) {
				int postsPerPage = SystemGlobals.getIntValue(ConfigKeys.POST_PER_PAGE);
				
				int newStart = ((t.getTotalReplies() / postsPerPage) * postsPerPage);
				if (newStart > Integer.parseInt(start)) {
					path += newStart +"/";
				}
				else {
					path += start +"/";
				}
			}

			path += topicId +".page#"+ postId;
			
			JForum.setRedirect(path);
			((HashMap)SessionFacade.getAttribute("topics_tracking")).put(new Integer(t.getId()), new Long(p.getTime()));

			// RSS
			//QueuedExecutor.getInstance().execute(new RSSTask(new TopicRSS()));
		}
		else {
			JForum.getContext().put("preview", true);
			JForum.getContext().put("post", p);
			JForum.getContext().put("topic", t);
			JForum.getContext().put("start", JForum.getRequest().getParameter("start"));
			
			Post postPreview = new Post(p);
			JForum.getContext().put("postPreview", PostCommon.preparePostForDisplay(postPreview));
			
			this.insert();
		}
	}

Hope it can be included into CVS code later.
[originally posted on jforum.net by Anonymous]

[Migrated From Jforum.net]

hm, this problem shouldn't occur. I'll check it.

Rafael
[originally posted on jforum.net by Rafael Steil]