Doubt from Wildcard in generics : Code throwing IndexOutOfBoundsException

[Raj Bhunia]

Can anybody please suggest me why does the below code throws a IndexOutOfBoundsException :

import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;

public class WildcardDemo {

        /* This method copies the content of one list into other */
	public static <T> void copy(List<? super T> dst, List<? extends T> src) {
		for (int i = 0; i < src.size(); i++) {
			dst.set(i, src.get(i)); // copying the content of source list to destination list
		}
	}

	public static void main(String[] args) {
		List<Integer> src = Arrays.asList(1, 2); // Creating source List with some value
		List<Integer> dst = new ArrayList<Integer>(); // Creating  destination List which is initially blank .
		copy(dst, src); // calling the method copy
	}
}

Output :

Exception in thread "main" java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
	at java.util.ArrayList.rangeCheck(ArrayList.java:604)
	at java.util.ArrayList.set(ArrayList.java:397)
	at WildcardDemo.copy(WildcardDemo.java:10)
	at WildcardDemo.main(WildcardDemo.java:17)

[Jeff Verdegan]

It has nothing to do with generics. The error message is telling you exactly what's wrong.

At line 10 of WildcardDemo1.java, you're trying to access the first element (at index 0) of an ArrayList that has no elements.

Go back and read the docs for set() very closely.

And after you've done that, and understand why you're getting the error, change your code to not use set() or get() at all. You should never use get() when iterating a List, and you can just use add() instead of set().

for (T t : src) {
  dst.add(t);
}

But you don't even need to do that:

dst.addAll(src);

The only caveat to these is that if you want dst to exactly match src when you're done, you'll need to call dst.clear() first. And if you want dst to keep its original size but have the same elements as src for whichever indices they both have in common, then you'll need to use set(), but you'll need to alter your approach so that you're not trying to put values in elements that don't exist.

[vipul bondugula]

Jeff Verdegan wrote:
But you don't even need to do that:

dst.addAll(src);

Jeff is right. You don't have to write for loop and then set..

Jeff Verdegan wrote: At line 10 of WildcardDemo1.java, you're trying to access the first element (at index 0) of an ArrayList that has no elements.

But Jeff, If the ArrayList does not contain elements then there is no chance of getting into for loop which is the cause of the IndexOutOfBoundsException, right?

Thanks
BVR.

[Prabaharan Gopalan]

If the ArrayList does not contain elements then there is no chance of getting into for loop which is the cause of the IndexOutOfBoundsException, right?

You mean to say an enhanced for loop would throw an exception if the list is empty? No. it wouldn't. It just won't enter the loop. The reason for the IOOB is because list.set(i, obj) accesses an index in list which will not be there on an empty list, which is what Jeff had mentioned and that's why you'd use add()/addAll() instead of set() when you want to add an element to an empty list.

Please not Line 10 is inside the loop and not the beginning of the loop.

[Winston Gutkowski]

Raj Bhunia wrote:Can anybody please suggest me why does the below code throws a IndexOutOfBoundsException :

I believe the others have covered it for you; however, it may be worth pointing out that you may still have problems when you get the code corrected. Modification methods don't generally work well with wildcards (I suggest you read the Generics tutorial for an explanation why); and in your case the wildcards aren't even the same.

Winston

[Jeff Verdegan]

vipul bondugula wrote:

Jeff Verdegan wrote: At line 10 of WildcardDemo1.java, you're trying to access the first element (at index 0) of an ArrayList that has no elements.

But Jeff, If the ArrayList does not contain elements then there is no chance of getting into for loop which is the cause of the IndexOutOfBoundsException, right?

        for (int i = 0; i < src.size(); i++) {  
            dst.set(i, src.get(i)); // copying the content of source list to destination list  

If src has no elements, then we will not get into the loop. But I didn't say that src has no elements. I also suggested reading the docs for set() more closely.