Program not executing properly

[Joel Mackay]

Hey everybody,

New to the java scene and having major issues, it would be appreciated if someone could have a look at my coding and see where i'm going wrong. I have a few

1. When i press the 'start new game' button the random number resets but not the program doesn't, as it just comes up with an exception error after i enter an input.
2. The program wont work out the median of a sorted array, i think because if the other values are zero that affects it .. what do i need to do to fix it ??
3. I've tried to work out the postion of the random number once the array has been sorted .. i think maybe its the same as the median issue !!
4. I need to work out how the user can only put values in ranging from 7 - 100, if outside those values than an error message and re-entering of an input must occur ... no idea !!
5. I need to work out how to exit a program by entering ' -1 ' .. no idea

//Class 

import java.awt.Container;
import java.awt.FlowLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.util.Arrays;
import javax.swing.*;

public class GuessGame extends JFrame
{
    Container container;
    double median; 
    int guesses;
    int inputGuess; 
    int middle; 
    int position; 
    int [] test = new int [ 10 ]; 
    private JButton newGame; 
    private JLabel message; 
    private JLabel prompt; 
    private JLabel numberInput; 
    private JTextField guessInput; 
    private int countGuess; 
    private int randomNumber; 
    
    public GuessGame()
    {
        //
        super( "Play Guess A Number Game Version 2.1" );
        setLayout( new FlowLayout() );
        
        countGuess = 0;
                
        prompt = new JLabel( "A random number between 7 and 100 has been"
                + " selected." );
        
        numberInput = new JLabel( "Write your number and press enter key: ");
        
        guessInput = new JTextField( 5 );
        guessInput.addActionListener( new GuessHandler() );
        
        message = new JLabel( "The result will be shown here." );
        
        newGame = new JButton( "Start New Game" );
        newGame.addActionListener( new ActionListener()
        {
            @Override
           public void actionPerformed( ActionEvent event )
            {
                guessInput.setText(" ");
                guessInput.setEditable(true);
                
                generateNumber();
                
                
            }
        });
    
        container = getContentPane(); //
        container.add( prompt); //
        container.add( numberInput ); //
        container.add( guessInput ); //
        container.add( message ); //
        container.add( newGame ); //
    
        
        setSize( 380, 150 );
        setVisible( true );
    
        
        generateNumber();
        
    }
        
    private void generateNumber()
    {
        randomNumber = ( int ) ( Math.random() * 93 + 7 );
        System.out.println( randomNumber );
        
    }        
    
    public void processGuessedNumber( int usersGuess )
    {
        int lastDistance;
        int currentDistance;
              
        countGuess++;
        
        if ( countGuess == 1 )
        {
            lastDistance = Math.abs( usersGuess - randomNumber );
            
            if ( usersGuess > randomNumber )
                message.setText( "Higher than correst guess." );
            
            else
                message.setText( "Lower than correct guess." );
                    
        }
    
        else 
        {
            currentDistance = Math.abs( usersGuess - randomNumber );
            
            if ( usersGuess > randomNumber )
            {
                message.setText( "Higher than correct guess." );
                
                lastDistance = currentDistance;
            
            }
        
        else if ( usersGuess < randomNumber )
        {
            message.setText( "Lower than correct guess." );
                                   
            lastDistance = currentDistance;
        
        }
        
            else
            {
                
                message.setText( "Congratulations, your guess is correct!" );
           
                guessInput.setEditable( false );
                countGuess = 0;
                
                findMiddleNumber();
            }
        }
        
    }
    
    //
    public void findMiddleNumber()
    {
        
        
        if ((guesses % 1) == 0)
              
            middle = test[(( guesses + 1) / 2 )];
        
        else 
            
            middle = test[ guesses / 2 ];
        
        System.out.println( Arrays.toString( test ));
        
       sort();
    }
    
    public void calculateMedian()
    {
        
        
        System.out.println( Arrays.toString( test ));
        
                
        if (( guesses % 2 ) == 0 ) 
           
            median = test[ guesses ] / 2.0;
                 
        else 
            median = (test[ ((guesses + 1) / 2 )] + test[ guesses / 2]) / 2.0;
        
        findGuessedNumbers();
    }
       
    public void sort()
    {
        int insert;
        
        for( int next = 1; next < test.length; next++)
        {
            insert = test[ next ];
            
            int moveItem = next;
            
            while( moveItem > 0 && test[ moveItem -1 ] > insert )
            {
                test[ moveItem ] = test[ moveItem -1 ];
                moveItem--;
            }
            test[ moveItem ] = insert;
            
        }    
        
        calculateMedian();
    }
    public String toString()
    {
        return Arrays.toString( test );
        
        
    }
            
   public void findGuessedNumbers()
    {
              
        
        for ( int guesses = 0; guesses < test.length; guesses++ )
        {
            if (( test[ guesses ]) == randomNumber );
                
        
             else
                System.out.println( " " );
        }       
        
        finalOutput();
        
        
    }
   
   
    public void finalOutput()
    {
        JOptionPane.showMessageDialog( null,"Congratulations, your guess "
            + "is correct." + "\n\n1. Middle number from all guessed "
            + "numbers by the user is: " + middle + "\n\r2. Median "
            + " value of all guessed numbers by the user is: " 
            + median + "\n\r3. A position (array index) of correctly "
            + "guessed number in sorted array is: " + position, 
            "Final Output", JOptionPane.PLAIN_MESSAGE ); 
        
    
    }
    
    public static void main( String [] args )
    {
        GuessGame guessGame = new GuessGame();
        
        guessGame.setDefaultCloseOperation( EXIT_ON_CLOSE );
        
        
        
    }        
    
    class GuessHandler implements ActionListener
    {
        @Override
        public void actionPerformed ( ActionEvent event )
        {
           
            
           do
            {
                if ( inputGuess != randomNumber )
                {
                    inputGuess = Integer.parseInt( guessInput.getText() );
                    
                    test[guesses] = inputGuess;
                    processGuessedNumber( inputGuess );
                    guesses++;
                }
                
                else 
                    test[guesses] = inputGuess;
                                       
                    if ( inputGuess >= randomNumber )
                    {
                        break;
                        
                    }            
            }
            
            while ( inputGuess != randomNumber );           
            
        }
    }   
}

[Winston Gutkowski]

Joel Mackay wrote:1. When i press the 'start new game' button the random number resets but not the program doesn't, as it just comes up with an exception error after i enter an input.

Almost certainly because you're not resetting your arrays.

2. The program wont work out the median of a sorted array, i think because if the other values are zero that affects it .. what do i need to do to fix it ??

Again, almost certainly because you're including those 0's in your calculation. You keep track of the number of guesses, don't you?

3. I've tried to work out the postion of the random number once the array has been sorted .. i think maybe its the same as the median issue !!

Probably. My suggestion would be to copy it to an array of the correct length before sorting.

4. I need to work out how the user can only put values in ranging from 7 - 100, if outside those values than an error message and re-entering of an input must occur ... no idea !!

if (!(numberEntered >= 7 && numberEntered <= 99))
    throw new IllegalArgumentException("invalid guess");
or just force them to guess again (eg, by putting it in a while loop).

5. I need to work out how to exit a program by entering ' -1 ' .. no idea

With something very similar to 4. The usual way to exit a program normally is to call System.exit(0).

Just a couple of other points:

if ((guesses % 1) == 0)... will never execute the else block.

You'll find Random.nextInt(limit) is a lot easier to use, and you don't have to worry about casting the result.

You'd be much better off separating your game logic from your display logic entirely. Right now, your code is kind of a mish-mash of the two, so if you run into problems, it's difficult to know which aspect is causing them. Another advantage of doing things that way is that you can decide later on how you want to display it (console, GUI, dialog boxes, or even (eventually) via a browser).

HIH

Winston

[Joel Mackay]

Hello again everyone,

I've tried to sort my coding out like Winston suggested .. hopefully its ok

1. I added an array reset to the generateNumber() method hopeing that this would solve the issue but it continues to throw an error '"AWT-EventQueue-0" java.lang.NumberFormatException: For input string: " 57"
after pressing the 'Start new game' button.

2. I added the ranging loop for 7 - 100, but the inputed value if below 7 or above 100 gets added to the array ... how can i stop this from happening.

3. I still dont have a clue on removing the unwanted zeros from the array to work out the median an position of the random number

import java.awt.Container;
import java.awt.FlowLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.util.Arrays;
import javax.swing.*;

public class GuessGame extends JFrame
{
    Container container;
    double median; 
    int guesses; 
    int inputGuess; 
    int middle; 
    int position; 
    int [] test = new int [ 10 ]; 
    private JButton newGame; 
    private JLabel message; 
    private JLabel prompt;  
    private JLabel numberInput;  
    private JTextField guessInput; 
    private int countGuess; 
    private int randomNumber;  
    
 
    private void generateNumber()
    {
               
        randomNumber = ( int ) ( Math.random() * 93 + 7 );
        System.out.println( randomNumber );
        
        test = new int[ 10 ];
    }        
    
    
    public void processGuessedNumber( int usersGuess )
    {
        int lastDistance;
        int currentDistance;
              
        //       
        countGuess++;
        
        
        if ( usersGuess >= 7 && usersGuess <= 100 )       
        { 
            
        
        if ( countGuess == 1 )
        {
            lastDistance = Math.abs( usersGuess - randomNumber );
            
            if ( usersGuess > randomNumber )
                message.setText( "Higher than correst guess." );
            
            else
                message.setText( "Lower than correct guess." );
                    
        }
    
        else 
        {
            currentDistance = Math.abs( usersGuess - randomNumber );
            
            if ( usersGuess > randomNumber )
            {
                message.setText( "Higher than correct guess." );
                
                lastDistance = currentDistance;
            
            }
        
        else if ( usersGuess < randomNumber )
        {
            message.setText( "Lower than correct guess." );
                                   
            lastDistance = currentDistance;
        
        }
        
            else
            {
                
                message.setText( "Congratulations, your guess is correct!" );
           
                guessInput.setEditable( false );
                countGuess = 0;
                
                findMiddleNumber();
            }
        }
        
        }
        
        else 
        {
            message.setText( " Invalid Guess - Numbers must be "
                    + "between 7 - 100" );
        
        }     
        
    }
    
    //
    public void findMiddleNumber()
    {
        
        
        if (( guesses % 2 ) == 0)
              
            middle = test[(( guesses + 1) / 2 )];
        
        else 
            
            middle = test[ guesses / 2 ];
        
        System.out.println( Arrays.toString( test ));
        
       sort();
    }
    
    public void calculateMedian()
    {
        
        
        
        System.out.println( Arrays.toString( test ));
        
                
        if (( guesses % 2 ) == 0 ) 
           
            median = test[ guesses ] / 2.0;
                 
        else 
            median = (test[ ((guesses + 1) / 2 )] + test[ guesses / 2]) / 2.0;
        
        findGuessedNumbers();
    }
       
    public void sort()
    {
        int insert;
        
        for( int next = 1; next < test.length; next++)
        {
            insert = test[ next ];
            
            int moveItem = next;
            
            while( moveItem > 0 && test[ moveItem -1 ] > insert )
            {
                test[ moveItem ] = test[ moveItem -1 ];
                moveItem--;
            }
            test[ moveItem ] = insert;
            
        }    
        
        calculateMedian();
    }
    public String toString()
    {
        return Arrays.toString( test );
        
        
    }
            
   public void findGuessedNumbers()
    {
              
        
        for ( int guesses = 0; guesses < test.length; guesses++ )
        {
            if (( test[ guesses ]) == randomNumber );
                
        
             else
                System.out.println( " " );
        }       
        
        finalOutput();
        
        
    } public GuessGame()
    {
        //
        super( "Play Guess A Number Game Version 2.1" );
        setLayout( new FlowLayout() );
        
        
        //starts guesses count to 0
        countGuess = 0;
        
        
        //information for user to enter a number between 7 and 100
        prompt = new JLabel( "A random number between 7 and 100 has been"
                + " selected." );
        
        //prompts the user to input a number and press enter
        numberInput = new JLabel( "Write your number and press enter key: ");
        
        //text field for user inputs
        guessInput = new JTextField( 5 );
        guessInput.addActionListener( new GuessHandler() );
        
        //result of guessed numbers 
        message = new JLabel( "The result will be shown here." );
        
        //button to start new game
        newGame = new JButton( "Start New Game" );
        newGame.addActionListener( new ActionListener()
        {
            @Override
            //handle test event
            public void actionPerformed( ActionEvent event )
            {
                //resets text field to null
                guessInput.setText(" ");
                guessInput.setEditable(true);
                
                //generate random number method call
                generateNumber();
                
                
            }//end method actionPerformed
        });
    
        container = getContentPane(); //
        container.add( prompt); //
        container.add( numberInput ); //
        container.add( guessInput ); //
        container.add( message ); //
        container.add( newGame ); //
    
        //sets frame size layout 
        setSize( 380, 150 );
        setVisible( true );
    
        //generate random number method call
        generateNumber();
        
    }
    
    class GuessHandler implements ActionListener
    {
        @Override
        public void actionPerformed ( ActionEvent event )
        {
      
            do
            {
                if ( inputGuess != randomNumber )
                {
                    inputGuess = Integer.parseInt( guessInput.getText() );
                    
                    test[guesses] = inputGuess;
                    processGuessedNumber( inputGuess );
                    guesses++;
                }
                
                else 
                    test[guesses] = inputGuess;
                                       
                    if ( inputGuess != randomNumber )
                    {
                        break;
                        
                    }            
            }
            
            while ( inputGuess != randomNumber );           
            
        }
   
    }
    
    public void finalOutput()
    {
        JOptionPane.showMessageDialog( null,"Congratulations, your guess "
            + "is correct." + "\n\n1. Middle number from all guessed "
            + "numbers by the user is: " + middle + "\n\r2. Median "
            + " value of all guessed numbers by the user is: " 
            + median + "\n\r3. A position (array index) of correctly "
            + "guessed number in sorted array is: " + position, 
            "Final Output", JOptionPane.PLAIN_MESSAGE ); 
            
    }
    
    public static void main( String [] args )
    {
        GuessGame guessGame = new GuessGame();
        
        guessGame.setDefaultCloseOperation( EXIT_ON_CLOSE );
        
        
        
    }
}

[Joel Mackay]

bump ... anyone could they help please !!

[Winston Gutkowski]

Joel Mackay wrote:I've tried to sort my coding out like Winston suggested .. hopefully its ok

1. I added an array reset to the generateNumber() method hopeing that this would solve the issue but it continues to throw an error '"AWT-EventQueue-0" java.lang.NumberFormatException: For input string: " 57"
after pressing the 'Start new game' button.

You do realize that " 57" is not a number? You might try trim()ming the String before you convert.

2. I added the ranging loop for 7 - 100, but the inputed value if below 7 or above 100 gets added to the array ... how can i stop this from happening.

You added the check, but as far as I can see you don't force the user to keep inputting until they get it right. The normal pattern for something like this would be:

int guess = getGuess();
while(guess < 7 || guess > 100) {
   guess = getGuess();
}

I also notice that you add to your guess count before you've made sure that it's OK.

3. I still dont have a clue on removing the unwanted zeros from the array to work out the median an position of the random number

I believe I already suggested one way: copy your array of guesses to a new array of the correct size before you sort/search. Have a look at Arrays.copyOf().

Winston