Having issues with validation code

Below is the validation code, but it is not working.I am not sure where I am going wrong in this?

Replace "User-ID" name of textfield to "UserID".
- in the name creates problem parsing javascript.

Well, the first place you went wrong was when you decided to write your own login instead of using the J2EE standard security system. Do-it-Yourself security systems are horribly insecure. In all the years I've worked with J2EE, I've never run across one that couldn't be cracked in fairly short order.

However, your more immediate problem is that you forgot to return "true" from your validation Javascript.

Tim Holloway wrote:Well, the first place you went wrong was when you decided to write your own login instead of using the J2EE standard security system. Do-it-Yourself security systems are horribly insecure. In all the years I've worked with J2EE, I've never run across one that couldn't be cracked in fairly short order.

However, your more immediate problem is that you forgot to return "true" from your validation Javascript.

Dear Tim,

Yes I know its insecure I just want to do something from Scratch... from start... and be like you people a JavaGuru :)

I am also facing issue in one other code

<html>
    <head>
         <SCRIPT>
            function validateForm()
            {
                
             
             if (document.NF.EID.value=="" )
            {
                alert("Employee ID Should be filled");
                return false;
            }
            if(document.NF.Mob.value=="")
            {
            alert("Mobile Number Should be filled");
                return false;
            }
            
          if(document.NF.FName.value=="")
          {
             alert("First Name Should be filled");
                return false;
          }
          if(document.NF.LName.value=="")
          {
            alert("Last Name should be filled");
          }
          
                
            if(document.NF.PrjctName.value=="")
            { 
            alert("Please mention the Project Name");
            }
            
            if(document.NF.SizeAllocated.Value=="")
            {
               alert("Please specify the size allocated to FTP account");
            }
            }
        </SCRIPT>
        <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
        <title>Add New Ftp account</title>
    </head>
    <body>

<h1>Add New FTP Acct</h1>
    
    <form id="NewFTP" action="AddDetails" formname="NF" onsubmit="javascript:return validateForm();">
            <table><tr><td>Employee id:</td><td><input type="text" name="EID"></td></tr>
                <TR><TD>Mobile Number:</TD><td><input type="text" name="Mob"></td></tr>
            <tr><td>First Name:</td><td><input type="text" name="FName"><BR></TD></TR>
            <tr><td>Last Name:</td><td><input type="text" name="LName"></td></tr>
            <tr> <td>Project Name:</td><td><input type="text" name="PrjctName"></td></tr>
            <tr> <td>Size Allocated:</td><td><input type="text" name="SizeAllocated"></td></tr>
        <tr> <td colspan="2" align="center"><input type="submit" align="center"></td></tr></table>
         
    </form>
    
    </body>
</html>

Not sure where i am going wrong

Hi Vishal,

When you are using Javascript, and want to traverse to the element using the format , then it is better not to include hyphen ('-"). In its place, it is better always to use an underscore("_") or better still to join the words like("userID").

Moreover, I would recommend you to add an attribute "id" to the element. like . In this case you can use the following:
and this will work absolutely fine.

Palak Mathur wrote:
When you are using Javascript, and want to traverse to the element using the format document.xx.yy.value;,

Nope. That's an antiquated format that has lots of problems. Use document.getElementById() or one of the other locator methods. Or use a library such as jQuery.

Moreover, I would recommend you to add an attribute "id" to the element. like <input type="text" id="User-ID" name="User_ID" value="" />. In this case you can use the following:
document.getElementById("User-ID").value and this will work absolutely fine.

This is a better suggestion.