BouncyCastle - Help with correcting deprecated method PGPEncryptedDataGenerator.addMethod(PGPPublicK

[David A Morris]

Hello,

I have a successful implementation using PGPEncryptedDataGenerator.addMethod(PGPPublicKey) as shown below but I notice this is deprecated and we should instead be using addMethod(PGPKeyEncryptionMethodGenerator).

I know I can continue to build my JAR ignoring the warning and simply move on, but I am guessing I "should" fix this now and not worry about getting bitten in the bum later.

Here is what I have that is working now.

			// Initialise the security provider
			Security.addProvider(new BouncyCastleProvider());

			// Initialise encrypted data generator (the new way)
			BcPGPDataEncryptorBuilder builder = new BcPGPDataEncryptorBuilder(PGPEncryptedData.CAST5);
			builder.setSecureRandom(new SecureRandom());
			PGPEncryptedDataGenerator encryptedDataGenerator = new PGPEncryptedDataGenerator(builder);

			// Get all encryption keys and add them to the data generator object
			// The key file can be split by a semicolon (;)
			String[] myKeys = this.getPubKeyFile().split(";");
			for (int i = 0; i <= myKeys.length - 1; i++) {
				FileInputStream pubKey2 = new FileInputStream(myKeys[i]);
				PGPPublicKey encKey2 = readPublicKeyFromCollection(pubKey2);
				encryptedDataGenerator.addMethod(encKey2);
			}

It is the last line in the above code that is reported as deprecated.

I have attempted to correct it by doing the below (which appears to work OK) but I am not sure if I am approaching this the correct way.

				BcPublicKeyKeyEncryptionMethodGenerator encKeyGen = new BcPublicKeyKeyEncryptionMethodGenerator(encKey);
				encryptedDataGenerator.addMethod(encKeyGen);

Am I on the right track or am I barking up the wrong tree with this?

[fancyjavawriter right]

Hi David

I have an implementation just like yours, but I'm gettin an exception in my decryption method, getDataStream() is deprecated, in the documentation says that I have to use method that takes a PublicKeyDataDecryptorFactory do you have the right implementation of this funcionality? this is the code:

            //
            // find the secret key
            //
            Iterator it = enc.getEncyptedDataObjects();
            PGPPrivateKey sKey = null;
            PGPPublicKeyEncryptedData pbe = null;

            while (sKey == null && it.hasNext())
                {
                pbe = (PGPPublicKeyEncryptedData) it.next();

                sKey = findSecretKey(keyIn, pbe.getKeyID(), passPhrase);
            }

            if (sKey == null)
                { //////////////////////
                //sKey = pgpSecretKey;
                //////////////////////
                throw new IllegalArgumentException("secret key for message not found.");
            }

            InputStream clear = pbe.getDataStream(sKey, "BC"); // pbe is null!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!   

            PGPObjectFactory plainFact = new PGPObjectFactory(clear);

I would appreciate any help

[David A Morris]

I'm afraid I have not used the getDataStream() method in my implementation.

I have uploaded my solution onto my website here if you want to take a look.
http://dsmtech.com.au/tutorials/11-java/73-java-and-pgp-to-encrypt-a-file-with-multiple-keys.html