Database connectivity-Context.xml

I have tried database connectivity using context.xml.
The problem is it takes loading the page continuously for database insertion.
is there any additional parameters to be passed in context.xml

please suggest its urgent

<?xml version="1.0" encoding="UTF-8"?>
<Context antiJARLocking="true" path="/sys">
Context.xml file
<Resource name="jdbc/myAPP"
auth="Container"
type="javax.sql.DataSource"
username="sa"
password="sa"
driverClassName="sun.jdbc.odbc.JdbcOdbcDriver"
url="Jdbc:Odbc:testing"
removeAbandoned = "true"
maxActive="10000"
maxIdle="30"
maxWait="10000"
removeAbandonedTimeout="300"
logAbandoned="true"
/>
</Context>

web.xml
.
.
.
<resource-ref>
<description>DB Connection Pool</description>
<res-ref-name>jdbc/myAPP</res-ref-name>
<res-type>javax.sql.DataSource</res-type>
<res-auth>Container</res-auth>
<res-sharing-scope>Shareable</res-sharing-scope>
</resource-ref>
</web-app>

Mariya Antony christopher wrote:I have tried database connectivity using context.xml.
The problem is it takes loading the page continuously for database insertion.
is there any additional parameters to be passed in context.xml

I don't understand what you mean by "It takes loading the page continuously for database insertion". You have to keep reloading the page for successive queries to work? If you are seeing some database records inserted, that is not a connection issue. Would you share your code so we can better understand what is going on?

Tim McGuire wrote:

Mariya Antony christopher wrote:I have tried database connectivity using context.xml.
The problem is it takes loading the page continuously for database insertion.
is there any additional parameters to be passed in context.xml

I don't understand what you mean by "It takes loading the page continuously for database insertion". You have to keep reloading the page for successive queries to work? If you are seeing some database records inserted, that is not a connection issue. Would you share your code so we can better understand what is going on?

Context ctx=new InitialContext();
                DataSource ds=(DataSource) ctx.lookup("java:comp/env/jdbc/myAPP");
                Connection ch1=ds.getConnection();
		Statement s=ch1.createStatement();
		ResultSet rs1=s.executeQuery("select count(*) from issue.issue");
		while(rs1.next())
		{
			count=rs1.getInt(1);
		}
		int count1=count+1;
		String i12=Integer.toString(count1);
		//Connection ch=DriverManager.getConnection("Jdbc:Odbc:issuetracking","sa","sa");
                 Connection ch=ds.getConnection();
		PreparedStatement p=ch.prepareStatement("insert into issue.issue values(?,?,?,?,?,getdate(),?,?)");
		p.setString(1,i12);
		p.setString(2,b);
		p.setString(3,c);
		p.setString(4,d);		
		if(a.equals("y"))
		{
			p.setString(5,"yes");
			p.setString(6,status);
			p.setString(7,cid);
			p.executeUpdate();
		request.setAttribute("issueid",i12);
		//request.setAttribute("counter",0);
		//String user121=request.getParameter("user"); 
		target="attach";
		//return mapping.findForward(target);
		}
		else if(a.equals("n"))
		{						
			p.setString(5,"no");
			p.setString(6,status);
			p.setString(7,cid);
			p.executeUpdate();
			//request.setAttribute("issueid",count1);
			//String user121=request.getParameter("user"); 
			target="success";	
			
		}

My first comment is please read this FAQ SQL column lists

Tim McGuire wrote:

Mariya Antony christopher wrote:I have tried database connectivity using context.xml.
The problem is it takes loading the page continuously for database insertion.
is there any additional parameters to be passed in context.xml

I don't understand what you mean by "It takes loading the page continuously for database insertion". You have to keep reloading the page for successive queries to work? If you are seeing some database records inserted, that is not a connection issue. Would you share your code so we can better understand what is going on?

I am sorry but like Tim, I don't understand what your actual problem is?
is it throwing an exception?
is the update statement taking a very long time?
are you having to refresh the page many times?

Wendy Gibbons wrote:

Tim McGuire wrote:

Mariya Antony christopher wrote:I have tried database connectivity using context.xml.
The problem is it takes loading the page continuously for database insertion.
is there any additional parameters to be passed in context.xml

I don't understand what you mean by "It takes loading the page continuously for database insertion". You have to keep reloading the page for successive queries to work? If you are seeing some database records inserted, that is not a connection issue. Would you share your code so we can better understand what is going on?

I am sorry but like Tim, I don't understand what your actual problem is?
is it throwing an exception?
is the update statement taking a very long time?
are you having to refresh the page many times?

takes long time for database insertion

Mariya Antony christopher wrote:
takes long time for database insertion

and this wasn't a problem when you created the connection in this class as you have commented out here?

you have no code for closing the connection and no try block, which makes me think this isn't your real working code?

If you are not closing the connection in a finally block, this could be gumming up your database.

Tim McGuire wrote:you have no code for closing the connection and no try block, which makes me think this isn't your real working code?

If you are not closing the connection in a finally block, this could be gumming up your database.

Here i have tried code as per your suggestions
whether we have close the Statement,ResultSet in finally block.
The following code will not takes a long time for database insertion

Kindly suggest your comments

Connection ch=null;
try
{
Context ctx = new InitialContext();
DataSource ds = (DataSource)ctx.lookup("java:comp/env/jdbc/myAPP");
if(ctx == null )
throw new Exception("No Context");
ch=ds.getConnection();
Statement s=ch.createStatement();
String ab=a+"%";
String q1="select username from issue.login where username like '"+ab+"'";
ResultSet rs=s.executeQuery(q1);
%>
<%
while(rs.next())
{
String kl=rs.getString(1);
//String gh[]=kl.split(" ");
countries[top]=kl;
%>
<%
out.println(countries[top]);
top++;
}
%>
<%
}
catch(Exception e)
{
out.println(e);
}
finally
{
ch.close();

}
%>

are you doing this inside a jsp file?
I was just wondering what all the <% %> are for?

Wendy Gibbons wrote:are you doing this inside a jsp file?
I was just wondering what all the <% %> are for?

yes in JSP file only,any issues regarding using jsp file

Mariya Antony christopher wrote:

Wendy Gibbons wrote:are you doing this inside a jsp file?
I was just wondering what all the <% %> are for?

yes in JSP file only,any issues regarding using jsp file

There are many reasons not to do such things inside a jsp:

Readability. Use JSTL tags in the view. Keep the java code on the server side.

Separation of Concerns - you should not mix presentation logic and business logic

Reusability - are you going to write this same code over again for the subsequent .jsps you write?

Maintainability - a database column changes and you will be hunting through all your jsps for places to change. better to do this on server side

Breaks OOP - you cannot extend what you have done in a jsp

Getting business logic out of jsp lets you take advantage of the java bean paradigm

finally, due to the above, scriptlets (java code inside of jsp) are used today as a warning sign that a developer does not know what they are doing

Tim McGuire wrote:

Mariya Antony christopher wrote:

Wendy Gibbons wrote:are you doing this inside a jsp file?
I was just wondering what all the <% %> are for?

yes in JSP file only,any issues regarding using jsp file

There are many reasons not to do such things inside a jsp:

Readability. Use JSTL tags in the view. Keep the java code on the server side.
Separation of Concerns - you should not mix presentation logic and business logic
Reusability - are you going to write this same code over again for the subsequent .jsps you write?
Maintainability - a database column changes and you will be hunting through all your jsps for places to change. better to do this on server side
Breaks OOP - you cannot extend what you have done in a jsp
Getting business logic out of jsp lets you take advantage of the java bean paradigm
finally, due to the above, scriptlets (java code inside of jsp) are used today as a warning sign that a developer does not know what they are doing

This is the perfect answer.

Tim McGuire wrote:

Mariya Antony christopher wrote:

Wendy Gibbons wrote:are you doing this inside a jsp file?
I was just wondering what all the <% %> are for?

yes in JSP file only,any issues regarding using jsp file

There are many reasons not to do such things inside a jsp:

Readability. Use JSTL tags in the view. Keep the java code on the server side.
Separation of Concerns - you should not mix presentation logic and business logic
Reusability - are you going to write this same code over again for the subsequent .jsps you write?
Maintainability - a database column changes and you will be hunting through all your jsps for places to change. better to do this on server side
Breaks OOP - you cannot extend what you have done in a jsp
Getting business logic out of jsp lets you take advantage of the java bean paradigm
finally, due to the above, scriptlets (java code inside of jsp) are used today as a warning sign that a developer does not know what they are doing

Thanks for your suggestions.
i will implement your suggestion in my further development