inserting data into DB

when i use this code data is not getting inserted into the data base

<%@page import="java.sql.*;"%>
<html>
<body background="backgrnd[2].gif" bgcolor="#00FF00"><CENTER>
<H1><i>WEB NETWORK MANAGTMENT SYSTEM</i></H1></CENTER>
<FIELDSET>
<LEGEND><h3>okay</h3></LEGEND>

<%
try
{
Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
Connection con= DriverManager.getConnection("jdbc:odbc:dsn99","system","neelima");

PreparedStatement st = con.prepareStatement
("Insert into ID (userid ,fname,lname,password,cpassword,email,address,contactnum)values(?,?,?,?,?,?,?,?)");
String s1=request.getParameter("uId");
String s2=request.getParameter("fName");
String s3=request.getParameter("lName");
String s4=request.getParameter("pwd");

String s5=request.getParameter("cpwd");
String s6=request.getParameter("eMail");
String s7=request.getParameter("addr");
String s8=request.getParameter("contNo");

st.setString(1,s1);
st.setString(2,s2);
st.setString(3,s3);
st.setString(4,s4);
st.setString(5,s5);
st.setString(6,s6);
st.setString(7,s7);
st.setString(8,s8);
st.executeUpdate();
con.close();
}
catch(Exception ex)
{
  %><jsp:forward page="register.jsp"></jsp:forward>
<%}

%>
<center><h2>Registred Succesfully</h2></center>
<p align="center"><u><a href="loginaction.jsp">
<font size="4" color="#0000AE">
Login Now</font></a></u></p>
</FIELDSET>
</body></html>

plzz help me ..............

thank q in advance

I am afraid there are a few problems.
If an exception is thrown it just sends you back to the registration page, which is fine but nowhere do you store/show the details of the exception thrown.

This is actually critical information when trying to fix a problem. You need to display the stack trace somewhere somehow.

just saying it doesn't work is useless please read this link and give us some further information.

Why is this in a JSP and not in a servlet please read this link, do not put java in a jsp page

neelima mullapudi wrote:plzz help me ... thank q in advance

Please use real words when posting to the forums. Abbreviations such as "plzz" in place of "please" and "q" in place of "you" only serve to make your posts more difficult to read and less likely to generate useful responses.

Hi , Neelima ,
Why dont you use MVC for such critical operation that is dealing with Database?

You can write simple Servlet and Java class that will handle your request.

your data base activity should follow below steps , and if your code is in MVC it will better to track where is actual error is coming and
above to maintain your code will be so easy.

check this simple steps:

private void insertDataBase{

System.out.println("Getting All Rows from employee table!");
  Connection con = null;
  String url = "jdbc:mysql://localhost:3306/";  /*your database ip address and port*/
  String db = "jdbc";
  String driver = "sun.jdbc.odbc.JdbcOdbcDriver";
  String user = "system";
  String pass = "system";
  try{
	  Class.forName(driver);
	  con = DriverManager.getConnection(url+db, user, pass);
	  PreparedStatement prst = con.prepareStatement  
		("Insert into ID (userid ,fname,lname,password,cpassword,email,address,contactnum)values(?,?,?,?,?,?,?,?)"); 
	  
	  /*
	   Do get value from servert i,e that will get from jsp for your database columns
	  
	  */
	  prst.executeUpdate();
	  con.close();
  }
  catch (ClassNotFoundException e){
	  System.err.println("Could not load JDBC driver");
	  System.out.println("Exception: " + e);
	  e.printStackTrace();
  }
  catch(SQLException ex){
	  while(ex!=null) {
		System.err.println ("Error msg: " + ex.getMessage());
	  }
  }
}

What is the error you are getting?

hi, I think it is giving error because for 'contno', she might have taken integer type in database and trying to insert string type. She need to use setInteger() method instead of setString().

Please post the error with your problems. It will be easier for us to have an eye on the problem.

start index with 0 not 1. try this.

prashant chindhade wrote:start index with 0 not 1. try this.

Index would start from 1 only.

Palak is right.

In PreparedStatement Index starts from 1 only

janice garcia,
Your post was moved to a new topic.