JTable isCellEditable not working

[Sabine El Rassy]

Hello everyone,

I'm trying to set 3 specific columns editable in my Jtable. Im overriding the method isCellEditable, and the method is returning true for the correct 3 columns But in the interface the columns are not editable. any ideas? here's the code.

package npt.prices;

import java.util.HashMap;
import java.util.List;
import java.util.Map;

import javax.swing.table.AbstractTableModel;
import javax.swing.table.TableModel;

import npt.classes.LinearLineList;
import npt.columns.EnumKeops;
import npt.columns.Filter;

public class PriceTableModel extends AbstractTableModel implements TableModel {

	private static final long serialVersionUID = 1L;
	private List <EnumPrice> columns;//current showing columns
	private List <Prices> data;

	public PriceTableModel(List <EnumPrice> columns,List <Prices> data) {
		this.columns = columns;
		this.data = data;

	}
	public void setData(List <Prices> data){

		this.data=data;
	}
	public void removeCol(EnumPrice ep){
		columns.remove(ep);
	}
	public void addCol(EnumPrice ep){
		if(!columns.contains(ep))
			columns.add(ep);
	}

	@Override
	public Class<?> getColumnClass(int columnIndex) {
		return EnumPrice.class;
	}

	@Override
	public int getColumnCount() {
		return columns.size();
	}

	@Override
	public String getColumnName(int columnIndex) {
		return columns.get(columnIndex).getTitle();
	}

	@Override
	public int getRowCount() {
		return data.size();
	}

	@Override
	public Object getValueAt(int row, int col) {
		return (columns.get(col)).value(data.get(row));
	}

	public boolean isCellEditable(int rowIndex, int columnIndex) {

		if(columns.get(columnIndex)==EnumPrice.FITTING_PRICE || columns.get(columnIndex)==EnumPrice.PIPING_PRICE || columns.get(columnIndex)== EnumPrice.RATIO)
		return true;

		else
 		return false;
	}

	
	public EnumPrice getColumn(int columnIndex){
		return columns.get(columnIndex);
		
	}
	public List<Prices> getData() {
		return data;
	}

}

here's where I create the model and Jtable :

List<EnumPrice> cols=new ArrayList<EnumPrice>();
		List <Prices> priceData=new ArrayList<Prices>();
		

		if(projectCostSheetRadio.isSelected()){
			for(EnumPrice ep: EnumPrice.values()){
				cols.add(ep);
			}
			for(ProjectPriceLine ppl : fillProjectList(getSelectedIdpr()))
				priceData.add(ppl);

		}
		else if(stdCostSheetRadio.isSelected()){
			for(EnumPrice ep: EnumPrice.values()){
				if(ep!=EnumPrice.FITTING_PRICE_STD && ep!=EnumPrice.PIPING_PRICE_STD)
					cols.add(ep);
			}
			for(PriceLine pl : fillStdList(1))
				priceData.add(pl);

		}
model=new PriceTableModel(cols, priceData);

		PriceJtable = new JTable(model);
		PriceJtable.setAutoResizeMode(JTable.AUTO_RESIZE_OFF);
		PriceJtable.getTableHeader().setReorderingAllowed(false);

Thanks for the help

[Michael Dunn]

you may have to post a working demo of the problem.

strip everything unrelated to the problem (listeners etc),
and post something we can compile/run/observe/tinker

[Darryl Burke]

Can't spot what might be wrong there. To get better help sooner, post a SSCCE (Short, Self Contained, Correct (Compilable), Example) that demonstrates the problem.

edit What Michael said

[Sabine El Rassy]

I tried to remove all listeners but nothing changed. Could it be something related to the jscrollpane?

here's a compilable example:

The table model class

package npt.prices;

import java.util.HashMap;
import java.util.List;
import java.util.Map;

import javax.swing.table.AbstractTableModel;
import javax.swing.table.TableModel;

import npt.classes.LinearLineList;
import npt.columns.EnumKeops;
import npt.columns.Filter;

public class PriceTableModelTest extends AbstractTableModel implements TableModel {

	private static final long serialVersionUID = 1L;
	private List <String> columns;//current showing columns
	private List <String> data;

	public PriceTableModelTest(List <String> columns,List <String> data) {
		this.columns = columns;
		this.data = data;

	}
	public void setData(List <String> data){

		this.data=data;
	}
	
	public void addLine(String p){
		if(!data.contains(p))
			data.add(p);
	}
	
	public void removeCol(EnumPrice ep){
		columns.remove(ep);
	}
	public void addCol(String ep){
		if(!columns.contains(ep))
			columns.add(ep);
	}

	@Override
	public Class<?> getColumnClass(int columnIndex) {
		return EnumPrice.class;
	}

	@Override
	public int getColumnCount() {
		return columns.size();
	}

	@Override
	public String getColumnName(int columnIndex) {
		return columns.get(columnIndex).toString();
	}

	@Override
	public int getRowCount() {
		return data.size();
	}

	@Override
	public Object getValueAt(int row, int col) {
		return data.get(row);
	}

	public boolean isCellEditable(int rowIndex, int columnIndex) {
		return true;
	}

	
	public String getColumn(int columnIndex){
			return columns.get(columnIndex);
			}
	public List<String> getData() {
		return data;
	}

}

the interface class

package npt.prices;

import java.awt.Dimension;
import java.awt.Dialog.ModalityType;
import java.util.ArrayList;
import java.util.List;

import javax.swing.ButtonGroup;
import javax.swing.JButton;
import javax.swing.JComboBox;
import javax.swing.JDialog;
import javax.swing.JFileChooser;
import javax.swing.JLabel;
import javax.swing.JPanel;
import javax.swing.JRadioButton;
import javax.swing.JScrollPane;
import javax.swing.JTable;
import javax.swing.JTextField;
import javax.swing.table.AbstractTableModel;
import jxl.write.WriteException;
import net.miginfocom.swing.MigLayout;
import npt.classes.DataManager;
import npt.classes.LineList;
import npt.classes.LineList.LineListSaver;
import npt.columns.EnumKeops;
import npt.columns.Filter;
import npt.columns.Filter.FilterType;
import npt.columns.Filter.sortOrder;
import npt.prices.PriceComparator;
import npt.prices.PriceLine;
import npt.prices.ProjectPriceLine;
import npt.sql.MysqlBulkSaver;
import npt.table.KeopsTableBuilder.Rate;
import npt.util.ColorChooser;
import npt.util.DoubleTextField;
import npt.util.GetRightWindowLocation;
import npt.util.Parameter;
public class BuildTableUI {

	private JDialog window;
	private JTable PriceJtable;
	private PriceTableModelTest model;
	private JPanel mainPane;
	
	public BuildTableUI(){
		mainPane = new JPanel(new MigLayout());
		this.buildPriceTableWindow();
	}

	public void buildPriceTableWindow() {
		this.window = new JDialog();

		//build table
		int popupSizeX = 450;
		//				selectedLine.getLineListList().size()*17 + 100;
		if (popupSizeX >500) {
			popupSizeX = 500;
		}
		window.setTitle("Price Table");
		window.setPreferredSize(new Dimension(1000,popupSizeX));

		JScrollPane scrollPane = new JScrollPane( buildTable());
		scrollPane.setPreferredSize(new Dimension(2000, 2000));

		mainPane.add(scrollPane,"wrap");
		mainPane.setBackground(ColorChooser.programBGColor);
		window.add(mainPane);
		window.pack();
		window.setModalityType(ModalityType.APPLICATION_MODAL); 
		//display window into screen (window will not be outside the screen visible rectangle)
		window.setLocation(GetRightWindowLocation.calcul(window.getSize()));
		window.setVisible(true);

	}

	private JTable buildTable() {
		List<String> cols=new ArrayList<String>();
		List <String> priceData=new ArrayList<String>();

		cols.add("col1");
		cols.add("col2");
		cols.add("col3");

		priceData.add("data1");
		priceData.add("data2");

		model=new PriceTableModelTest(cols, priceData);
		PriceJtable = new JTable(model);
		PriceJtable.setAutoResizeMode(JTable.AUTO_RESIZE_OFF);
		PriceJtable.getTableHeader().setReorderingAllowed(false);

		return PriceJtable;
	}


	
	
	
	public static void main(String[] args) {
		
		new BuildTableUI();
	}
}

thanks again

[Darryl Burke]

Sabine El Rassy wrote:here's a compilable example:

Not with those imports, which include 28 unused imports that only add clutter, it isn't. Everyone doesn't have MigLayout, and I haven't a clue where the two used npt.util classes came from.

[Michael Dunn]

here's your code, rebuilt so we can run it.
added the line to make the middle column uneditable, others editable

it works fine, so the problem must be with your enums or non-standard imports
(and, no, the JScrollPane won't have anything to do with changing the editing function of a JTable)

import java.util.*;
import java.awt.Dimension;
import java.awt.Dialog.ModalityType;
import java.awt.BorderLayout;
import javax.swing.*;
import javax.swing.table.*;
class BuildTableUI {
  private JDialog window;
  private JTable PriceJtable;
  private PriceTableModelTest model;
  private JPanel mainPane;
  public BuildTableUI(){
    mainPane = new JPanel(new BorderLayout());
    this.buildPriceTableWindow();
  }
  public void buildPriceTableWindow() {
    this.window = new JDialog();
    int popupSizeX = 450;
    if (popupSizeX >500) {
      popupSizeX = 500;
    }
    window.setTitle("Price Table");
    window.setPreferredSize(new Dimension(1000,popupSizeX));
    JScrollPane scrollPane = new JScrollPane( buildTable());
    scrollPane.setPreferredSize(new Dimension(2000, 2000));
    mainPane.add(scrollPane);
    window.add(mainPane);
    window.pack();
    window.setVisible(true);
  }
  private JTable buildTable() {
    List<String> cols=new ArrayList<String>();
    List <String> priceData=new ArrayList<String>();
    cols.add("col1");
    cols.add("col2");
    cols.add("col3");
    priceData.add("data1");
    priceData.add("data2");
    model=new PriceTableModelTest(cols, priceData);
    PriceJtable = new JTable(model);
    PriceJtable.setAutoResizeMode(JTable.AUTO_RESIZE_OFF);
    PriceJtable.getTableHeader().setReorderingAllowed(false);
    return PriceJtable;
  }
  public static void main(String[] args) {
    new BuildTableUI();
  }
}
class PriceTableModelTest extends AbstractTableModel implements TableModel {
  private static final long serialVersionUID = 1L;
  private List <String> columns;//current showing columns
  private List <String> data;
  public PriceTableModelTest(List <String> columns,List <String> data) {
    this.columns = columns;
    this.data = data;
  }
  public void setData(List <String> data){
    this.data=data;
  }
  public void addLine(String p){
    if(!data.contains(p))
      data.add(p);
  }
  public void removeCol(String ep){
    columns.remove(ep);
  }
  public void addCol(String ep){
    if(!columns.contains(ep))
      columns.add(ep);
  }
 // @Override
 // public Class<?> getColumnClass(int columnIndex) {
    //return EnumPrice.class;
 // }
  @Override
  public int getColumnCount() {
    return columns.size();
  }
  @Override
  public String getColumnName(int columnIndex) {
    return columns.get(columnIndex).toString();
  }
  @Override
  public int getRowCount() {
    return data.size();
  }
  @Override
  public Object getValueAt(int row, int col) {
    return data.get(row);
  }
  public boolean isCellEditable(int rowIndex, int columnIndex) {
    if(columnIndex == 1) return false;//added this line
    return true;
  }
  public String getColumn(int columnIndex){
      return columns.get(columnIndex);
      }
  public List<String> getData() {
    return data;
  }
}

[Sabine El Rassy]

I found where the error is:
When I override the getColumnClass method, if I put the return type EnumPrice.class the cells wont be editable. If I tried with a return type of String.class it works.
Do you have any idea why the return type EnumPrice.class doesnt work?
thanks

@Override
	public Class<?> getColumnClass(int columnIndex) {
		return EnumPrice.class;
	}

[Michael Dunn]

> Do you have any idea why the return
> type EnumPrice.class doesnt work? 

what is EnumPrice.class?
e.g. a label, a textfield, some-other-component?