Focus problem using JOptionPane.showInternalMessageDialog

[Hitesh P Patel]

I have JFrame, which contain JInternalFrame. JInternalFrame contains 3 labels, 3 textfield and 2 buton.
When user after entering details in textfield click OK, if any of the textfield is left blank a message is displayed and focus should return to that textfield.
When JOptionPane.showMessageDialog is used it works perfect, it display message and focus return to empty textfield.
The problem is when using JOptionPane.showInternalMessageDialog it display message and focus remain on OK button.

Please help and let me know what i am missing in the code.

import java.awt.*;
import javax.swing.*;
import java.awt.event.*;

public class JFrameFocusTest extends JFrame {

    JDesktopPane desktopPane;

    public JFrameFocusTest() {
        setTitle("Main Frame");
        setSize(600, 250);
        setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        desktopPane = new JDesktopPane();
        setContentPane(desktopPane);
        createFrame();
    }

    protected void createFrame() {
        JInternalFrameFocusTest iframe = new JInternalFrameFocusTest();
        iframe.setVisible(true);
        desktopPane.add(iframe);
        iframe.pack();
        try {
            iframe.setSelected(true);
        } catch (java.beans.PropertyVetoException e) {}
    }

    private static void createAndShowGUI() {
        JFrame.setDefaultLookAndFeelDecorated(true);
        JFrameFocusTest frame = new JFrameFocusTest();
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        frame.setVisible(true);
    }

    public static void main(String[] arg) {
        javax.swing.SwingUtilities.invokeLater(new Runnable() {
            public void run() {
                createAndShowGUI();
            }
        });
    }
} // end class JFrameFocusTest

class JInternalFrameFocusTest extends JInternalFrame implements ActionListener {

    JLabel firstNameLabel;
    JLabel middleNameLabel;
    JLabel lastNameLabel;

    JTextField firstNameTextField;
    JTextField middleNameTextField;
    JTextField lastNameTextField;

    JButton okButton;
    JButton cancelButton;

    public JInternalFrameFocusTest() {

        super("Internal Frame", true, true, true, true);

        JPanel inputPanel = new JPanel();
        JPanel buttonPanel = new JPanel();

        firstNameLabel = new JLabel("First Name");
        middleNameLabel  = new JLabel("Middle Name");
        lastNameLabel = new JLabel("Last Name");

        firstNameTextField = new JTextField(5);
        middleNameTextField = new JTextField(5);
        lastNameTextField = new JTextField(5);

        inputPanel.add(firstNameLabel);
        inputPanel.add(firstNameTextField);
        inputPanel.add(middleNameLabel);
        inputPanel.add(middleNameTextField);
        inputPanel.add(lastNameLabel);
        inputPanel.add(lastNameTextField);

        this.add(inputPanel,BorderLayout.NORTH);

        okButton = new JButton("Ok");
        okButton.setActionCommand("OK");
        okButton.addActionListener(this);

        cancelButton = new JButton("Cancel");
        cancelButton.setActionCommand("CANCEL");
        cancelButton.addActionListener(this);

        buttonPanel.add(okButton);
        buttonPanel.add(cancelButton);

        this.add(buttonPanel,BorderLayout.SOUTH);

        setSize(400, 100);
        setLocation(50, 50);
    }

    public void actionPerformed(ActionEvent e) {
        String Message = "";
        String actionCommand = e.getActionCommand();
        if (actionCommand.equalsIgnoreCase("OK")) {
            Message = ValidateForm();
            if (Message == "") {
                System.out.println("Everything is OK");
            }
            else
                //JOptionPane.showMessageDialog(this, Message, "Focus Test", JOptionPane.WARNING_MESSAGE);
                JOptionPane.showInternalMessageDialog(this, Message, "Focus Test", JOptionPane.WARNING_MESSAGE);
        }
    } // end actionPerformed

    private String ValidateForm() {

        String validateForm="";

        if (firstNameTextField.getText().equals("")) {
            validateForm = "Enter First Name";
            firstNameTextField.requestFocusInWindow();
        }
        else if (middleNameTextField.getText().equals("")) {
            validateForm = "Enter Middle Name";
            middleNameTextField.requestFocusInWindow();
        }
        else if (lastNameTextField.getText().equals("")) {
            validateForm = "Enter Last Name";
            lastNameTextField.requestFocusInWindow();
        }
        return validateForm;

    } // end Method ValidateForm

} // end class JInternalFrameFocusTest

[Michael Dunn]

if it works fine for one, but not the other, why waste your time on 'the other'?

[Hitesh P Patel]

Yes it true, but there is two thing.
First : look of message dialog using showMessageDialog and showInternalMessageDialog is different.
Second : I want to know why its not working. I tried but cant figure out the problem, so i posted the same here to get help.

[Michael Dunn]

1) looks like showInternalMessageDialog inherits the L & F of its parent.
it needs a parent (try null as parent) whereas the showMessageDialog doesn't.

2) you'd need to dig into the source codes of both to see what's different.
simple fix is to add the earlier line
Message = ValidateForm();
after the optionPane. having it the second time will only handle the focus request.

[Hitesh P Patel]

1) looks like showInternalMessageDialog inherits the L & F of its parent.
it needs a parent (try null as parent) whereas the showMessageDialog doesn't.

It show Exception in thread "AWT-EventQueue-0" java.lang.RuntimeException: JOptionPane: parentComponent does not have a valid parent

2) you'd need to dig into the source codes of both to see what's different.
simple fix is to add the earlier line
Message = ValidateForm();
after the optionPane. having it the second time will only handle the focus request.

It works that ways and already tried before posting code for help.
It will not be good programming to call the routine twice for focus, but for temporary solution i will go with it until I find any solution.

[Michael Dunn]

here's another way, moving the focus request

import java.awt.*;
import javax.swing.*;
import java.awt.event.*;
class JFrameFocusTest extends JFrame {
    JDesktopPane desktopPane;
    public JFrameFocusTest() {
        setTitle("Main Frame");
        setSize(600, 250);
        setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        desktopPane = new JDesktopPane();
        setContentPane(desktopPane);
        createFrame();
    }
    protected void createFrame() {
        JInternalFrameFocusTest iframe = new JInternalFrameFocusTest();
        iframe.setVisible(true);
        desktopPane.add(iframe);
        iframe.pack();
        try {
            iframe.setSelected(true);
        } catch (java.beans.PropertyVetoException e) {}
    }
    private static void createAndShowGUI() {
        JFrame.setDefaultLookAndFeelDecorated(true);
        JFrameFocusTest frame = new JFrameFocusTest();
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        frame.setVisible(true);
    }
    public static void main(String[] arg) {
        javax.swing.SwingUtilities.invokeLater(new Runnable() {
            public void run() {
                createAndShowGUI();
            }
        });
    }
}
class JInternalFrameFocusTest extends JInternalFrame implements ActionListener {
    JLabel firstNameLabel;
    JLabel middleNameLabel;
    JLabel lastNameLabel;
    JTextField firstNameTextField;
    JTextField middleNameTextField;
    JTextField lastNameTextField;
    JButton okButton;
    JButton cancelButton;
String[] messages = {"Enter First Name","Enter Middle Name","Enter Last Name"};//added
JTextField[] textFields;//added
    public JInternalFrameFocusTest() {
        super("Internal Frame", true, true, true, true);
        JPanel inputPanel = new JPanel();
        JPanel buttonPanel = new JPanel();
        firstNameLabel = new JLabel("First Name");
        middleNameLabel  = new JLabel("Middle Name");
        lastNameLabel = new JLabel("Last Name");
        firstNameTextField = new JTextField(5);
        middleNameTextField = new JTextField(5);
        lastNameTextField = new JTextField(5);
textFields = new JTextField[]{firstNameTextField,middleNameTextField,lastNameTextField};//added
        inputPanel.add(firstNameLabel);
        inputPanel.add(firstNameTextField);
        inputPanel.add(middleNameLabel);
        inputPanel.add(middleNameTextField);
        inputPanel.add(lastNameLabel);
        inputPanel.add(lastNameTextField);
        this.add(inputPanel,BorderLayout.NORTH);
        okButton = new JButton("Ok");
        okButton.setActionCommand("OK");
        okButton.addActionListener(this);
        cancelButton = new JButton("Cancel");
        cancelButton.setActionCommand("CANCEL");
        cancelButton.addActionListener(this);
        buttonPanel.add(okButton);
        buttonPanel.add(cancelButton);
        this.add(buttonPanel,BorderLayout.SOUTH);
        setSize(400, 100);
        setLocation(50, 50);
    }
    public void actionPerformed(ActionEvent e) {
        String actionCommand = e.getActionCommand();
        if (actionCommand.equalsIgnoreCase("OK")) {
            int index = ValidateForm();
            if (index == -1) {
                System.out.println("Everything is OK");
            }
            else{
                //JOptionPane.showMessageDialog(this, messages[index], "Focus Test", JOptionPane.WARNING_MESSAGE);
                JOptionPane.showInternalMessageDialog(this, messages[index], "Focus Test", JOptionPane.WARNING_MESSAGE);
                textFields[index].requestFocusInWindow();
            }
        }
    }
    private int ValidateForm() {
        int index = -1;
        if (firstNameTextField.getText().equals("")) index = 0;
        else if (middleNameTextField.getText().equals("")) index = 1;
        else if (lastNameTextField.getText().equals("")) index = 2;
        return index;
    }
}

[Hitesh P Patel]

Its better solution then calling the routine twice.