RadioButtons used to display unique images..images are not showing.

[Heath Ward]

Hi I have been having some trouble getting my images to display. I decided to try and create a java program that used radio buttons to display an image ..problem is the images will not display. I am using Eclipse and there are no red tag errors in my code ..so I am not sure what I am doing wrong.

import java.awt.*;
import java.awt.event.*;

import javax.swing.*;

public class RadioPics extends JFrame{
	private JLabel pic;
	private Icon[] pics = {new ImageIcon (getClass().getResource("boat.png")),
			               new ImageIcon (getClass().getResource("sophie.png")),
			               new ImageIcon (getClass().getResource("ducks.png")),
			               new ImageIcon (getClass().getResource("mcats.png"))};
	
	private JRadioButton bo;
	private JRadioButton sd;
	private JRadioButton du;
	private JRadioButton mc;
	
	
	public RadioPics (){
		super("PICK AN IMAGE");
		setLayout(new FlowLayout());
		
		
		bo = new JRadioButton("Desert Boat", true);
		sd = new JRadioButton("Sophie Dahl", false);
		du = new JRadioButton("Ducklings", false);
		mc = new JRadioButton("Meerkats", false);
		add(bo);
		add(sd);
		add(du);
		add(mc);
		
		ButtonGroup group = new ButtonGroup();
		group.add(bo);
		group.add(sd);
		group.add(du);
		group.add(mc);
		
		
		bo.addActionListener(new ActionHandler(pics[0]));
		sd.addActionListener(new ActionHandler(pics[1]));
		du.addActionListener(new ActionHandler(pics[2]));
		mc.addActionListener(new ActionHandler(pics[3]));
	}
	
	private class ActionHandler implements ActionListener{
		private Icon jay;
		public ActionHandler(Icon i){
			jay = i;
			
		}
		
		public void actionPerformed(ActionEvent e) {
			if(e.ACTION_PERFORMED==ItemEvent.SELECTED)
			pic=new JLabel(jay);
			add(pic);
			
		}
		
		
	}


}



main class:
import javax.swing.JFrame;

public class RadioPicsMain {

	public static void main(String[] args) {
		RadioPics rp = new RadioPics();
		
		rp.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		rp.setSize(700, 700);
		rp.setVisible(true);
	}

}

I hope you can make sense of this ..I have been studying through RMIT open learning..I live in the country ..and I have been doing some New Boston Tutorials as well.

[Maneesh Godbole]

Welcome to the Ranch.
In future, while posting code, please UseCodeTags I have added them for you this time. As you can see they make the code much more easier to read and understand

            add(pic);  

What do you think this line does. Where does it add the pic?

[Darryl Burke]

In addition to what Maneesh said, what two values do you think this conditional compares?

Heath Ward wrote:

			if(e.ACTION_PERFORMED==ItemEvent.SELECTED)

[Heath Ward]

honestly I'm not to sure..I was just kind of trying a bunch of different things to see if they worked ..I was hoping someone could explain the best way to get the images to show. I am overwhelmed by the overall amount of different classes you can use in Java
and I have probably used the wrong kind of class to make the radio buttons active ..I guess I thought that if the action performed on the button means it is selected then show the appropriate image. It was a stab in the dark.

[Heath Ward]

I figured it out .. I needed to create a JLabel object when I did this it worked.

JLabel pic = new JLabel("images");

I also removed the if action statement stuff and simplified it

[Campbell Ritchie]

It might be worth going back to your ActionHandler and other classes, and writing on a piece of paper which image objects they are related to. You appear to be giving the ActionHandler an image as a field, which is good. So are you using that field to update the display?

[Ashish Agre]

private class ActionHandler implements ActionListener{  
        private Icon jay;  
        public ActionHandler(Icon i){  
            jay = i;  
              
        }  
          
        public void actionPerformed(ActionEvent e) {  

		pic.setIcon(jay);

              
        }  
          
          
    }  

This is inner class modified

add(pic); 

use this code in the constructor and remember after adding component to the panel do validate else add first then manipulate component using setter methods