ValueChangeListener Tag doesn't work

[marwa talaat]

I have a three files index.xhtml,EventsBean.java (Managed Bean) and ValueChangeClass.java

<h:form> <h3>Country</h3> <h:selectOneMenu value="#{event.country}" onchange="submit()"> <f:valueChangeListener type="org.jsf.model.ValueListener"/> <f:selectItems value="#{event.countries}"/> </h:selectOneMenu> <h3>Capital</h3> #{event.capital} </h:form>

My bean

public class EventsBean{

private String capital;
private String country;
String countryCapital;


private String [] countries = {"Select","Egypt","United States","Kuwait","United Kingdom","Saudi Arabia"};

public String[] getCountries() {
    return countries;
  }

// getters and setters
}

The class that implements ValueChangeListener

package org.jsf.model;
import javax.faces.context.FacesContext;
import javax.faces.event.AbortProcessingException;
import javax.faces.event.ValueChangeEvent;
import javax.faces.event.ValueChangeListener;

public class ValueChangeClass implements ValueChangeListener {
String capital;
 @Override
   public void processValueChange(ValueChangeEvent event)throws AbortProcessingException {

if ("Egypt".equals(event.getNewValue())                  capital = "Cairo";
else if ("United Kingdom".equals(event.getNewValue()))   capital = "London";
else if ("Kuwait".equals(event.getNewValue()))           capital = "Kuwait";
else if ("Saudi Arabia".equals(event.getNewValue()))     capital = "Riyadh";
else if ("United States".equals(event.getNewValue()))    capital = "Washington";
else   capital = "";


EventsBean evBean = new EventsBean();
    evBean.setCapital(capital);
}
}

It doesn't work ! Is this way to call setCapital() method right ?

[Tim Holloway]

The more complicated and more JSF-specific your code is, the more likely you're not doing it right. Consider that as the #1 rule for JSF. JSF is designed to do as much for you as possible and do it automatically.

In the case of setting the EventBean's country property, you can discard the valueChangeListener entirely. JSF will automatically invoke the EventBean's setCapital(). Provided of course, that your form does not contain any invalid data in it. When in doubt, add an "<h:messages/>" element to the page.