Regarding absolute path

Hi Folks,
I have one query is that I have developed a program that ask from user to enter the drive( c: d

and the folder name and based on these parameters it calculates the lines of code in that folder of all the files inside that folder but now the problem is lets say one user has kept the folder in C:\Test\ and other user has kept the folder in C:\abc\Test\ so nesting could happen , so to solve this issue ,I was thinking of the logic that to take full absolute path from the user itself , and based on that absolute path my current program will work , please advise how to achieve this, my present logic is

public class FileCountLine {

public static void main(String[] args) throws FileNotFoundException {

Scanner in=new Scanner(System.in);
        System.out.println("Enter the Drive name like C,D,E etc");
        String drive=in.next();
        System.out.println("Enter the main folder name");
        String main_folder=in.next();
        File directory=new File(drive+":"+"//"+main_folder+"//");

Map<String, Integer> result = new HashMap<String, Integer>();
        //File directory = new File("C:/Test/");
        File[] files = directory.listFiles();
        for (File file : files) {
            if (file.isFile()) {
                Scanner scanner = new Scanner(new FileReader(file));
                int lineCount = 0;
                try {
                    for (lineCount = 0; scanner.nextLine() != null; lineCount++);
                } catch (NoSuchElementException e) {
                    result.put(file.getName(), lineCount);
                }
            }
        }

for( Map.Entry<String, Integer> entry:result.entrySet()){
              System.out.println(entry.getKey()+" ==> "+entry.getValue());
            }

/*Set s=result.entrySet();
        Iterator itr=s.iterator();
        while(itr.hasNext())
        {
            Map.Entry m=(Map.Entry)itr.next();
            System.out.println(m.getKey()+"-->"+m.getValue());
         }*/

}
}

Please advise how to add the logic of taking the full absolute path from the user and then working on that absolute path
One more thing is that I was thinking is that from the user will enter the complete path lets say c:/abc/def/Test and that we will accept it as string and based on that we will continue with our existing logic , please advise

Yes, the location of the files is not something you can control or influence in your application so it makes sense to make the user provide all of it.
Some people could be running on unix environments as well.

E Armitage wrote:Yes, the location of the files is not something you can control or influence in your application so it makes sense to make the user provide all of it.
Some people could be running on unix environments as well.

I am talking of windows requirement only ,One more thing is that I was thinking is that from the user will enter the complete path lets say c:/abc/def/Test and that we will accept it as string and based on that we will continue with our existing logic , please advise

naresh saxena wrote:

E Armitage wrote:Yes, the location of the files is not something you can control or influence in your application so it makes sense to make the user provide all of it.
Some people could be running on unix environments as well.

One more thing is that I was thinking is that from the user will enter the complete path lets say c:/abc/def/Test and that we will accept it as string and based on that we will continue with our existing logic , please advise

Sounds viable. You have to worry about the validity of the entered path though because some users will enter an invalid path.
Another option is to add gui capabilities to the program and use a JFileChooser instead.

E Armitage wrote:
Sounds viable. You have to worry about the validity of the entered path though because some users will enter an invalid path.
Another option is to add gui capabilities to the program and use a JFileChooser instead.

Thanks could you please show me how to use jfilechooser as when I am browsing to the particular folder , I want to select the folder only and all the files in that folder to be get selected and the logic of displaying the file name along with Counting lines of code would be the same one as I have shown, Please advise

You tell the chooser to select directories only using

See more details here:http://docs.oracle.com/javase/tutorial/uiswing/components/filechooser.html

E Armitage wrote:You tell the chooser to select directories only using
fileChooser.setFileSelectionMode(JFileChooser.DIRECTORIES_ONLY);
See more details here:http://docs.oracle.com/javase/tutorial/uiswing/components/filechooser.html

Thanks, I have come up with this below piece of code .. first please advise where the changes need to be done so that user click on directory test and it will accept the directory

public class FileBrowse extends JFrame {

private JButton browseSwing = new JButton("Choose File");
private JTextField textField = new JTextField(30);
private JButton approve = new JButton("Ok");

public FileBrowse() {
setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
setSize(600,80);
setResizable(false);

browseSwing.addActionListener(new ActionListener() {
	public void actionPerformed(ActionEvent arg0) {
		if (arg0.getSource()==browseSwing)
		onBrowseSwing();
		}});

Container container = getContentPane();
container.setLayout(new FlowLayout());
container.add(browseSwing);
container.add(textField);
container.add(approve);

//pack();
}

protected void onBrowseSwing() {
JFileChooser fileChooser = new JFileChooser();
int result = fileChooser.showDialog(this, "Open/Save");
if (result == JFileChooser.APPROVE_OPTION) {
File file = fileChooser.getSelectedFile();
textField.setText(file.toString());
String x = file.toString();
fileRead(x);
}
}

public void fileRead(String input){
	try{
	    // Open the file that is the first
	    // command line parameter
	    FileInputStream fstream = new FileInputStream(input);
	    // Get the object of DataInputStream
	    DataInputStream in = new DataInputStream(fstream);
	        BufferedReader br = new BufferedReader(new InputStreamReader(in));
	    String strLine;
	    int count = 0;
	    int count2 = 0;
	    //Read File Line By Line
	    while((strLine = br.readLine())!= null ){
	    	if (strLine.trim().length() != 0){
	    		count++;
	    	}else{
	    		count2++;
	    	}
	    }
	    System.out.println("-------Lines Of COdes-------");
	    System.out.println("number of lines:" + count);
	    System.out.println("number of blank lines:" + count2);
	    //Close the input stream
	    in.close();
	    }catch (Exception e){//Catch exception if any
	      System.err.println("Error: " + e.getMessage());
	    }
}
public static void main(String[] args) {
new FileBrowse().setVisible(true);

}
}

This is my UI but i want to integrate my first piece of code to count the number of lines in all the file , please advise how to do that

You can use a structure like:

import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.io.File;
import javax.swing.JButton;
import javax.swing.JFileChooser;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.SwingUtilities;
import javax.swing.UIManager;

@SuppressWarnings("serial")
public class FileCountPanel extends JPanel implements ActionListener {
    private JButton approve = new JButton("Choose File");
    private JFileChooser fc;

public FileCountPanel() {
        //maybe consider something to display the count results on in the layout
        approve.addActionListener(this);
        add(approve);
    }

public void actionPerformed(ActionEvent e) {
        if (fc == null) {
            fc = new JFileChooser();
            fc.setFileSelectionMode(JFileChooser.DIRECTORIES_ONLY);
        }
        int returnVal = fc.showDialog(this, "Count");
        if (returnVal == JFileChooser.APPROVE_OPTION) {
            File folder = fc.getSelectedFile();
            fileRead(folder);
        }
        fc.setSelectedFile(null);
    }

public void fileRead(File directory) {
        //your logic goes here
        System.out.println("folder selected is "+directory.getAbsolutePath());
    }

private static void createAndShowGUI() {
        JFrame frame = new JFrame("FileCountPanel");
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        frame.add(new FileCountPanel());
        frame.pack();
        frame.setVisible(true);
    }
    public static void main(String[] args) {
        SwingUtilities.invokeLater(new Runnable() {
            public void run() {
                UIManager.put("swing.boldMetal", Boolean.FALSE);
                createAndShowGUI();
            }
        });
    }
}

Your actionPerformed logic should ideally run in its own thread as well if it is to do with IO over an indefinite number and size of files.

Hi Folks,
I have come up with the solution but it is selecting only file , my code is..

public static void main(String[] args) throws FileNotFoundException {
		
		JFileChooser chooser = new JFileChooser();
	    chooser.setCurrentDirectory(new java.io.File("."));
	    chooser.setDialogTitle("counting Line of code");
	    chooser.setFileSelectionMode(JFileChooser.DIRECTORIES_ONLY);
	    chooser.setAcceptAllFileFilterUsed(false);

if (chooser.showOpenDialog(null) == JFileChooser.APPROVE_OPTION)
	    {

Map<String, Integer> result = new HashMap<String, Integer>();
	        File directory = chooser.getCurrentDirectory();
	        File[] files = directory.listFiles();
	        for (File file : files)
	        {
	            if (file.isFile())
	            {
	                Scanner scanner = new Scanner(new FileReader(file));
	                int lineCount = 0;
	                try
	                {
	                    for (lineCount = 0; scanner.nextLine() != null; lineCount++)
	                        ;
	                } catch (NoSuchElementException e)
	                {
	                    result.put(file.getName(), lineCount);
	                }
	            }
	        }

for (Map.Entry<String, Integer> entry : result.entrySet())
	        {
	            System.out.println(entry.getKey() + " ==> " + entry.getValue());
	        }
	    }

but it is selecting only single file

Use chooser.getSelectedFile(); instead of chooser.getCurrentDirectory();

E Armitage wrote:Use chooser.getSelectedFile(); instead of chooser.getCurrentDirectory();

come up with solution that is working..Here below is the piece of code..

JFileChooser chooser = new JFileChooser();
    chooser.setCurrentDirectory(new java.io.File("."));
    chooser.setDialogTitle("choosertitle");
    chooser.setFileSelectionMode(JFileChooser.DIRECTORIES_ONLY);
    chooser.setAcceptAllFileFilterUsed(false);

if (chooser.showOpenDialog(null) == JFileChooser.APPROVE_OPTION)
    {

Map<String, Integer> result = new HashMap<String, Integer>();
        File directory = new File(choosers.getSelectedFile().getAbsolutePath()); //This is where you need to change.
        File[] files = directory.listFiles();
        for (File file : files)
        {
            if (file.isFile())
            {
                Scanner scanner = new Scanner(new FileReader(file));
                int lineCount = 0;
                try
                {
                    for (lineCount = 0; scanner.nextLine() != null; lineCount++)
                        ;
                } catch (NoSuchElementException e)
                {
                    result.put(file.getName(), lineCount);
                }
            }
        }

for (Map.Entry<String, Integer> entry : result.entrySet())
        {
            System.out.println(entry.getKey() + " ==> " + entry.getValue());
        }
    }

You don't need to do

choosers.getSelectedFile() already returns a File so just assign that rather than creating another file object

E Armitage wrote:You don't need to do File directory = new File(choosers.getSelectedFile().getAbsolutePath()); //This is where you need to change.

choosers.getSelectedFile() already returns a File so just assign that rather than creating another file object

File directory = choosers.getSelectedFile();

Thanks Armitage , could you also please advise let say I want initially upon executing the application a main window should come with two button ENTER and EXIT , upon clicking the EXIT the application should end's up and upon clicking on ENTER the my application will open the dialog to select the folder as it is doing presently. what the main objective an main window with two buttons should com up first , please advise how to achiev that and integrate with the present application

See the example structure code (including comments) I posted above.
But what you really need to learn is how to use a layout manager for your swing components. In this case you could use a CardLayout. The excellent tutorial for it is here: http://docs.oracle.com/javase/tutorial/uiswing/layout/card.html

E Armitage wrote:File directory = choosers.getSelectedFile();

Thanks a lot it works , could you also please advise when I execute this application , it is by default when dialog box get opened it is in some other folder location by default , I want that upon execution it is by default in c: location , further user can navigate ,please advise how to achieve this, Thanks in advance.

See the API specs for the JFileChooser constructor that takes a String. Careful that you don't resurrect the problem of coding to a specific platform. Remember that some users won't have a C:\\
You could try fiddling with things like File.listRoots to be sure but I'd think that most users would prefer the default to point to their own default documents folder than to the system's root folder.

E Armitage wrote:See the API specs for the JFileChooser constructor that takes a String. Careful that you don't resurrect the problem of coding to a specific platform. Remember that some users won't have a C:\\
You could try fiddling with things like File.listRoots to be sure but I'd think that most users would prefer the default to point to their own default documents folder than to the system's root folder.

Thanks Achieve that through ...