Insert query from java program

[duhit Choudhary]

package xmlReader;

import java.sql.*;
import java.util.List;
import org.apache.commons.configuration.ConfigurationException;
import org.apache.commons.configuration.HierarchicalConfiguration;
import org.apache.commons.configuration.XMLConfiguration;

public class ITunesCommons {
	static String TrackTypes;
	static String kinds;
	static String artist;
	static String location;
	/**
	 * @param args
	 */
	public static void main(String[] args) {
		
		try
		{
			XMLConfiguration config = new XMLConfiguration("C:\\Users\\pbsl\\Downloads\\itunes.xml");
			System.out.println("---------1---------");
//			Object prop = config.getProperty("Tracks.Track");
//			System.out.println("---------2---------");
//			if(prop instanceOf Collection)
//			{
//				System.out.println("---------3---------");
//			    System.out.println("Number of tables: " + ((Collection<?>) prop).size());
//			}
//			
			@SuppressWarnings("unchecked")
			List<HierarchicalConfiguration> fields = config.configurationsAt("Tracks.Track");
			System.out.println(fields);
			System.out.println("---------2---------");
			for(HierarchicalConfiguration sub : fields)
			{
				System.out.println("---------3---------");
				String TrackTypes = sub.getString("Track-Type");
				System.out.println(TrackTypes);
				String kinds = sub.getString("Kind");
				System.out.println(kinds);
				String artist = sub.getString("Artist");
				System.out.println(artist);
				int trackId = sub.getInt("Track-ID");
				System.out.println(trackId);
				String location = sub.getString("Location");
				System.out.println(location);
			}
		}
		catch (ConfigurationException e) 
		{
			e.printStackTrace();
		}
		try
		{
			 String connectionURL = 
		            "jdbc:mysql://172.16.1.152:3306/mymovie";//machine name, port number, database name
			 
			 Connection connection = null;
			 
			 Statement statement = null;
			 
			 ResultSet rs = null;
			 int updateQuery = 0;
			 
			 Class.forName("com.mysql.jdbc.Driver").newInstance();
			 connection = DriverManager.getConnection(connectionURL, "phpdev", "phpdev");
			 
			 statement = connection.createStatement();
			 
			 String QueryString = "INSERT INTO track( Track-Type, Kind, Location, Artist) VALUES ('
                                  "+TrackTypes+"', '"+kinds+"', '"+location+"','"+artist+"')";
			 
			 updateQuery = statement.executeUpdate(QueryString);
			 
			 if (updateQuery != 0) 
			 {
				  System.out.println("table is created successfully and " + updateQuery + " row is inserted.");
		     }
			 
			  QueryString = "SELECT * from user_master1";
			  rs = statement.executeQuery(QueryString);
			  
			  rs.close();
			  statement.close();
			  connection.close();
		}
		catch (Exception ex)
		{
			ex.printStackTrace();
			  System.out.println("Unable to connect to batabase.");
	    }
	}

}

i have made this program to fire a query from the java program and hence to insert rows in the database. But unfortunately on execution i am getting an exception as :-
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '-Type, Kind, Location, Artist) VALUES ('null', 'null', 'null','null')' at line 1
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) on line 73.... please help and tell where am i wrong!!!

[Paul Clapham]

There's a good chance that you've got the wrong number of quotes, or apostrophes, or that you have them in the wrong place. I suggest dropping the idea of creating an insert query by concatenating strings -- this situation is only one reason why it's a bad idea to do that. Use a PreparedStatement instead.

Also, it looks like the variables you're trying to put into the query (TrackTypes and so on) are all null. Did you expect that to be the case? If not, you might want to find out why that is happening. But use the PreparedStatement regardless.

[chris webster]

Think about your column names in the INSERT:

INSERT INTO track( Track-Type, ....

And use a PreparedStatement.